rust/tests/ui/len_zero.rs

229 lines
4.3 KiB
Rust
Raw Normal View History

2018-07-28 17:34:52 +02:00
#![warn(clippy::len_without_is_empty, clippy::len_zero)]
#![allow(dead_code, unused)]
pub struct PubOne;
impl PubOne {
2017-02-08 14:58:07 +01:00
pub fn len(self: &Self) -> isize {
1
}
}
impl PubOne {
// A second impl for this struct - the error span shouldn't mention this
pub fn irrelevant(self: &Self) -> bool {
false
}
}
// Identical to PubOne, but with an allow attribute on the impl complaining len
pub struct PubAllowed;
2018-07-28 17:34:52 +02:00
#[allow(clippy::len_without_is_empty)]
impl PubAllowed {
pub fn len(self: &Self) -> isize {
1
}
}
2017-02-19 16:39:40 +01:00
// No allow attribute on this impl block, but that doesn't matter - we only require one on the
// impl containing len.
impl PubAllowed {
pub fn irrelevant(self: &Self) -> bool {
false
}
}
struct NotPubOne;
impl NotPubOne {
pub fn len(self: &Self) -> isize {
// no error, len is pub but `NotPubOne` is not exported anyway
1
}
}
struct One;
impl One {
fn len(self: &Self) -> isize {
// no error, len is private, see #1085
1
}
}
pub trait PubTraitsToo {
2017-02-08 14:58:07 +01:00
fn len(self: &Self) -> isize;
}
impl PubTraitsToo for One {
fn len(self: &Self) -> isize {
0
}
}
trait TraitsToo {
fn len(self: &Self) -> isize; // no error, len is private, see #1085
}
impl TraitsToo for One {
fn len(self: &Self) -> isize {
0
}
}
struct HasPrivateIsEmpty;
impl HasPrivateIsEmpty {
pub fn len(self: &Self) -> isize {
1
}
fn is_empty(self: &Self) -> bool {
false
}
}
pub struct HasIsEmpty;
impl HasIsEmpty {
2017-02-08 14:58:07 +01:00
pub fn len(self: &Self) -> isize {
1
}
fn is_empty(self: &Self) -> bool {
false
}
}
struct Wither;
pub trait WithIsEmpty {
fn len(self: &Self) -> isize;
fn is_empty(self: &Self) -> bool;
}
impl WithIsEmpty for Wither {
fn len(self: &Self) -> isize {
1
}
fn is_empty(self: &Self) -> bool {
false
}
}
pub struct HasWrongIsEmpty;
impl HasWrongIsEmpty {
2017-02-08 14:58:07 +01:00
pub fn len(self: &Self) -> isize {
1
}
pub fn is_empty(self: &Self, x: u32) -> bool {
false
}
}
pub trait Empty {
fn is_empty(&self) -> bool;
}
pub trait InheritingEmpty: Empty {
//must not trigger LEN_WITHOUT_IS_EMPTY
fn len(&self) -> isize;
}
fn main() {
let x = [1, 2];
2016-02-24 20:52:47 +01:00
if x.len() == 0 {
println!("This should not happen!");
}
if "".len() == 0 {}
let y = One;
if y.len() == 0 {
//no error because One does not have .is_empty()
println!("This should not happen either!");
}
let z: &TraitsToo = &y;
if z.len() > 0 {
//no error, because TraitsToo has no .is_empty() method
println!("Nor should this!");
}
let has_is_empty = HasIsEmpty;
if has_is_empty.len() == 0 {
println!("Or this!");
}
if has_is_empty.len() != 0 {
println!("Or this!");
}
if has_is_empty.len() > 0 {
println!("Or this!");
}
if has_is_empty.len() < 1 {
println!("Or this!");
}
if has_is_empty.len() >= 1 {
println!("Or this!");
}
if has_is_empty.len() > 1 {
// no error
println!("This can happen.");
}
if has_is_empty.len() <= 1 {
// no error
println!("This can happen.");
}
if 0 == has_is_empty.len() {
println!("Or this!");
}
if 0 != has_is_empty.len() {
println!("Or this!");
}
if 0 < has_is_empty.len() {
println!("Or this!");
}
if 1 <= has_is_empty.len() {
println!("Or this!");
}
if 1 > has_is_empty.len() {
println!("Or this!");
}
if 1 < has_is_empty.len() {
// no error
println!("This can happen.");
}
if 1 >= has_is_empty.len() {
// no error
println!("This can happen.");
}
assert!(!has_is_empty.is_empty());
let with_is_empty: &WithIsEmpty = &Wither;
if with_is_empty.len() == 0 {
println!("Or this!");
}
assert!(!with_is_empty.is_empty());
let has_wrong_is_empty = HasWrongIsEmpty;
if has_wrong_is_empty.len() == 0 {
//no error as HasWrongIsEmpty does not have .is_empty()
println!("Or this!");
}
}
2017-02-25 04:26:33 +01:00
fn test_slice(b: &[u8]) {
if b.len() != 0 {}
2017-02-25 04:26:33 +01:00
}
2017-09-04 17:05:47 +02:00
// this used to ICE
pub trait Foo: Sized {}
pub trait DependsOnFoo: Foo {
fn len(&mut self) -> usize;
}