rust/tests/ui/methods.rs

248 lines
5.0 KiB
Rust
Raw Normal View History

// aux-build:option_helpers.rs
2020-03-10 22:35:07 +01:00
// edition:2018
2019-10-16 19:43:26 +02:00
#![warn(clippy::all, clippy::pedantic)]
#![allow(
clippy::blacklisted_name,
clippy::default_trait_access,
clippy::missing_docs_in_private_items,
clippy::missing_safety_doc,
clippy::non_ascii_literal,
clippy::new_without_default,
clippy::needless_pass_by_value,
clippy::print_stdout,
clippy::must_use_candidate,
clippy::use_self,
clippy::useless_format,
clippy::wrong_self_convention,
2019-10-04 19:18:52 +02:00
clippy::unused_self,
unused
)]
#[macro_use]
extern crate option_helpers;
use std::collections::BTreeMap;
use std::collections::HashMap;
use std::collections::HashSet;
use std::collections::VecDeque;
use std::iter::FromIterator;
2019-02-22 07:05:21 +01:00
use std::ops::Mul;
use std::rc::{self, Rc};
use std::sync::{self, Arc};
use option_helpers::IteratorFalsePositives;
2017-11-03 05:54:35 +01:00
pub struct T;
impl T {
2019-02-22 07:05:21 +01:00
pub fn add(self, other: T) -> T {
self
}
// no error, not public interface
pub(crate) fn drop(&mut self) {}
2019-02-22 07:05:21 +01:00
// no error, private function
fn neg(self) -> Self {
self
}
// no error, private function
fn eq(&self, other: T) -> bool {
true
}
2019-01-31 02:15:29 +01:00
// No error; self is a ref.
2019-02-22 07:05:21 +01:00
fn sub(&self, other: T) -> &T {
self
}
2019-01-31 02:15:29 +01:00
// No error; different number of arguments.
2019-02-22 07:05:21 +01:00
fn div(self) -> T {
self
}
2019-01-31 02:15:29 +01:00
// No error; wrong return type.
fn rem(self, other: T) {}
2019-02-22 07:05:21 +01:00
2019-01-31 02:15:29 +01:00
// Fine
2019-02-22 07:05:21 +01:00
fn into_u32(self) -> u32 {
0
}
2019-02-22 07:05:21 +01:00
fn into_u16(&self) -> u16 {
0
}
2019-02-22 07:05:21 +01:00
fn to_something(self) -> u32 {
0
}
2019-02-22 07:05:21 +01:00
fn new(self) -> Self {
unimplemented!();
}
}
pub struct T1;
impl T1 {
// Shouldn't trigger lint as it is unsafe.
pub unsafe fn add(self, rhs: T1) -> T1 {
self
}
// Should not trigger lint since this is an async function.
pub async fn next(&mut self) -> Option<T1> {
None
}
}
struct Lt<'a> {
foo: &'a u32,
}
impl<'a> Lt<'a> {
2019-01-31 02:15:29 +01:00
// The lifetime is different, but thats irrelevant; see issue #734.
2018-07-28 17:34:52 +02:00
#[allow(clippy::needless_lifetimes)]
2019-02-22 07:05:21 +01:00
pub fn new<'b>(s: &'b str) -> Lt<'b> {
unimplemented!()
}
}
struct Lt2<'a> {
foo: &'a u32,
}
impl<'a> Lt2<'a> {
2019-01-31 02:15:29 +01:00
// The lifetime is different, but thats irrelevant; see issue #734.
2019-02-22 07:05:21 +01:00
pub fn new(s: &str) -> Lt2 {
unimplemented!()
}
}
struct Lt3<'a> {
foo: &'a u32,
}
impl<'a> Lt3<'a> {
2019-01-31 02:15:29 +01:00
// The lifetime is different, but thats irrelevant; see issue #734.
2019-02-22 07:05:21 +01:00
pub fn new() -> Lt3<'static> {
unimplemented!()
}
}
2019-02-22 07:05:21 +01:00
#[derive(Clone, Copy)]
struct U;
impl U {
2019-02-22 07:05:21 +01:00
fn new() -> Self {
U
}
2019-01-31 02:15:29 +01:00
// Ok because `U` is `Copy`.
2019-02-22 07:05:21 +01:00
fn to_something(self) -> u32 {
0
}
}
struct V<T> {
2019-02-22 07:05:21 +01:00
_dummy: T,
}
impl<T> V<T> {
2019-02-22 07:05:21 +01:00
fn new() -> Option<V<T>> {
None
}
}
struct AsyncNew;
impl AsyncNew {
2019-08-09 19:19:49 +02:00
async fn new() -> Option<Self> {
None
}
}
struct BadNew;
impl BadNew {
fn new() -> i32 {
0
}
}
impl Mul<T> for T {
type Output = T;
2019-01-31 02:15:29 +01:00
// No error, obviously.
2019-02-22 07:05:21 +01:00
fn mul(self, other: T) -> T {
self
}
}
2019-01-31 02:15:29 +01:00
/// Checks implementation of `FILTER_NEXT` lint.
#[rustfmt::skip]
fn filter_next() {
let v = vec![3, 2, 1, 0, -1, -2, -3];
2019-01-31 02:15:29 +01:00
// Single-line case.
let _ = v.iter().filter(|&x| *x < 0).next();
2017-02-08 14:58:07 +01:00
2019-01-31 02:15:29 +01:00
// Multi-line case.
2017-02-08 14:58:07 +01:00
let _ = v.iter().filter(|&x| {
*x < 0
}
).next();
2019-01-31 02:15:29 +01:00
// Check that hat we don't lint if the caller is not an `Iterator`.
let foo = IteratorFalsePositives { foo: 0 };
let _ = foo.filter().next();
}
2019-01-31 02:15:29 +01:00
/// Checks implementation of `SEARCH_IS_SOME` lint.
#[rustfmt::skip]
fn search_is_some() {
let v = vec![3, 2, 1, 0, -1, -2, -3];
let y = &&42;
2019-01-31 02:15:29 +01:00
// Check `find().is_some()`, single-line case.
let _ = v.iter().find(|&x| *x < 0).is_some();
let _ = (0..1).find(|x| **y == *x).is_some(); // one dereference less
let _ = (0..1).find(|x| *x == 0).is_some();
2019-08-29 10:06:56 +02:00
let _ = v.iter().find(|x| **x == 0).is_some();
2017-02-08 14:58:07 +01:00
2019-01-31 02:15:29 +01:00
// Check `find().is_some()`, multi-line case.
2017-02-08 14:58:07 +01:00
let _ = v.iter().find(|&x| {
*x < 0
}
).is_some();
2019-01-31 02:15:29 +01:00
// Check `position().is_some()`, single-line case.
let _ = v.iter().position(|&x| x < 0).is_some();
2017-02-08 14:58:07 +01:00
2019-01-31 02:15:29 +01:00
// Check `position().is_some()`, multi-line case.
2017-02-08 14:58:07 +01:00
let _ = v.iter().position(|&x| {
x < 0
}
).is_some();
2019-01-31 02:15:29 +01:00
// Check `rposition().is_some()`, single-line case.
let _ = v.iter().rposition(|&x| x < 0).is_some();
2017-02-08 14:58:07 +01:00
2019-01-31 02:15:29 +01:00
// Check `rposition().is_some()`, multi-line case.
2017-02-08 14:58:07 +01:00
let _ = v.iter().rposition(|&x| {
x < 0
}
).is_some();
2019-01-31 02:15:29 +01:00
// Check that we don't lint if the caller is not an `Iterator`.
let foo = IteratorFalsePositives { foo: 0 };
let _ = foo.find().is_some();
let _ = foo.position().is_some();
let _ = foo.rposition().is_some();
}
fn main() {
2019-10-16 19:43:26 +02:00
filter_next();
search_is_some();
}