rust/tests/ui/format.fixed

68 lines
1.9 KiB
Rust
Raw Normal View History

2019-02-24 06:30:08 +01:00
// run-rustfix
#![allow(clippy::print_literal)]
#![warn(clippy::useless_format)]
struct Foo(pub String);
macro_rules! foo {
2019-03-10 22:07:10 +01:00
($($t:tt)*) => (Foo(format!($($t)*)))
2019-02-24 06:30:08 +01:00
}
fn main() {
"foo".to_string();
"{}".to_string();
"{} abc {}".to_string();
"foo {}\n\" bar".to_string();
2019-02-24 06:30:08 +01:00
"foo".to_string();
2019-03-10 22:07:10 +01:00
format!("{:?}", "foo"); // Don't warn about `Debug`.
2019-02-24 06:30:08 +01:00
format!("{:8}", "foo");
format!("{:width$}", "foo", width = 8);
2019-03-10 22:07:10 +01:00
"foo".to_string(); // Warn when the format makes no difference.
"foo".to_string(); // Warn when the format makes no difference.
2019-02-24 06:30:08 +01:00
format!("foo {}", "bar");
format!("{} bar", "foo");
let arg: String = "".to_owned();
arg.to_string();
2019-03-10 22:07:10 +01:00
format!("{:?}", arg); // Don't warn about debug.
2019-02-24 06:30:08 +01:00
format!("{:8}", arg);
format!("{:width$}", arg, width = 8);
2019-03-10 22:07:10 +01:00
arg.to_string(); // Warn when the format makes no difference.
arg.to_string(); // Warn when the format makes no difference.
2019-02-24 06:30:08 +01:00
format!("foo {}", arg);
format!("{} bar", arg);
2019-03-10 22:07:10 +01:00
// We dont want to warn for non-string args; see issue #697.
2019-02-24 06:30:08 +01:00
format!("{}", 42);
format!("{:?}", 42);
format!("{:+}", 42);
format!("foo {}", 42);
format!("{} bar", 42);
2019-03-10 22:07:10 +01:00
// We only want to warn about `format!` itself.
2019-02-24 06:30:08 +01:00
println!("foo");
println!("{}", "foo");
println!("foo {}", "foo");
println!("{}", 42);
println!("foo {}", 42);
2019-03-10 22:07:10 +01:00
// A `format!` inside a macro should not trigger a warning.
2019-02-24 06:30:08 +01:00
foo!("should not warn");
2019-03-10 22:07:10 +01:00
// Precision on string means slicing without panicking on size.
format!("{:.1}", "foo"); // Could be `"foo"[..1]`
format!("{:.10}", "foo"); // Could not be `"foo"[..10]`
2019-02-24 06:30:08 +01:00
format!("{:.prec$}", "foo", prec = 1);
format!("{:.prec$}", "foo", prec = 10);
42.to_string();
let x = std::path::PathBuf::from("/bar/foo/qux");
x.display().to_string();
2019-08-23 10:46:23 +02:00
// False positive
let a = "foo".to_string();
let _ = Some(a + "bar");
2019-02-24 06:30:08 +01:00
}