2016-04-07 17:46:48 +02:00
|
|
|
use rustc::hir::*;
|
2016-07-14 19:31:17 +02:00
|
|
|
use rustc::lint::*;
|
2017-06-11 04:57:25 +02:00
|
|
|
use rustc::ty::{self, Ty};
|
2017-07-31 12:37:38 +02:00
|
|
|
use rustc::ty::subst::Substs;
|
2017-01-13 17:04:56 +01:00
|
|
|
use rustc_const_eval::ConstContext;
|
2016-01-29 01:54:10 +01:00
|
|
|
use syntax::codemap::Span;
|
2017-06-21 20:04:04 +02:00
|
|
|
use utils::{higher, is_copy, snippet, span_lint_and_sugg};
|
2016-01-29 01:54:10 +01:00
|
|
|
|
2016-08-06 09:55:04 +02:00
|
|
|
/// **What it does:** Checks for usage of `&vec![..]` when using `&[..]` would
|
|
|
|
/// be possible.
|
2016-01-29 01:54:10 +01:00
|
|
|
///
|
|
|
|
/// **Why is this bad?** This is less efficient.
|
|
|
|
///
|
|
|
|
/// **Known problems:** None.
|
|
|
|
///
|
|
|
|
/// **Example:**
|
2016-01-29 22:49:48 +01:00
|
|
|
/// ```rust,ignore
|
2016-01-29 01:54:10 +01:00
|
|
|
/// foo(&vec![1, 2])
|
|
|
|
/// ```
|
|
|
|
declare_lint! {
|
|
|
|
pub USELESS_VEC,
|
|
|
|
Warn,
|
|
|
|
"useless `vec!`"
|
|
|
|
}
|
|
|
|
|
|
|
|
#[derive(Copy, Clone, Debug)]
|
2016-06-10 16:17:20 +02:00
|
|
|
pub struct Pass;
|
2016-01-29 01:54:10 +01:00
|
|
|
|
2016-06-10 16:17:20 +02:00
|
|
|
impl LintPass for Pass {
|
2016-01-29 01:54:10 +01:00
|
|
|
fn get_lints(&self) -> LintArray {
|
|
|
|
lint_array!(USELESS_VEC)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-12-07 13:13:40 +01:00
|
|
|
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass {
|
|
|
|
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
|
2016-03-03 20:09:31 +01:00
|
|
|
// search for `&vec![_]` expressions where the adjusted type is `&[_]`
|
2016-01-29 01:54:10 +01:00
|
|
|
if_let_chain!{[
|
2017-06-11 04:57:25 +02:00
|
|
|
let ty::TyRef(_, ref ty) = cx.tables.expr_ty_adjusted(expr).sty,
|
|
|
|
let ty::TySlice(..) = ty.ty.sty,
|
2016-01-29 01:54:10 +01:00
|
|
|
let ExprAddrOf(_, ref addressee) = expr.node,
|
2016-07-14 19:31:17 +02:00
|
|
|
let Some(vec_args) = higher::vec_macro(cx, addressee),
|
2016-01-29 01:54:10 +01:00
|
|
|
], {
|
2016-07-14 19:31:17 +02:00
|
|
|
check_vec_macro(cx, &vec_args, expr.span);
|
2016-03-28 23:32:55 +02:00
|
|
|
}}
|
|
|
|
|
|
|
|
// search for `for _ in vec![…]`
|
2016-07-14 19:31:17 +02:00
|
|
|
if_let_chain!{[
|
|
|
|
let Some((_, arg, _)) = higher::for_loop(expr),
|
|
|
|
let Some(vec_args) = higher::vec_macro(cx, arg),
|
2017-06-11 04:34:47 +02:00
|
|
|
is_copy(cx, vec_type(cx.tables.expr_ty_adjusted(arg))),
|
2016-07-14 19:31:17 +02:00
|
|
|
], {
|
2016-05-20 19:18:32 +02:00
|
|
|
// report the error around the `vec!` not inside `<std macros>:`
|
2017-08-31 14:47:45 +02:00
|
|
|
let span = arg.span.ctxt().outer().expn_info().map(|info| info.call_site).expect("unable to get call_site");
|
2016-07-14 19:31:17 +02:00
|
|
|
check_vec_macro(cx, &vec_args, span);
|
|
|
|
}}
|
2016-03-28 23:32:55 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-09-13 15:34:04 +02:00
|
|
|
fn check_vec_macro<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, vec_args: &higher::VecArgs<'tcx>, span: Span) {
|
2016-07-14 19:31:17 +02:00
|
|
|
let snippet = match *vec_args {
|
|
|
|
higher::VecArgs::Repeat(elem, len) => {
|
2017-07-31 12:37:38 +02:00
|
|
|
let parent_item = cx.tcx.hir.get_parent(len.id);
|
|
|
|
let parent_def_id = cx.tcx.hir.local_def_id(parent_item);
|
|
|
|
let substs = Substs::identity_for_item(cx.tcx, parent_def_id);
|
2017-08-09 09:30:56 +02:00
|
|
|
if ConstContext::new(cx.tcx, cx.param_env.and(substs), cx.tables)
|
|
|
|
.eval(len)
|
|
|
|
.is_ok()
|
|
|
|
{
|
2016-07-14 19:31:17 +02:00
|
|
|
format!("&[{}; {}]", snippet(cx, elem.span, "elem"), snippet(cx, len.span, "len")).into()
|
|
|
|
} else {
|
|
|
|
return;
|
2016-03-28 23:32:55 +02:00
|
|
|
}
|
2016-12-20 18:21:30 +01:00
|
|
|
},
|
2017-09-05 11:33:04 +02:00
|
|
|
higher::VecArgs::Vec(args) => if let Some(last) = args.iter().last() {
|
|
|
|
let span = args[0].span.to(last.span);
|
2016-01-29 01:54:10 +01:00
|
|
|
|
2017-09-05 11:33:04 +02:00
|
|
|
format!("&[{}]", snippet(cx, span, "..")).into()
|
|
|
|
} else {
|
|
|
|
"&[]".into()
|
2016-12-20 18:21:30 +01:00
|
|
|
},
|
2016-07-14 19:31:17 +02:00
|
|
|
};
|
2016-01-29 01:54:10 +01:00
|
|
|
|
2017-08-09 09:30:56 +02:00
|
|
|
span_lint_and_sugg(
|
|
|
|
cx,
|
|
|
|
USELESS_VEC,
|
|
|
|
span,
|
|
|
|
"useless use of `vec!`",
|
|
|
|
"you can use a slice directly",
|
|
|
|
snippet,
|
|
|
|
);
|
2016-01-29 01:54:10 +01:00
|
|
|
}
|
|
|
|
|
2016-07-14 19:31:17 +02:00
|
|
|
/// Return the item type of the vector (ie. the `T` in `Vec<T>`).
|
2017-06-11 04:57:25 +02:00
|
|
|
fn vec_type(ty: Ty) -> Ty {
|
2016-09-09 20:24:20 +02:00
|
|
|
if let ty::TyAdt(_, substs) = ty.sty {
|
2016-08-28 17:25:41 +02:00
|
|
|
substs.type_at(0)
|
2016-07-14 19:31:17 +02:00
|
|
|
} else {
|
|
|
|
panic!("The type of `vec!` is a not a struct?");
|
|
|
|
}
|
|
|
|
}
|