2013-10-21 21:10:57 +02:00
|
|
|
## How to submit a bug report
|
|
|
|
|
|
|
|
|
|
If you're just reporting a bug, please see:
|
|
|
|
|
|
|
|
|
|
https://github.com/mozilla/rust/wiki/HOWTO-submit-a-Rust-bug-report
|
|
|
|
|
|
2012-12-27 23:58:45 +01:00
|
|
|
## Pull request procedure
|
|
|
|
|
|
2013-06-13 23:41:34 +02:00
|
|
|
Pull requests should be targeted at Rust's `master` branch.
|
2013-06-05 16:04:39 +02:00
|
|
|
Before pushing to your Github repo and issuing the pull request,
|
|
|
|
|
please do two things:
|
2012-12-27 23:58:45 +01:00
|
|
|
|
2013-06-05 16:04:39 +02:00
|
|
|
1. [Rebase](http://git-scm.com/book/en/Git-Branching-Rebasing) your
|
2013-06-13 23:41:34 +02:00
|
|
|
local changes against the `master` branch. Resolve any conflicts
|
2013-06-05 16:04:39 +02:00
|
|
|
that arise.
|
2012-12-27 23:58:45 +01:00
|
|
|
|
2013-06-05 16:04:39 +02:00
|
|
|
2. Run the full Rust test suite with the `make check` command. You're
|
|
|
|
|
not off the hook even if you just stick to documentation; code
|
|
|
|
|
examples in the docs are tested as well!
|
2012-12-27 23:58:45 +01:00
|
|
|
|
2013-06-05 16:04:39 +02:00
|
|
|
Pull requests will be treated as "review requests", and we will give
|
|
|
|
|
feedback we expect to see corrected on
|
|
|
|
|
[style](https://github.com/mozilla/rust/wiki/Note-style-guide) and
|
|
|
|
|
substance before pulling. Changes contributed via pull request should
|
|
|
|
|
focus on a single issue at a time, like any other. We will not accept
|
|
|
|
|
pull-requests that try to "sneak" unrelated changes in.
|
2012-12-27 23:58:45 +01:00
|
|
|
|
2013-06-05 16:04:39 +02:00
|
|
|
Normally, all pull requests must include regression tests (see
|
|
|
|
|
[Note-testsuite](https://github.com/mozilla/rust/wiki/Note-testsuite))
|
|
|
|
|
that test your change. Occasionally, a change will be very difficult
|
|
|
|
|
to test for. In those cases, please include a note in your commit
|
|
|
|
|
message explaining why.
|
|
|
|
|
|
|
|
|
|
In the licensing header at the beginning of any files you change,
|
|
|
|
|
please make sure the listed date range includes the current year. For
|
|
|
|
|
example, if it's 2013, and you change a Rust file that was created in
|
|
|
|
|
2010, it should begin:
|
2013-01-29 20:07:02 +01:00
|
|
|
|
|
|
|
|
```
|
|
|
|
|
// Copyright 2010-2013 The Rust Project Developers.
|
|
|
|
|
```
|
|
|
|
|
|
2013-06-05 16:04:39 +02:00
|
|
|
For more details, please refer to
|
|
|
|
|
[Note-development-policy](https://github.com/mozilla/rust/wiki/Note-development-policy).
|
