2018-10-06 18:18:06 +02:00
|
|
|
// Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT
|
|
|
|
// file at the top-level directory of this distribution.
|
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
|
|
// option. This file may not be copied, modified, or distributed
|
|
|
|
// except according to those terms.
|
|
|
|
|
2018-07-28 17:34:52 +02:00
|
|
|
#![warn(clippy::let_unit_value)]
|
2015-09-10 08:51:14 +02:00
|
|
|
#![allow(unused_variables)]
|
|
|
|
|
|
|
|
macro_rules! let_and_return {
|
|
|
|
($n:expr) => {{
|
|
|
|
let ret = $n;
|
2018-12-09 23:26:16 +01:00
|
|
|
}};
|
2015-09-10 08:51:14 +02:00
|
|
|
}
|
2015-08-12 11:31:09 +02:00
|
|
|
|
|
|
|
fn main() {
|
2017-02-08 14:58:07 +01:00
|
|
|
let _x = println!("x");
|
2018-12-09 23:26:16 +01:00
|
|
|
let _y = 1; // this is fine
|
|
|
|
let _z = ((), 1); // this as well
|
2015-08-12 11:31:09 +02:00
|
|
|
if true {
|
2017-02-08 14:58:07 +01:00
|
|
|
let _a = ();
|
2015-08-12 11:31:09 +02:00
|
|
|
}
|
2015-09-10 08:51:14 +02:00
|
|
|
|
2017-08-18 16:07:39 +02:00
|
|
|
consume_units_with_for_loop(); // should be fine as well
|
|
|
|
|
2015-09-10 08:51:14 +02:00
|
|
|
let_and_return!(()) // should be fine
|
2015-08-12 11:31:09 +02:00
|
|
|
}
|
2015-09-10 08:51:14 +02:00
|
|
|
|
2017-08-18 16:07:39 +02:00
|
|
|
// Related to issue #1964
|
|
|
|
fn consume_units_with_for_loop() {
|
|
|
|
// `for_let_unit` lint should not be triggered by consuming them using for loop.
|
|
|
|
let v = vec![(), (), ()];
|
|
|
|
let mut count = 0;
|
|
|
|
for _ in v {
|
|
|
|
count += 1;
|
|
|
|
}
|
|
|
|
assert_eq!(count, 3);
|
|
|
|
|
2017-08-18 16:29:05 +02:00
|
|
|
// Same for consuming from some other Iterator<Item = ()>.
|
2017-08-18 16:07:39 +02:00
|
|
|
let (tx, rx) = ::std::sync::mpsc::channel();
|
|
|
|
tx.send(()).unwrap();
|
2017-08-18 16:29:05 +02:00
|
|
|
drop(tx);
|
|
|
|
|
2017-08-18 16:07:39 +02:00
|
|
|
count = 0;
|
|
|
|
for _ in rx.iter() {
|
|
|
|
count += 1;
|
|
|
|
}
|
|
|
|
assert_eq!(count, 1);
|
|
|
|
}
|
|
|
|
|
2015-09-10 08:51:14 +02:00
|
|
|
#[derive(Copy, Clone)]
|
|
|
|
pub struct ContainsUnit(()); // should be fine
|