2017-02-20 04:50:31 +01:00
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2017-10-08 03:23:41 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:12:23
|
|
|
|
|
|
|
|
|
12 | fn foo<T: Default>(v: Vec<T>, w: Vec<T>, mut x: Vec<T>, y: Vec<T>) -> Vec<T> {
|
|
|
|
| ^^^^^^ help: consider changing the type to: `&[T]`
|
|
|
|
|
|
|
|
|
= note: `-D needless-pass-by-value` implied by `-D warnings`
|
2017-02-20 04:50:31 +01:00
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2017-10-08 03:23:41 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:26:11
|
2017-02-20 04:50:31 +01:00
|
|
|
|
|
2017-10-08 03:23:41 +02:00
|
|
|
26 | fn bar(x: String, y: Wrapper) {
|
2017-07-21 10:40:23 +02:00
|
|
|
| ^^^^^^ help: consider changing the type to: `&str`
|
2017-02-20 04:50:31 +01:00
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2017-10-08 03:23:41 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:26:22
|
2017-02-20 04:50:31 +01:00
|
|
|
|
|
2017-10-08 03:23:41 +02:00
|
|
|
26 | fn bar(x: String, y: Wrapper) {
|
2017-07-21 10:40:23 +02:00
|
|
|
| ^^^^^^^ help: consider taking a reference instead: `&Wrapper`
|
2017-02-20 04:50:31 +01:00
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2017-10-08 03:23:41 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:32:71
|
2017-02-20 04:50:31 +01:00
|
|
|
|
|
2017-10-08 03:23:41 +02:00
|
|
|
32 | fn test_borrow_trait<T: Borrow<str>, U: AsRef<str>, V>(t: T, u: U, v: V) {
|
|
|
|
| ^ help: consider taking a reference instead: `&V`
|
2017-02-20 04:50:31 +01:00
|
|
|
|
2017-02-20 08:45:37 +01:00
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2017-10-08 03:23:41 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:44:18
|
2017-02-20 08:45:37 +01:00
|
|
|
|
|
2017-10-08 03:23:41 +02:00
|
|
|
44 | fn test_match(x: Option<Option<String>>, y: Option<Option<String>>) {
|
2017-02-20 08:45:37 +01:00
|
|
|
| ^^^^^^^^^^^^^^^^^^^^^^
|
|
|
|
|
|
|
|
|
help: consider taking a reference instead
|
2017-07-10 15:29:29 +02:00
|
|
|
|
|
2017-10-08 03:23:41 +02:00
|
|
|
44 | fn test_match(x: &Option<Option<String>>, y: Option<Option<String>>) {
|
|
|
|
45 | match *x {
|
2017-07-10 15:29:29 +02:00
|
|
|
|
|
2017-02-20 08:45:37 +01:00
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2017-10-08 03:23:41 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:57:24
|
2017-02-20 08:45:37 +01:00
|
|
|
|
|
2017-10-08 03:23:41 +02:00
|
|
|
57 | fn test_destructure(x: Wrapper, y: Wrapper, z: Wrapper) {
|
2017-07-21 10:40:23 +02:00
|
|
|
| ^^^^^^^ help: consider taking a reference instead: `&Wrapper`
|
2017-02-20 08:45:37 +01:00
|
|
|
|
2017-02-20 10:18:31 +01:00
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
2017-10-08 03:23:41 +02:00
|
|
|
--> $DIR/needless_pass_by_value.rs:57:36
|
2017-02-20 10:18:31 +01:00
|
|
|
|
|
2017-10-08 03:23:41 +02:00
|
|
|
57 | fn test_destructure(x: Wrapper, y: Wrapper, z: Wrapper) {
|
2017-02-20 10:18:31 +01:00
|
|
|
| ^^^^^^^
|
|
|
|
|
|
|
|
|
help: consider taking a reference instead
|
2017-07-10 15:29:29 +02:00
|
|
|
|
|
2017-10-08 03:23:41 +02:00
|
|
|
57 | fn test_destructure(x: Wrapper, y: &Wrapper, z: Wrapper) {
|
|
|
|
58 | let Wrapper(s) = z; // moved
|
|
|
|
59 | let Wrapper(ref t) = *y; // not moved
|
|
|
|
60 | let Wrapper(_) = *y; // still not moved
|
|
|
|
|
|
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
|
|
--> $DIR/needless_pass_by_value.rs:73:49
|
2017-07-10 15:29:29 +02:00
|
|
|
|
|
2017-10-08 03:23:41 +02:00
|
|
|
73 | fn test_blanket_ref<T: Foo, S: Serialize>(_foo: T, _serializable: S) {}
|
|
|
|
| ^ help: consider taking a reference instead: `&T`
|
2017-02-20 10:18:31 +01:00
|
|
|
|
2017-10-08 10:51:44 +02:00
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
|
|
--> $DIR/needless_pass_by_value.rs:75:18
|
|
|
|
|
|
|
|
|
75 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
|
|
|
|
| ^^^^^^ help: consider taking a reference instead: `&String`
|
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
|
|
--> $DIR/needless_pass_by_value.rs:75:29
|
|
|
|
|
|
|
|
|
75 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
|
|
|
|
| ^^^^^^
|
|
|
|
|
|
|
|
|
help: consider changing the type to
|
|
|
|
|
|
|
|
|
75 | fn issue_2114(s: String, t: &str, u: Vec<i32>, v: Vec<i32>) {
|
|
|
|
| ^^^^
|
|
|
|
help: change `t.clone()` to
|
|
|
|
|
|
|
|
|
77 | let _ = t.to_string();
|
|
|
|
| ^^^^^^^^^^^^^
|
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
|
|
--> $DIR/needless_pass_by_value.rs:75:40
|
|
|
|
|
|
|
|
|
75 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
|
|
|
|
| ^^^^^^^^ help: consider taking a reference instead: `&Vec<i32>`
|
|
|
|
|
|
|
|
error: this argument is passed by value, but not consumed in the function body
|
|
|
|
--> $DIR/needless_pass_by_value.rs:75:53
|
|
|
|
|
|
|
|
|
75 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: Vec<i32>) {
|
|
|
|
| ^^^^^^^^
|
|
|
|
|
|
|
|
|
help: consider changing the type to
|
|
|
|
|
|
|
|
|
75 | fn issue_2114(s: String, t: String, u: Vec<i32>, v: &[i32]) {
|
|
|
|
| ^^^^^^
|
|
|
|
help: change `v.clone()` to
|
|
|
|
|
|
|
|
|
79 | let _ = v.to_owned();
|
|
|
|
| ^^^^^^^^^^^^
|
|
|
|
|