2020-02-09 06:00:49 +01:00
|
|
|
// Dogfood cannot run on Windows
|
|
|
|
#![cfg(not(windows))]
|
2020-10-06 08:20:18 +02:00
|
|
|
#![feature(once_cell)]
|
2020-02-09 06:00:49 +01:00
|
|
|
|
2020-10-06 08:20:18 +02:00
|
|
|
use std::lazy::SyncLazy;
|
2020-10-17 19:48:40 +02:00
|
|
|
use std::path::{Path, PathBuf};
|
2020-02-01 18:00:48 +01:00
|
|
|
use std::process::Command;
|
|
|
|
|
|
|
|
mod cargo;
|
|
|
|
|
2020-10-06 08:20:18 +02:00
|
|
|
static CLIPPY_PATH: SyncLazy<PathBuf> = SyncLazy::new(|| cargo::TARGET_LIB.join("cargo-clippy"));
|
2020-02-01 18:00:48 +01:00
|
|
|
|
2017-12-15 10:02:39 +01:00
|
|
|
#[test]
|
2019-09-11 20:52:36 +02:00
|
|
|
fn dogfood_clippy() {
|
|
|
|
// run clippy on itself and fail the test if lint warnings are reported
|
2020-02-09 06:00:49 +01:00
|
|
|
if cargo::is_rustc_test_suite() {
|
2018-01-18 22:02:58 +01:00
|
|
|
return;
|
|
|
|
}
|
2020-02-01 18:00:48 +01:00
|
|
|
let root_dir = PathBuf::from(env!("CARGO_MANIFEST_DIR"));
|
2018-11-21 16:14:42 +01:00
|
|
|
|
2020-11-16 12:44:05 +01:00
|
|
|
let mut command = Command::new(&*CLIPPY_PATH);
|
|
|
|
command
|
|
|
|
.current_dir(root_dir)
|
|
|
|
.env("CLIPPY_DOGFOOD", "1")
|
|
|
|
.env("CARGO_INCREMENTAL", "0")
|
2020-12-11 23:54:47 +01:00
|
|
|
.arg("clippy")
|
2020-11-16 12:44:05 +01:00
|
|
|
.arg("--all-targets")
|
|
|
|
.arg("--all-features")
|
|
|
|
.arg("--")
|
|
|
|
.args(&["-D", "clippy::all"])
|
|
|
|
.args(&["-D", "clippy::pedantic"])
|
|
|
|
.arg("-Cdebuginfo=0"); // disable debuginfo to generate less data in the target dir
|
|
|
|
|
|
|
|
// internal lints only exist if we build with the internal-lints feature
|
|
|
|
if cfg!(feature = "internal-lints") {
|
|
|
|
command.args(&["-D", "clippy::internal"]);
|
|
|
|
}
|
|
|
|
|
|
|
|
let output = command.output().unwrap();
|
|
|
|
|
2018-11-21 16:14:42 +01:00
|
|
|
println!("status: {}", output.status);
|
|
|
|
println!("stdout: {}", String::from_utf8_lossy(&output.stdout));
|
|
|
|
println!("stderr: {}", String::from_utf8_lossy(&output.stderr));
|
|
|
|
|
|
|
|
assert!(output.status.success());
|
|
|
|
}
|
|
|
|
|
2018-11-30 19:54:47 +01:00
|
|
|
#[test]
|
2019-09-11 20:52:36 +02:00
|
|
|
fn dogfood_subprojects() {
|
2020-10-17 19:48:40 +02:00
|
|
|
fn test_no_deps_ignores_path_deps_in_workspaces() {
|
|
|
|
fn clean(cwd: &Path, target_dir: &Path) {
|
|
|
|
Command::new("cargo")
|
|
|
|
.current_dir(cwd)
|
|
|
|
.env("CARGO_TARGET_DIR", target_dir)
|
|
|
|
.arg("clean")
|
|
|
|
.args(&["-p", "subcrate"])
|
|
|
|
.args(&["-p", "path_dep"])
|
|
|
|
.output()
|
|
|
|
.unwrap();
|
|
|
|
}
|
|
|
|
|
|
|
|
if cargo::is_rustc_test_suite() {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
let root = PathBuf::from(env!("CARGO_MANIFEST_DIR"));
|
|
|
|
let target_dir = root.join("target").join("dogfood");
|
|
|
|
let cwd = root.join("clippy_workspace_tests");
|
|
|
|
|
|
|
|
// Make sure we start with a clean state
|
|
|
|
clean(&cwd, &target_dir);
|
|
|
|
|
|
|
|
// `path_dep` is a path dependency of `subcrate` that would trigger a denied lint.
|
|
|
|
// Make sure that with the `--no-deps` argument Clippy does not run on `path_dep`.
|
|
|
|
let output = Command::new(&*CLIPPY_PATH)
|
|
|
|
.current_dir(&cwd)
|
|
|
|
.env("CLIPPY_DOGFOOD", "1")
|
|
|
|
.env("CARGO_INCREMENTAL", "0")
|
|
|
|
.arg("clippy")
|
|
|
|
.args(&["-p", "subcrate"])
|
|
|
|
.arg("--")
|
|
|
|
.arg("--no-deps")
|
|
|
|
.arg("-Cdebuginfo=0") // disable debuginfo to generate less data in the target dir
|
|
|
|
.args(&["--cfg", r#"feature="primary_package_test""#])
|
|
|
|
.output()
|
|
|
|
.unwrap();
|
|
|
|
println!("status: {}", output.status);
|
|
|
|
println!("stdout: {}", String::from_utf8_lossy(&output.stdout));
|
|
|
|
println!("stderr: {}", String::from_utf8_lossy(&output.stderr));
|
|
|
|
|
|
|
|
assert!(output.status.success());
|
|
|
|
|
|
|
|
// Make sure we start with a clean state
|
|
|
|
clean(&cwd, &target_dir);
|
|
|
|
|
|
|
|
// Test that without the `--no-deps` argument, `path_dep` is linted.
|
|
|
|
let output = Command::new(&*CLIPPY_PATH)
|
|
|
|
.current_dir(&cwd)
|
|
|
|
.env("CLIPPY_DOGFOOD", "1")
|
|
|
|
.env("CARGO_INCREMENTAL", "0")
|
|
|
|
.arg("clippy")
|
|
|
|
.args(&["-p", "subcrate"])
|
|
|
|
.arg("--")
|
|
|
|
.arg("-Cdebuginfo=0") // disable debuginfo to generate less data in the target dir
|
|
|
|
.args(&["--cfg", r#"feature="primary_package_test""#])
|
|
|
|
.output()
|
|
|
|
.unwrap();
|
|
|
|
println!("status: {}", output.status);
|
|
|
|
println!("stdout: {}", String::from_utf8_lossy(&output.stdout));
|
|
|
|
println!("stderr: {}", String::from_utf8_lossy(&output.stderr));
|
|
|
|
|
|
|
|
assert!(!output.status.success());
|
|
|
|
}
|
|
|
|
|
2019-09-11 20:52:36 +02:00
|
|
|
// run clippy on remaining subprojects and fail the test if lint warnings are reported
|
2020-02-09 06:00:49 +01:00
|
|
|
if cargo::is_rustc_test_suite() {
|
2018-11-21 16:14:42 +01:00
|
|
|
return;
|
|
|
|
}
|
2020-02-01 18:00:48 +01:00
|
|
|
let root_dir = PathBuf::from(env!("CARGO_MANIFEST_DIR"));
|
2018-11-21 16:14:42 +01:00
|
|
|
|
2020-10-17 19:48:40 +02:00
|
|
|
// NOTE: `path_dep` crate is omitted on purpose here
|
2018-11-21 16:14:42 +01:00
|
|
|
for d in &[
|
|
|
|
"clippy_workspace_tests",
|
|
|
|
"clippy_workspace_tests/src",
|
|
|
|
"clippy_workspace_tests/subcrate",
|
|
|
|
"clippy_workspace_tests/subcrate/src",
|
|
|
|
"clippy_dev",
|
|
|
|
"rustc_tools_util",
|
|
|
|
] {
|
2020-02-05 16:13:55 +01:00
|
|
|
let output = Command::new(&*CLIPPY_PATH)
|
2018-11-30 19:54:47 +01:00
|
|
|
.current_dir(root_dir.join(d))
|
2018-11-24 22:24:13 +01:00
|
|
|
.env("CLIPPY_DOGFOOD", "1")
|
2019-09-06 19:35:20 +02:00
|
|
|
.env("CARGO_INCREMENTAL", "0")
|
2018-11-21 16:14:42 +01:00
|
|
|
.arg("clippy")
|
|
|
|
.arg("--")
|
|
|
|
.args(&["-D", "clippy::all"])
|
|
|
|
.args(&["-D", "clippy::pedantic"])
|
2019-09-11 20:52:36 +02:00
|
|
|
.arg("-Cdebuginfo=0") // disable debuginfo to generate less data in the target dir
|
2018-03-15 16:08:49 +01:00
|
|
|
.output()
|
|
|
|
.unwrap();
|
2017-12-15 10:02:39 +01:00
|
|
|
println!("status: {}", output.status);
|
|
|
|
println!("stdout: {}", String::from_utf8_lossy(&output.stdout));
|
|
|
|
println!("stderr: {}", String::from_utf8_lossy(&output.stderr));
|
|
|
|
|
|
|
|
assert!(output.status.success());
|
|
|
|
}
|
2020-10-17 19:48:40 +02:00
|
|
|
|
|
|
|
// NOTE: Since tests run in parallel we can't run cargo commands on the same workspace at the
|
|
|
|
// same time, so we test this immediately after the dogfood for workspaces.
|
|
|
|
test_no_deps_ignores_path_deps_in_workspaces();
|
2017-12-15 10:02:39 +01:00
|
|
|
}
|