rust/tests/ui/needless_bool.rs

75 lines
1.2 KiB
Rust
Raw Normal View History

#![feature(plugin)]
#![plugin(clippy)]
#![deny(needless_bool)]
#[allow(if_same_then_else)]
fn main() {
let x = true;
2016-07-04 01:17:31 +02:00
let y = false;
2017-02-08 14:58:07 +01:00
if x { true } else { true };
if x { false } else { false };
2016-03-14 17:13:10 +01:00
if x { true } else { false };
2017-02-08 14:58:07 +01:00
2016-03-14 17:13:10 +01:00
if x { false } else { true };
2017-02-08 14:58:07 +01:00
2016-07-04 01:17:31 +02:00
if x && y { false } else { true };
2017-02-08 14:58:07 +01:00
if x { x } else { false }; // would also be questionable, but we don't catch this yet
bool_ret(x);
bool_ret2(x);
bool_ret3(x);
2016-07-04 01:17:31 +02:00
bool_ret5(x, x);
bool_ret4(x);
2016-07-04 01:17:31 +02:00
bool_ret6(x, x);
}
#[allow(if_same_then_else, needless_return)]
fn bool_ret(x: bool) -> bool {
if x { return true } else { return true };
2017-02-08 14:58:07 +01:00
}
#[allow(if_same_then_else, needless_return)]
fn bool_ret2(x: bool) -> bool {
if x { return false } else { return false };
2017-02-08 14:58:07 +01:00
}
#[allow(needless_return)]
fn bool_ret3(x: bool) -> bool {
2016-03-14 17:13:10 +01:00
if x { return true } else { return false };
2017-02-08 14:58:07 +01:00
2016-07-04 01:17:31 +02:00
}
#[allow(needless_return)]
fn bool_ret5(x: bool, y: bool) -> bool {
if x && y { return true } else { return false };
2017-02-08 14:58:07 +01:00
}
#[allow(needless_return)]
fn bool_ret4(x: bool) -> bool {
2016-03-14 17:13:10 +01:00
if x { return false } else { return true };
2017-02-08 14:58:07 +01:00
2016-07-04 01:17:31 +02:00
}
#[allow(needless_return)]
fn bool_ret6(x: bool, y: bool) -> bool {
if x && y { return false } else { return true };
2017-02-08 14:58:07 +01:00
}