2017-02-07 21:05:30 +01:00
error: defining a method called `add` on this type; consider implementing the `std::ops::Add` trait or choosing a less ambiguous name
2017-05-17 17:51:35 +02:00
--> methods.rs:18:5
2017-02-07 21:05:30 +01:00
|
2017-02-08 14:58:07 +01:00
18 | fn add(self, other: T) -> T { self }
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
2017-05-17 14:19:44 +02:00
= note: `-D should-implement-trait` implied by `-D warnings`
2017-02-07 21:05:30 +01:00
error: defining a method called `drop` on this type; consider implementing the `std::ops::Drop` trait or choosing a less ambiguous name
2017-05-17 17:51:35 +02:00
--> methods.rs:19:5
2017-02-07 21:05:30 +01:00
|
2017-02-08 14:58:07 +01:00
19 | fn drop(&mut self) { }
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^
error: methods called `into_*` usually take self by value; consider choosing a less ambiguous name
2017-05-17 17:51:35 +02:00
--> methods.rs:26:17
2017-02-07 21:05:30 +01:00
|
2017-02-08 14:58:07 +01:00
26 | fn into_u16(&self) -> u16 { 0 }
2017-02-07 21:05:30 +01:00
| ^^^^^
|
2017-05-17 14:19:44 +02:00
= note: `-D wrong-self-convention` implied by `-D warnings`
2017-02-07 21:05:30 +01:00
error: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name
2017-05-17 17:51:35 +02:00
--> methods.rs:28:21
2017-02-07 21:05:30 +01:00
|
2017-02-08 14:58:07 +01:00
28 | fn to_something(self) -> u32 { 0 }
2017-02-07 21:05:30 +01:00
| ^^^^
error: methods called `new` usually take no self; consider choosing a less ambiguous name
2017-05-17 17:51:35 +02:00
--> methods.rs:30:12
2017-02-07 21:05:30 +01:00
|
30 | fn new(self) {}
| ^^^^
error: methods called `new` usually return `Self`
2017-05-17 17:51:35 +02:00
--> methods.rs:30:5
2017-02-07 21:05:30 +01:00
|
30 | fn new(self) {}
| ^^^^^^^^^^^^^^^
|
2017-05-17 14:19:44 +02:00
= note: `-D new-ret-no-self` implied by `-D warnings`
2017-02-07 21:05:30 +01:00
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
2017-05-17 17:51:35 +02:00
--> methods.rs:97:13
2017-05-11 15:37:35 +02:00
|
97 | let _ = opt.map(|x| x + 1)
| _____________^
98 | |
99 | | .unwrap_or(0); // should lint even though this call is on a separate line
| |____________________________^
|
2017-05-17 14:19:44 +02:00
= note: `-D option-map-unwrap-or` implied by `-D warnings`
2017-05-11 15:37:35 +02:00
= note: replace `map(|x| x + 1).unwrap_or(0)` with `map_or(0, |x| x + 1)`
2017-02-07 21:05:30 +01:00
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
2017-05-17 17:51:35 +02:00
--> methods.rs:101:13
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
101 | let _ = opt.map(|x| {
2017-04-23 15:25:22 +02:00
| _____________^
2017-05-11 15:37:35 +02:00
102 | | x + 1
103 | | }
104 | | ).unwrap_or(0);
2017-04-23 15:25:22 +02:00
| |____________________________^
2017-02-07 21:05:30 +01:00
error: called `map(f).unwrap_or(a)` on an Option value. This can be done more directly by calling `map_or(a, f)` instead
2017-05-17 17:51:35 +02:00
--> methods.rs:105:13
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
105 | let _ = opt.map(|x| x + 1)
2017-04-23 15:25:22 +02:00
| _____________^
2017-05-11 15:37:35 +02:00
106 | | .unwrap_or({
107 | | 0
108 | | });
2017-04-23 15:25:22 +02:00
| |__________________^
2017-02-07 21:05:30 +01:00
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
2017-05-17 17:51:35 +02:00
--> methods.rs:114:13
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
114 | let _ = opt.map(|x| x + 1)
2017-04-23 15:25:22 +02:00
| _____________^
2017-05-11 15:37:35 +02:00
115 | |
116 | | .unwrap_or_else(|| 0); // should lint even though this call is on a separate line
2017-04-23 15:25:22 +02:00
| |____________________________________^
2017-02-07 21:05:30 +01:00
|
2017-05-17 14:19:44 +02:00
= note: `-D option-map-unwrap-or-else` implied by `-D warnings`
2017-04-01 15:49:55 +02:00
= note: replace `map(|x| x + 1).unwrap_or_else(|| 0)` with `map_or_else(|| 0, |x| x + 1)`
2017-02-07 21:05:30 +01:00
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
2017-05-17 17:51:35 +02:00
--> methods.rs:118:13
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
118 | let _ = opt.map(|x| {
2017-04-23 15:25:22 +02:00
| _____________^
2017-05-11 15:37:35 +02:00
119 | | x + 1
120 | | }
121 | | ).unwrap_or_else(|| 0);
2017-04-23 15:25:22 +02:00
| |____________________________________^
2017-02-07 21:05:30 +01:00
error: called `map(f).unwrap_or_else(g)` on an Option value. This can be done more directly by calling `map_or_else(g, f)` instead
2017-05-17 17:51:35 +02:00
--> methods.rs:122:13
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
122 | let _ = opt.map(|x| x + 1)
2017-04-23 15:25:22 +02:00
| _____________^
2017-05-11 15:37:35 +02:00
123 | | .unwrap_or_else(||
124 | | 0
125 | | );
2017-04-23 15:25:22 +02:00
| |_________________^
2017-02-07 21:05:30 +01:00
error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
2017-05-17 17:51:35 +02:00
--> methods.rs:194:13
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
194 | let _ = v.iter().filter(|&x| *x < 0).next();
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
2017-05-17 14:19:44 +02:00
= note: `-D filter-next` implied by `-D warnings`
2017-02-07 21:05:30 +01:00
= note: replace `filter(|&x| *x < 0).next()` with `find(|&x| *x < 0)`
error: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
2017-05-17 17:51:35 +02:00
--> methods.rs:197:13
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
197 | let _ = v.iter().filter(|&x| {
2017-04-23 15:25:22 +02:00
| _____________^
2017-05-11 15:37:35 +02:00
198 | | *x < 0
199 | | }
200 | | ).next();
2017-04-23 15:25:22 +02:00
| |___________________________^
2017-02-07 21:05:30 +01:00
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
2017-05-17 17:51:35 +02:00
--> methods.rs:212:13
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
212 | let _ = v.iter().find(|&x| *x < 0).is_some();
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
2017-05-17 14:19:44 +02:00
= note: `-D search-is-some` implied by `-D warnings`
2017-02-07 21:05:30 +01:00
= note: replace `find(|&x| *x < 0).is_some()` with `any(|&x| *x < 0)`
error: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
2017-05-17 17:51:35 +02:00
--> methods.rs:215:13
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
215 | let _ = v.iter().find(|&x| {
2017-04-23 15:25:22 +02:00
| _____________^
2017-05-11 15:37:35 +02:00
216 | | *x < 0
217 | | }
218 | | ).is_some();
2017-04-23 15:25:22 +02:00
| |______________________________^
2017-02-07 21:05:30 +01:00
error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
2017-05-17 17:51:35 +02:00
--> methods.rs:221:13
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
221 | let _ = v.iter().position(|&x| x < 0).is_some();
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: replace `position(|&x| x < 0).is_some()` with `any(|&x| x < 0)`
error: called `is_some()` after searching an `Iterator` with position. This is more succinctly expressed by calling `any()`.
2017-05-17 17:51:35 +02:00
--> methods.rs:224:13
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
224 | let _ = v.iter().position(|&x| {
2017-04-23 15:25:22 +02:00
| _____________^
2017-05-11 15:37:35 +02:00
225 | | x < 0
226 | | }
227 | | ).is_some();
2017-04-23 15:25:22 +02:00
| |______________________________^
2017-02-07 21:05:30 +01:00
error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.
2017-05-17 17:51:35 +02:00
--> methods.rs:230:13
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
230 | let _ = v.iter().rposition(|&x| x < 0).is_some();
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: replace `rposition(|&x| x < 0).is_some()` with `any(|&x| x < 0)`
error: called `is_some()` after searching an `Iterator` with rposition. This is more succinctly expressed by calling `any()`.
2017-05-17 17:51:35 +02:00
--> methods.rs:233:13
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
233 | let _ = v.iter().rposition(|&x| {
2017-04-23 15:25:22 +02:00
| _____________^
2017-05-11 15:37:35 +02:00
234 | | x < 0
235 | | }
236 | | ).is_some();
2017-04-23 15:25:22 +02:00
| |______________________________^
2017-02-07 21:05:30 +01:00
error: use of `unwrap_or` followed by a function call
2017-05-17 17:51:35 +02:00
--> methods.rs:268:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
268 | with_constructor.unwrap_or(make());
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this `with_constructor.unwrap_or_else(make)`
2017-02-07 21:05:30 +01:00
|
2017-05-17 14:19:44 +02:00
= note: `-D or-fun-call` implied by `-D warnings`
2017-02-07 21:05:30 +01:00
error: use of `unwrap_or` followed by a call to `new`
2017-05-17 17:51:35 +02:00
--> methods.rs:271:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
271 | with_new.unwrap_or(Vec::new());
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this `with_new.unwrap_or_default()`
2017-02-07 21:05:30 +01:00
error: use of `unwrap_or` followed by a function call
2017-05-17 17:51:35 +02:00
--> methods.rs:274:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
274 | with_const_args.unwrap_or(Vec::with_capacity(12));
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this `with_const_args.unwrap_or_else(|| Vec::with_capacity(12))`
2017-02-07 21:05:30 +01:00
error: use of `unwrap_or` followed by a function call
2017-05-17 17:51:35 +02:00
--> methods.rs:277:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
277 | with_err.unwrap_or(make());
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this `with_err.unwrap_or_else(|_| make())`
2017-02-07 21:05:30 +01:00
error: use of `unwrap_or` followed by a function call
2017-05-17 17:51:35 +02:00
--> methods.rs:280:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
280 | with_err_args.unwrap_or(Vec::with_capacity(12));
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this `with_err_args.unwrap_or_else(|_| Vec::with_capacity(12))`
2017-02-07 21:05:30 +01:00
error: use of `unwrap_or` followed by a call to `default`
2017-05-17 17:51:35 +02:00
--> methods.rs:283:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
283 | with_default_trait.unwrap_or(Default::default());
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this `with_default_trait.unwrap_or_default()`
2017-02-07 21:05:30 +01:00
error: use of `unwrap_or` followed by a call to `default`
2017-05-17 17:51:35 +02:00
--> methods.rs:286:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
286 | with_default_type.unwrap_or(u64::default());
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this `with_default_type.unwrap_or_default()`
2017-02-07 21:05:30 +01:00
error: use of `unwrap_or` followed by a function call
2017-05-17 17:51:35 +02:00
--> methods.rs:289:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
289 | with_vec.unwrap_or(vec![]);
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this `with_vec.unwrap_or_else(|| < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ))`
2017-02-07 21:05:30 +01:00
error: use of `unwrap_or` followed by a function call
2017-05-17 17:51:35 +02:00
--> methods.rs:294:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
294 | without_default.unwrap_or(Foo::new());
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this `without_default.unwrap_or_else(Foo::new)`
2017-02-07 21:05:30 +01:00
error: use of `or_insert` followed by a function call
2017-05-17 17:51:35 +02:00
--> methods.rs:297:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
297 | map.entry(42).or_insert(String::new());
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this `map.entry(42).or_insert_with(String::new)`
2017-02-07 21:05:30 +01:00
error: use of `or_insert` followed by a function call
2017-05-17 17:51:35 +02:00
--> methods.rs:300:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
300 | btree.entry(42).or_insert(String::new());
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this `btree.entry(42).or_insert_with(String::new)`
2017-02-07 21:05:30 +01:00
error: use of `unwrap_or` followed by a function call
2017-05-17 17:51:35 +02:00
--> methods.rs:303:13
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
303 | let _ = stringy.unwrap_or("".to_owned());
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this `stringy.unwrap_or_else(|| "".to_owned())`
2017-02-07 21:05:30 +01:00
error: called `.iter().nth()` on a Vec. Calling `.get()` is both faster and more readable
2017-05-17 17:51:35 +02:00
--> methods.rs:314:23
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
314 | let bad_vec = some_vec.iter().nth(3);
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^
|
2017-05-17 14:19:44 +02:00
= note: `-D iter-nth` implied by `-D warnings`
2017-02-07 21:05:30 +01:00
error: called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable
2017-05-17 17:51:35 +02:00
--> methods.rs:315:26
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
315 | let bad_slice = &some_vec[..].iter().nth(3);
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `.iter().nth()` on a slice. Calling `.get()` is both faster and more readable
2017-05-17 17:51:35 +02:00
--> methods.rs:316:31
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
316 | let bad_boxed_slice = boxed_slice.iter().nth(3);
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `.iter().nth()` on a VecDeque. Calling `.get()` is both faster and more readable
2017-05-17 17:51:35 +02:00
--> methods.rs:317:29
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
317 | let bad_vec_deque = some_vec_deque.iter().nth(3);
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `.iter_mut().nth()` on a Vec. Calling `.get_mut()` is both faster and more readable
2017-05-17 17:51:35 +02:00
--> methods.rs:322:23
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
322 | let bad_vec = some_vec.iter_mut().nth(3);
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `.iter_mut().nth()` on a slice. Calling `.get_mut()` is both faster and more readable
2017-05-17 17:51:35 +02:00
--> methods.rs:325:26
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
325 | let bad_slice = &some_vec[..].iter_mut().nth(3);
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `.iter_mut().nth()` on a VecDeque. Calling `.get_mut()` is both faster and more readable
2017-05-17 17:51:35 +02:00
--> methods.rs:328:29
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
328 | let bad_vec_deque = some_vec_deque.iter_mut().nth(3);
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
2017-05-17 17:51:35 +02:00
--> methods.rs:340:13
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
340 | let _ = some_vec.iter().skip(42).next();
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
2017-05-17 14:19:44 +02:00
= note: `-D iter-skip-next` implied by `-D warnings`
2017-02-07 21:05:30 +01:00
error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
2017-05-17 17:51:35 +02:00
--> methods.rs:341:13
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
341 | let _ = some_vec.iter().cycle().skip(42).next();
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
2017-05-17 17:51:35 +02:00
--> methods.rs:342:13
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
342 | let _ = (1..10).skip(10).next();
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^
error: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)`
2017-05-17 17:51:35 +02:00
--> methods.rs:343:14
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
343 | let _ = &some_vec[..].iter().skip(3).next();
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise
2017-05-17 17:51:35 +02:00
--> methods.rs:369:17
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
369 | let _ = boxed_slice.get(1).unwrap();
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this `&boxed_slice[1]`
2017-02-07 21:05:30 +01:00
|
2017-05-17 14:19:44 +02:00
= note: `-D get-unwrap` implied by `-D warnings`
2017-02-07 21:05:30 +01:00
error: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise
2017-05-17 17:51:35 +02:00
--> methods.rs:370:17
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
370 | let _ = some_slice.get(0).unwrap();
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this `&some_slice[0]`
2017-02-07 21:05:30 +01:00
error: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
2017-05-17 17:51:35 +02:00
--> methods.rs:371:17
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
371 | let _ = some_vec.get(0).unwrap();
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this `&some_vec[0]`
2017-02-07 21:05:30 +01:00
error: called `.get().unwrap()` on a VecDeque. Using `[]` is more clear and more concise
2017-05-17 17:51:35 +02:00
--> methods.rs:372:17
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
372 | let _ = some_vecdeque.get(0).unwrap();
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this `&some_vecdeque[0]`
2017-02-07 21:05:30 +01:00
error: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
2017-05-17 17:51:35 +02:00
--> methods.rs:373:17
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
373 | let _ = some_hashmap.get(&1).unwrap();
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this `&some_hashmap[&1]`
2017-02-07 21:05:30 +01:00
error: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise
2017-05-17 17:51:35 +02:00
--> methods.rs:374:17
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
374 | let _ = some_btreemap.get(&1).unwrap();
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this `&some_btreemap[&1]`
2017-02-07 21:05:30 +01:00
error: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise
2017-05-17 17:51:35 +02:00
--> methods.rs:379:10
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
379 | *boxed_slice.get_mut(0).unwrap() = 1;
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this `&mut boxed_slice[0]`
2017-02-07 21:05:30 +01:00
error: called `.get_mut().unwrap()` on a slice. Using `[]` is more clear and more concise
2017-05-17 17:51:35 +02:00
--> methods.rs:380:10
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
380 | *some_slice.get_mut(0).unwrap() = 1;
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this `&mut some_slice[0]`
2017-02-07 21:05:30 +01:00
error: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise
2017-05-17 17:51:35 +02:00
--> methods.rs:381:10
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
381 | *some_vec.get_mut(0).unwrap() = 1;
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this `&mut some_vec[0]`
2017-02-07 21:05:30 +01:00
error: called `.get_mut().unwrap()` on a VecDeque. Using `[]` is more clear and more concise
2017-05-17 17:51:35 +02:00
--> methods.rs:382:10
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
382 | *some_vecdeque.get_mut(0).unwrap() = 1;
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this `&mut some_vecdeque[0]`
2017-02-07 21:05:30 +01:00
error: used unwrap() on an Option value. If you don't want to handle the None case gracefully, consider using expect() to provide a better panic message
2017-05-17 17:51:35 +02:00
--> methods.rs:396:13
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
396 | let _ = opt.unwrap();
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^
|
2017-05-17 14:19:44 +02:00
= note: `-D option-unwrap-used` implied by `-D warnings`
2017-02-07 21:05:30 +01:00
error: used unwrap() on a Result value. If you don't want to handle the Err case gracefully, consider using expect() to provide a better panic message
2017-05-17 17:51:35 +02:00
--> methods.rs:399:13
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
399 | let _ = res.unwrap();
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^
|
2017-05-17 14:19:44 +02:00
= note: `-D result-unwrap-used` implied by `-D warnings`
2017-02-07 21:05:30 +01:00
error: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
2017-05-17 17:51:35 +02:00
--> methods.rs:401:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
401 | res.ok().expect("disaster!");
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
2017-05-17 14:19:44 +02:00
= note: `-D ok-expect` implied by `-D warnings`
2017-02-07 21:05:30 +01:00
error: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
2017-05-17 17:51:35 +02:00
--> methods.rs:407:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
407 | res3.ok().expect("whoof");
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^
error: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
2017-05-17 17:51:35 +02:00
--> methods.rs:409:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
409 | res4.ok().expect("argh");
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^^
error: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
2017-05-17 17:51:35 +02:00
--> methods.rs:411:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
411 | res5.ok().expect("oops");
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^^
error: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result`
2017-05-17 17:51:35 +02:00
--> methods.rs:413:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
413 | res6.ok().expect("meh");
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^
error: you should use the `starts_with` method
2017-05-17 17:51:35 +02:00
--> methods.rs:425:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
425 | "".chars().next() == Some(' ');
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this `"".starts_with(' ')`
2017-02-07 21:05:30 +01:00
|
2017-05-17 14:19:44 +02:00
= note: `-D chars-next-cmp` implied by `-D warnings`
2017-02-07 21:05:30 +01:00
error: you should use the `starts_with` method
2017-05-17 17:51:35 +02:00
--> methods.rs:426:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
426 | Some(' ') != "".chars().next();
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this `!"".starts_with(' ')`
2017-02-07 21:05:30 +01:00
error: calling `.extend(_.chars())`
2017-05-17 17:51:35 +02:00
--> methods.rs:435:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
435 | s.extend(abc.chars());
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^ help: try this `s.push_str(abc)`
2017-02-07 21:05:30 +01:00
|
2017-05-17 14:19:44 +02:00
= note: `-D string-extend-chars` implied by `-D warnings`
2017-02-07 21:05:30 +01:00
error: calling `.extend(_.chars())`
2017-05-17 17:51:35 +02:00
--> methods.rs:438:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
438 | s.extend("abc".chars());
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^^^ help: try this `s.push_str("abc")`
2017-02-07 21:05:30 +01:00
error: calling `.extend(_.chars())`
2017-05-17 17:51:35 +02:00
--> methods.rs:441:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
441 | s.extend(def.chars());
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^^^^^^^ help: try this `s.push_str(&def)`
2017-02-07 21:05:30 +01:00
error: using `clone` on a `Copy` type
2017-05-17 17:51:35 +02:00
--> methods.rs:452:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
452 | 42.clone();
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^ help: try removing the `clone` call `42`
2017-02-07 21:05:30 +01:00
|
2017-05-17 14:19:44 +02:00
= note: `-D clone-on-copy` implied by `-D warnings`
2017-02-07 21:05:30 +01:00
error: using `clone` on a `Copy` type
2017-05-17 17:51:35 +02:00
--> methods.rs:456:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
456 | (&42).clone();
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^ help: try dereferencing it `*(&42)`
2017-02-07 21:05:30 +01:00
error: using `clone` on a `Copy` type
2017-05-17 17:51:35 +02:00
--> methods.rs:460:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
460 | t.clone();
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^ help: try removing the `clone` call `t`
2017-02-07 21:05:30 +01:00
error: using `clone` on a `Copy` type
2017-05-17 17:51:35 +02:00
--> methods.rs:462:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
462 | Some(t).clone();
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^^^^^^^ help: try removing the `clone` call `Some(t)`
2017-02-07 21:05:30 +01:00
error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
2017-05-17 17:51:35 +02:00
--> methods.rs:468:22
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
468 | let z: &Vec<_> = y.clone();
2017-05-03 12:51:47 +02:00
| ^^^^^^^^^ help: try dereferencing it `(*y).clone()`
2017-02-07 21:05:30 +01:00
|
2017-05-17 14:19:44 +02:00
= note: `-D clone-double-ref` implied by `-D warnings`
2017-02-07 21:05:30 +01:00
error: single-character string constant used as pattern
2017-05-17 17:51:35 +02:00
--> methods.rs:475:13
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
475 | x.split("x");
2017-05-03 12:51:47 +02:00
| --------^^^- help: try using a char instead: `x.split('x')`
2017-02-07 21:05:30 +01:00
|
2017-05-17 14:19:44 +02:00
= note: `-D single-char-pattern` implied by `-D warnings`
2017-02-07 21:05:30 +01:00
error: single-character string constant used as pattern
2017-05-17 17:51:35 +02:00
--> methods.rs:492:16
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
492 | x.contains("x");
2017-05-03 12:51:47 +02:00
| -----------^^^- help: try using a char instead: `x.contains('x')`
2017-02-07 21:05:30 +01:00
error: single-character string constant used as pattern
2017-05-17 17:51:35 +02:00
--> methods.rs:493:19
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
493 | x.starts_with("x");
2017-05-03 12:51:47 +02:00
| --------------^^^- help: try using a char instead: `x.starts_with('x')`
2017-02-07 21:05:30 +01:00
error: single-character string constant used as pattern
2017-05-17 17:51:35 +02:00
--> methods.rs:494:17
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
494 | x.ends_with("x");
2017-05-03 12:51:47 +02:00
| ------------^^^- help: try using a char instead: `x.ends_with('x')`
2017-02-07 21:05:30 +01:00
error: single-character string constant used as pattern
2017-05-17 17:51:35 +02:00
--> methods.rs:495:12
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
495 | x.find("x");
2017-05-03 12:51:47 +02:00
| -------^^^- help: try using a char instead: `x.find('x')`
2017-02-07 21:05:30 +01:00
error: single-character string constant used as pattern
2017-05-17 17:51:35 +02:00
--> methods.rs:496:13
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
496 | x.rfind("x");
2017-05-03 12:51:47 +02:00
| --------^^^- help: try using a char instead: `x.rfind('x')`
2017-02-07 21:05:30 +01:00
error: single-character string constant used as pattern
2017-05-17 17:51:35 +02:00
--> methods.rs:497:14
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
497 | x.rsplit("x");
2017-05-03 12:51:47 +02:00
| ---------^^^- help: try using a char instead: `x.rsplit('x')`
2017-02-07 21:05:30 +01:00
error: single-character string constant used as pattern
2017-05-17 17:51:35 +02:00
--> methods.rs:498:24
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
498 | x.split_terminator("x");
2017-05-03 12:51:47 +02:00
| -------------------^^^- help: try using a char instead: `x.split_terminator('x')`
2017-02-07 21:05:30 +01:00
error: single-character string constant used as pattern
2017-05-17 17:51:35 +02:00
--> methods.rs:499:25
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
499 | x.rsplit_terminator("x");
2017-05-03 12:51:47 +02:00
| --------------------^^^- help: try using a char instead: `x.rsplit_terminator('x')`
2017-02-07 21:05:30 +01:00
error: single-character string constant used as pattern
2017-05-17 17:51:35 +02:00
--> methods.rs:500:17
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
500 | x.splitn(0, "x");
2017-05-03 12:51:47 +02:00
| ------------^^^- help: try using a char instead: `x.splitn(0, 'x')`
2017-02-07 21:05:30 +01:00
error: single-character string constant used as pattern
2017-05-17 17:51:35 +02:00
--> methods.rs:501:18
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
501 | x.rsplitn(0, "x");
2017-05-03 12:51:47 +02:00
| -------------^^^- help: try using a char instead: `x.rsplitn(0, 'x')`
2017-02-07 21:05:30 +01:00
error: single-character string constant used as pattern
2017-05-17 17:51:35 +02:00
--> methods.rs:502:15
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
502 | x.matches("x");
2017-05-03 12:51:47 +02:00
| ----------^^^- help: try using a char instead: `x.matches('x')`
2017-02-07 21:05:30 +01:00
error: single-character string constant used as pattern
2017-05-17 17:51:35 +02:00
--> methods.rs:503:16
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
503 | x.rmatches("x");
2017-05-03 12:51:47 +02:00
| -----------^^^- help: try using a char instead: `x.rmatches('x')`
2017-02-07 21:05:30 +01:00
error: single-character string constant used as pattern
2017-05-17 17:51:35 +02:00
--> methods.rs:504:21
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
504 | x.match_indices("x");
2017-05-03 12:51:47 +02:00
| ----------------^^^- help: try using a char instead: `x.match_indices('x')`
2017-02-07 21:05:30 +01:00
error: single-character string constant used as pattern
2017-05-17 17:51:35 +02:00
--> methods.rs:505:22
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
505 | x.rmatch_indices("x");
2017-05-03 12:51:47 +02:00
| -----------------^^^- help: try using a char instead: `x.rmatch_indices('x')`
2017-02-07 21:05:30 +01:00
error: single-character string constant used as pattern
2017-05-17 17:51:35 +02:00
--> methods.rs:506:25
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
506 | x.trim_left_matches("x");
2017-05-03 12:51:47 +02:00
| --------------------^^^- help: try using a char instead: `x.trim_left_matches('x')`
2017-02-07 21:05:30 +01:00
error: single-character string constant used as pattern
2017-05-17 17:51:35 +02:00
--> methods.rs:507:26
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
507 | x.trim_right_matches("x");
2017-05-03 12:51:47 +02:00
| ---------------------^^^- help: try using a char instead: `x.trim_right_matches('x')`
2017-02-07 21:05:30 +01:00
error: you are getting the inner pointer of a temporary `CString`
2017-05-17 17:51:35 +02:00
--> methods.rs:517:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
517 | CString::new("foo").unwrap().as_ptr();
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
2017-05-17 14:19:44 +02:00
= note: `-D temporary-cstring-as-ptr` implied by `-D warnings`
2017-02-07 21:05:30 +01:00
= note: that pointer will be invalid outside this expression
help: assign the `CString` to a variable to extend its lifetime
2017-05-17 17:51:35 +02:00
--> methods.rs:517:5
2017-02-07 21:05:30 +01:00
|
2017-05-11 15:37:35 +02:00
517 | CString::new("foo").unwrap().as_ptr();
2017-02-07 21:05:30 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2017-02-13 11:57:14 +01:00
error: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable
2017-05-17 17:51:35 +02:00
--> methods.rs:522:27
2017-02-12 10:03:09 +01:00
|
2017-05-11 15:37:35 +02:00
522 | let v2 : Vec<isize> = v.iter().cloned().collect();
2017-02-12 10:03:09 +01:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
2017-05-17 14:19:44 +02:00
= note: `-D iter-cloned-collect` implied by `-D warnings`
2017-02-12 10:03:09 +01:00
2017-07-03 06:37:30 +02:00
error: aborting due to 89 previous errors
2017-02-07 21:05:30 +01:00
2017-05-17 14:19:44 +02:00
To learn more, run the command again with --verbose.