2018-07-28 17:34:52 +02:00
|
|
|
#![feature(tool_lints)]
|
|
|
|
|
|
|
|
#![warn(clippy::use_self)]
|
2017-07-28 13:28:07 +02:00
|
|
|
#![allow(dead_code)]
|
2018-07-28 17:34:52 +02:00
|
|
|
#![allow(clippy::should_implement_trait)]
|
2017-07-28 13:28:07 +02:00
|
|
|
|
|
|
|
fn main() {}
|
|
|
|
|
|
|
|
mod use_self {
|
|
|
|
struct Foo {}
|
|
|
|
|
|
|
|
impl Foo {
|
|
|
|
fn new() -> Foo {
|
|
|
|
Foo {}
|
|
|
|
}
|
|
|
|
fn test() -> Foo {
|
|
|
|
Foo::new()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl Default for Foo {
|
|
|
|
fn default() -> Foo {
|
|
|
|
Foo::new()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
mod better {
|
|
|
|
struct Foo {}
|
|
|
|
|
|
|
|
impl Foo {
|
|
|
|
fn new() -> Self {
|
|
|
|
Self {}
|
|
|
|
}
|
|
|
|
fn test() -> Self {
|
|
|
|
Self::new()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
impl Default for Foo {
|
|
|
|
fn default() -> Self {
|
|
|
|
Self::new()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2017-08-22 00:18:37 +02:00
|
|
|
|
|
|
|
//todo the lint does not handle lifetimed struct
|
|
|
|
//the following module should trigger the lint on the third method only
|
|
|
|
mod lifetimes {
|
|
|
|
struct Foo<'a>{foo_str: &'a str}
|
|
|
|
|
|
|
|
impl<'a> Foo<'a> {
|
|
|
|
// Cannot use `Self` as return type, because the function is actually `fn foo<'b>(s: &'b str) -> Foo<'b>`
|
|
|
|
fn foo(s: &str) -> Foo {
|
|
|
|
Foo { foo_str: s }
|
|
|
|
}
|
|
|
|
// cannot replace with `Self`, because that's `Foo<'a>`
|
|
|
|
fn bar() -> Foo<'static> {
|
|
|
|
Foo { foo_str: "foo"}
|
|
|
|
}
|
|
|
|
|
|
|
|
// `Self` is applicable here
|
|
|
|
fn clone(&self) -> Foo<'a> {
|
|
|
|
Foo {foo_str: self.foo_str}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2018-07-14 12:18:50 +02:00
|
|
|
|
2018-07-28 17:34:52 +02:00
|
|
|
#[allow(clippy::boxed_local)]
|
2018-07-14 12:18:50 +02:00
|
|
|
mod traits {
|
|
|
|
|
2018-07-17 08:20:49 +02:00
|
|
|
use std::ops::Mul;
|
2018-07-14 12:18:50 +02:00
|
|
|
|
|
|
|
trait SelfTrait {
|
|
|
|
fn refs(p1: &Self) -> &Self;
|
|
|
|
fn ref_refs<'a>(p1: &'a &'a Self) -> &'a &'a Self;
|
|
|
|
fn mut_refs(p1: &mut Self) -> &mut Self;
|
|
|
|
fn nested(p1: Box<Self>, p2: (&u8, &Self));
|
|
|
|
fn vals(r: Self) -> Self;
|
|
|
|
}
|
|
|
|
|
|
|
|
#[derive(Default)]
|
|
|
|
struct Bad;
|
|
|
|
|
|
|
|
impl SelfTrait for Bad {
|
|
|
|
fn refs(p1: &Bad) -> &Bad {
|
|
|
|
p1
|
|
|
|
}
|
|
|
|
|
|
|
|
fn ref_refs<'a>(p1: &'a &'a Bad) -> &'a &'a Bad {
|
|
|
|
p1
|
|
|
|
}
|
|
|
|
|
|
|
|
fn mut_refs(p1: &mut Bad) -> &mut Bad {
|
|
|
|
p1
|
|
|
|
}
|
|
|
|
|
|
|
|
fn nested(_p1: Box<Bad>, _p2: (&u8, &Bad)) {
|
|
|
|
}
|
|
|
|
|
|
|
|
fn vals(_: Bad) -> Bad {
|
|
|
|
Bad::default()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-07-17 08:20:49 +02:00
|
|
|
impl Mul for Bad {
|
|
|
|
type Output = Bad;
|
|
|
|
|
|
|
|
fn mul(self, rhs: Bad) -> Bad {
|
|
|
|
rhs
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-07-14 12:18:50 +02:00
|
|
|
#[derive(Default)]
|
|
|
|
struct Good;
|
|
|
|
|
|
|
|
impl SelfTrait for Good {
|
|
|
|
fn refs(p1: &Self) -> &Self {
|
|
|
|
p1
|
|
|
|
}
|
|
|
|
|
|
|
|
fn ref_refs<'a>(p1: &'a &'a Self) -> &'a &'a Self {
|
|
|
|
p1
|
|
|
|
}
|
|
|
|
|
|
|
|
fn mut_refs(p1: &mut Self) -> &mut Self {
|
|
|
|
p1
|
|
|
|
}
|
|
|
|
|
|
|
|
fn nested(_p1: Box<Self>, _p2: (&u8, &Self)) {
|
|
|
|
}
|
|
|
|
|
|
|
|
fn vals(_: Self) -> Self {
|
|
|
|
Self::default()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-07-17 08:20:49 +02:00
|
|
|
impl Mul for Good {
|
|
|
|
type Output = Self;
|
|
|
|
|
|
|
|
fn mul(self, rhs: Self) -> Self {
|
|
|
|
rhs
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-07-14 12:18:50 +02:00
|
|
|
trait NameTrait {
|
|
|
|
fn refs(p1: &u8) -> &u8;
|
|
|
|
fn ref_refs<'a>(p1: &'a &'a u8) -> &'a &'a u8;
|
|
|
|
fn mut_refs(p1: &mut u8) -> &mut u8;
|
|
|
|
fn nested(p1: Box<u8>, p2: (&u8, &u8));
|
|
|
|
fn vals(p1: u8) -> u8;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Using `Self` instead of the type name is OK
|
|
|
|
impl NameTrait for u8 {
|
|
|
|
fn refs(p1: &Self) -> &Self {
|
|
|
|
p1
|
|
|
|
}
|
|
|
|
|
|
|
|
fn ref_refs<'a>(p1: &'a &'a Self) -> &'a &'a Self {
|
|
|
|
p1
|
|
|
|
}
|
|
|
|
|
|
|
|
fn mut_refs(p1: &mut Self) -> &mut Self {
|
|
|
|
p1
|
|
|
|
}
|
|
|
|
|
|
|
|
fn nested(_p1: Box<Self>, _p2: (&Self, &Self)) {
|
|
|
|
}
|
|
|
|
|
|
|
|
fn vals(_: Self) -> Self {
|
|
|
|
Self::default()
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Check that self arg isn't linted
|
|
|
|
impl Clone for Good {
|
|
|
|
fn clone(&self) -> Self {
|
|
|
|
// Note: Not linted and it wouldn't be valid
|
2018-07-17 08:20:49 +02:00
|
|
|
// because "can't use `Self` as a constructor`"
|
2018-07-14 12:18:50 +02:00
|
|
|
Good
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
mod issue2894 {
|
|
|
|
trait IntoBytes {
|
|
|
|
fn into_bytes(&self) -> Vec<u8>;
|
|
|
|
}
|
|
|
|
|
|
|
|
// This should not be linted
|
|
|
|
impl IntoBytes for u8 {
|
|
|
|
fn into_bytes(&self) -> Vec<u8> {
|
|
|
|
vec![*self]
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|