2017-09-18 12:47:33 +02:00
|
|
|
|
|
|
|
|
2015-11-20 06:22:52 +01:00
|
|
|
|
2017-05-17 14:19:44 +02:00
|
|
|
#![warn(block_in_if_condition_expr)]
|
|
|
|
#![warn(block_in_if_condition_stmt)]
|
2016-01-31 23:25:10 +01:00
|
|
|
#![allow(unused, let_and_return)]
|
2016-03-23 14:50:47 +01:00
|
|
|
#![warn(nonminimal_bool)]
|
2015-11-20 06:22:52 +01:00
|
|
|
|
2016-01-02 17:11:48 +01:00
|
|
|
|
|
|
|
macro_rules! blocky {
|
|
|
|
() => {{true}}
|
|
|
|
}
|
|
|
|
|
2016-01-31 23:25:10 +01:00
|
|
|
macro_rules! blocky_too {
|
|
|
|
() => {{
|
|
|
|
let r = true;
|
|
|
|
r
|
|
|
|
}}
|
|
|
|
}
|
|
|
|
|
2016-01-02 17:11:48 +01:00
|
|
|
fn macro_if() {
|
|
|
|
if blocky!() {
|
|
|
|
}
|
2016-12-21 12:30:41 +01:00
|
|
|
|
2016-01-31 23:25:10 +01:00
|
|
|
if blocky_too!() {
|
|
|
|
}
|
2016-01-02 17:11:48 +01:00
|
|
|
}
|
2016-01-31 23:25:10 +01:00
|
|
|
|
2015-11-20 06:22:52 +01:00
|
|
|
fn condition_has_block() -> i32 {
|
2017-02-08 14:58:07 +01:00
|
|
|
if {
|
2015-11-20 06:22:52 +01:00
|
|
|
let x = 3;
|
|
|
|
x == 3
|
|
|
|
} {
|
|
|
|
6
|
|
|
|
} else {
|
|
|
|
10
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn condition_has_block_with_single_expression() -> i32 {
|
2017-02-08 14:58:07 +01:00
|
|
|
if { true } {
|
2015-11-20 06:22:52 +01:00
|
|
|
6
|
|
|
|
} else {
|
|
|
|
10
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn predicate<F: FnOnce(T) -> bool, T>(pfn: F, val:T) -> bool {
|
|
|
|
pfn(val)
|
|
|
|
}
|
|
|
|
|
|
|
|
fn pred_test() {
|
|
|
|
let v = 3;
|
|
|
|
let sky = "blue";
|
|
|
|
// this is a sneaky case, where the block isn't directly in the condition, but is actually
|
|
|
|
// inside a closure that the condition is using. same principle applies. add some extra
|
|
|
|
// expressions to make sure linter isn't confused by them.
|
2016-12-21 12:30:41 +01:00
|
|
|
if v == 3 && sky == "blue" && predicate(|x| { let target = 3; x == target }, v) {
|
2015-11-20 06:22:52 +01:00
|
|
|
}
|
|
|
|
|
2016-12-21 12:30:41 +01:00
|
|
|
if predicate(|x| { let target = 3; x == target }, v) {
|
2015-11-20 06:22:52 +01:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn condition_is_normal() -> i32 {
|
|
|
|
let x = 3;
|
2017-02-08 14:58:07 +01:00
|
|
|
if true && x == 3 {
|
2015-11-20 06:22:52 +01:00
|
|
|
6
|
|
|
|
} else {
|
|
|
|
10
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn closure_without_block() {
|
|
|
|
if predicate(|x| x == 3, 6) {
|
|
|
|
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-12-23 02:12:08 +01:00
|
|
|
fn condition_is_unsafe_block() {
|
|
|
|
let a: i32 = 1;
|
|
|
|
|
|
|
|
// this should not warn because the condition is an unsafe block
|
|
|
|
if unsafe { 1u32 == std::mem::transmute(a) } {
|
|
|
|
println!("1u32 == a");
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-11-20 06:22:52 +01:00
|
|
|
fn main() {
|
|
|
|
}
|