2015-08-29 11:41:06 +02:00
|
|
|
#![feature(plugin)]
|
|
|
|
#![plugin(clippy)]
|
|
|
|
|
2017-05-17 14:19:44 +02:00
|
|
|
#![warn(while_let_loop, empty_loop, while_let_on_iterator)]
|
2017-02-17 04:53:14 +01:00
|
|
|
#![allow(dead_code, never_loop, unused, cyclomatic_complexity)]
|
2015-10-02 09:55:34 +02:00
|
|
|
|
2015-08-29 11:41:06 +02:00
|
|
|
fn main() {
|
|
|
|
let y = Some(true);
|
2016-02-24 20:54:35 +01:00
|
|
|
loop {
|
2015-08-29 11:41:06 +02:00
|
|
|
if let Some(_x) = y {
|
|
|
|
let _v = 1;
|
|
|
|
} else {
|
|
|
|
break
|
|
|
|
}
|
|
|
|
}
|
|
|
|
loop { // no error, break is not in else clause
|
|
|
|
if let Some(_x) = y {
|
|
|
|
let _v = 1;
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
}
|
2016-02-24 20:54:35 +01:00
|
|
|
loop {
|
2015-08-29 11:41:06 +02:00
|
|
|
match y {
|
|
|
|
Some(_x) => true,
|
|
|
|
None => break
|
|
|
|
};
|
|
|
|
}
|
2016-02-24 20:54:35 +01:00
|
|
|
loop {
|
2015-09-27 09:39:42 +02:00
|
|
|
let x = match y {
|
|
|
|
Some(x) => x,
|
2015-08-29 11:41:06 +02:00
|
|
|
None => break
|
|
|
|
};
|
2015-09-27 09:39:42 +02:00
|
|
|
let _x = x;
|
|
|
|
let _str = "foo";
|
2015-08-29 11:41:06 +02:00
|
|
|
}
|
2016-02-24 20:54:35 +01:00
|
|
|
loop {
|
2015-10-11 18:49:01 +02:00
|
|
|
let x = match y {
|
|
|
|
Some(x) => x,
|
|
|
|
None => break,
|
|
|
|
};
|
|
|
|
{ let _a = "bar"; };
|
|
|
|
{ let _b = "foobar"; }
|
|
|
|
}
|
2015-08-29 11:41:06 +02:00
|
|
|
loop { // no error, else branch does something other than break
|
|
|
|
match y {
|
|
|
|
Some(_x) => true,
|
|
|
|
_ => {
|
|
|
|
let _z = 1;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
};
|
|
|
|
}
|
|
|
|
while let Some(x) = y { // no error, obviously
|
|
|
|
println!("{}", x);
|
|
|
|
}
|
2015-10-16 20:27:13 +02:00
|
|
|
|
2016-02-27 22:59:15 +01:00
|
|
|
// #675, this used to have a wrong suggestion
|
|
|
|
loop {
|
|
|
|
let (e, l) = match "".split_whitespace().next() {
|
|
|
|
Some(word) => (word.is_empty(), word.len()),
|
|
|
|
None => break
|
|
|
|
};
|
|
|
|
|
|
|
|
let _ = (e, l);
|
|
|
|
}
|
|
|
|
|
2015-10-22 23:16:58 +02:00
|
|
|
let mut iter = 1..20;
|
2016-06-07 18:33:11 +02:00
|
|
|
while let Option::Some(x) = iter.next() {
|
2015-10-16 20:27:13 +02:00
|
|
|
println!("{}", x);
|
|
|
|
}
|
|
|
|
|
2015-10-22 23:16:58 +02:00
|
|
|
let mut iter = 1..20;
|
2016-06-07 18:33:11 +02:00
|
|
|
while let Some(x) = iter.next() {
|
2015-10-16 20:27:13 +02:00
|
|
|
println!("{}", x);
|
|
|
|
}
|
|
|
|
|
2015-10-22 23:16:58 +02:00
|
|
|
let mut iter = 1..20;
|
2016-06-07 18:33:11 +02:00
|
|
|
while let Some(_) = iter.next() {}
|
2017-02-08 14:58:07 +01:00
|
|
|
|
2015-10-22 23:16:58 +02:00
|
|
|
let mut iter = 1..20;
|
|
|
|
while let None = iter.next() {} // this is fine (if nonsensical)
|
2015-10-16 20:27:13 +02:00
|
|
|
|
2015-10-22 23:16:58 +02:00
|
|
|
let mut iter = 1..20;
|
|
|
|
if let Some(x) = iter.next() { // also fine
|
2015-10-16 20:27:13 +02:00
|
|
|
println!("{}", x)
|
|
|
|
}
|
2015-10-20 01:04:21 +02:00
|
|
|
|
|
|
|
// the following shouldn't warn because it can't be written with a for loop
|
|
|
|
let mut iter = 1u32..20;
|
|
|
|
while let Some(x) = iter.next() {
|
|
|
|
println!("next: {:?}", iter.next())
|
|
|
|
}
|
2015-10-26 23:49:37 +01:00
|
|
|
|
|
|
|
// neither can this
|
|
|
|
let mut iter = 1u32..20;
|
|
|
|
while let Some(x) = iter.next() {
|
|
|
|
println!("next: {:?}", iter.next());
|
|
|
|
}
|
|
|
|
|
|
|
|
// or this
|
|
|
|
let mut iter = 1u32..20;
|
|
|
|
while let Some(x) = iter.next() {break;}
|
|
|
|
println!("Remaining iter {:?}", iter);
|
|
|
|
|
|
|
|
// or this
|
|
|
|
let mut iter = 1u32..20;
|
|
|
|
while let Some(x) = iter.next() {
|
|
|
|
iter = 1..20;
|
|
|
|
}
|
2015-08-29 11:41:06 +02:00
|
|
|
}
|
2015-10-02 09:55:34 +02:00
|
|
|
|
|
|
|
// regression test (#360)
|
|
|
|
// this should not panic
|
|
|
|
// it's okay if further iterations of the lint
|
|
|
|
// cause this function to trigger it
|
|
|
|
fn no_panic<T>(slice: &[T]) {
|
|
|
|
let mut iter = slice.iter();
|
2016-06-07 18:33:11 +02:00
|
|
|
loop {
|
2015-10-02 09:55:34 +02:00
|
|
|
let _ = match iter.next() {
|
|
|
|
Some(ele) => ele,
|
|
|
|
None => break
|
|
|
|
};
|
2017-02-08 14:58:07 +01:00
|
|
|
loop {}
|
2015-10-02 09:55:34 +02:00
|
|
|
}
|
|
|
|
}
|
2016-06-16 16:19:17 +02:00
|
|
|
|
|
|
|
fn issue1017() {
|
|
|
|
let r: Result<u32, u32> = Ok(42);
|
|
|
|
let mut len = 1337;
|
|
|
|
|
|
|
|
loop {
|
|
|
|
match r {
|
|
|
|
Err(_) => len = 0,
|
|
|
|
Ok(length) => {
|
|
|
|
len = length;
|
|
|
|
break
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2016-09-16 15:45:44 +02:00
|
|
|
|
|
|
|
// Issue #1188
|
|
|
|
fn refutable() {
|
|
|
|
let a = [42, 1337];
|
|
|
|
let mut b = a.iter();
|
|
|
|
|
|
|
|
// consume all the 42s
|
|
|
|
while let Some(&42) = b.next() {
|
|
|
|
}
|
|
|
|
|
|
|
|
let a = [(1, 2, 3)];
|
|
|
|
let mut b = a.iter();
|
|
|
|
|
|
|
|
while let Some(&(1, 2, 3)) = b.next() {
|
|
|
|
}
|
|
|
|
|
|
|
|
let a = [Some(42)];
|
|
|
|
let mut b = a.iter();
|
|
|
|
|
|
|
|
while let Some(&None) = b.next() {
|
|
|
|
}
|
|
|
|
|
|
|
|
/* This gives “refutable pattern in `for` loop binding: `&_` not covered”
|
|
|
|
for &42 in b {}
|
|
|
|
for &(1, 2, 3) in b {}
|
|
|
|
for &Option::None in b.next() {}
|
|
|
|
// */
|
2017-06-23 18:29:18 +02:00
|
|
|
|
2017-06-30 02:43:52 +02:00
|
|
|
let mut y = a.iter();
|
2017-06-23 18:29:18 +02:00
|
|
|
loop { // x is reused, so don't lint here
|
2017-06-30 02:43:52 +02:00
|
|
|
while let Some(v) = y.next() {
|
2017-06-23 18:29:18 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2017-06-30 02:43:52 +02:00
|
|
|
let mut y = a.iter();
|
2017-06-23 18:29:18 +02:00
|
|
|
for _ in 0..2 {
|
2017-08-01 00:58:26 +02:00
|
|
|
while let Some(v) = y.next() { // y is reused, don't lint
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
loop {
|
|
|
|
let mut y = a.iter();
|
|
|
|
while let Some(v) = y.next() { // use a for loop here
|
2017-06-23 18:29:18 +02:00
|
|
|
}
|
|
|
|
}
|
2017-09-05 22:28:30 +02:00
|
|
|
|
2017-09-05 23:19:51 +02:00
|
|
|
// should not trigger while_let_loop lint because break passes an expression
|
2017-09-05 22:28:30 +02:00
|
|
|
let a = Some(10);
|
|
|
|
let b = loop {
|
|
|
|
if let Some(c) = a {
|
|
|
|
break Some(c);
|
|
|
|
} else {
|
|
|
|
break None;
|
|
|
|
}
|
|
|
|
};
|
2016-09-16 15:45:44 +02:00
|
|
|
}
|