rust/tests/ui/methods.rs

271 lines
6.2 KiB
Rust
Raw Normal View History

// aux-build:option_helpers.rs
2018-07-28 17:34:52 +02:00
#![warn(clippy::all, clippy::pedantic, clippy::option_unwrap_used)]
#![allow(
clippy::blacklisted_name,
unused,
clippy::print_stdout,
clippy::non_ascii_literal,
clippy::new_without_default,
clippy::missing_docs_in_private_items,
clippy::needless_pass_by_value,
clippy::default_trait_access,
clippy::use_self,
clippy::new_ret_no_self,
clippy::useless_format
)]
#[macro_use]
extern crate option_helpers;
use std::collections::BTreeMap;
use std::collections::HashMap;
use std::collections::HashSet;
use std::collections::VecDeque;
use std::iter::FromIterator;
2019-02-22 07:05:21 +01:00
use std::ops::Mul;
use std::rc::{self, Rc};
use std::sync::{self, Arc};
use option_helpers::IteratorFalsePositives;
2017-11-03 05:54:35 +01:00
pub struct T;
impl T {
2019-02-22 07:05:21 +01:00
pub fn add(self, other: T) -> T {
self
}
// no error, not public interface
pub(crate) fn drop(&mut self) {}
2019-02-22 07:05:21 +01:00
// no error, private function
fn neg(self) -> Self {
self
}
// no error, private function
fn eq(&self, other: T) -> bool {
true
}
2019-01-31 02:15:29 +01:00
// No error; self is a ref.
2019-02-22 07:05:21 +01:00
fn sub(&self, other: T) -> &T {
self
}
2019-01-31 02:15:29 +01:00
// No error; different number of arguments.
2019-02-22 07:05:21 +01:00
fn div(self) -> T {
self
}
2019-01-31 02:15:29 +01:00
// No error; wrong return type.
fn rem(self, other: T) {}
2019-02-22 07:05:21 +01:00
2019-01-31 02:15:29 +01:00
// Fine
2019-02-22 07:05:21 +01:00
fn into_u32(self) -> u32 {
0
}
2019-02-22 07:05:21 +01:00
fn into_u16(&self) -> u16 {
0
}
2019-02-22 07:05:21 +01:00
fn to_something(self) -> u32 {
0
}
2019-02-22 07:05:21 +01:00
fn new(self) -> Self {
unimplemented!();
}
}
struct Lt<'a> {
foo: &'a u32,
}
impl<'a> Lt<'a> {
2019-01-31 02:15:29 +01:00
// The lifetime is different, but thats irrelevant; see issue #734.
2018-07-28 17:34:52 +02:00
#[allow(clippy::needless_lifetimes)]
2019-02-22 07:05:21 +01:00
pub fn new<'b>(s: &'b str) -> Lt<'b> {
unimplemented!()
}
}
struct Lt2<'a> {
foo: &'a u32,
}
impl<'a> Lt2<'a> {
2019-01-31 02:15:29 +01:00
// The lifetime is different, but thats irrelevant; see issue #734.
2019-02-22 07:05:21 +01:00
pub fn new(s: &str) -> Lt2 {
unimplemented!()
}
}
struct Lt3<'a> {
foo: &'a u32,
}
impl<'a> Lt3<'a> {
2019-01-31 02:15:29 +01:00
// The lifetime is different, but thats irrelevant; see issue #734.
2019-02-22 07:05:21 +01:00
pub fn new() -> Lt3<'static> {
unimplemented!()
}
}
2019-02-22 07:05:21 +01:00
#[derive(Clone, Copy)]
struct U;
impl U {
2019-02-22 07:05:21 +01:00
fn new() -> Self {
U
}
2019-01-31 02:15:29 +01:00
// Ok because `U` is `Copy`.
2019-02-22 07:05:21 +01:00
fn to_something(self) -> u32 {
0
}
}
struct V<T> {
2019-02-22 07:05:21 +01:00
_dummy: T,
}
impl<T> V<T> {
2019-02-22 07:05:21 +01:00
fn new() -> Option<V<T>> {
None
}
}
impl Mul<T> for T {
type Output = T;
2019-01-31 02:15:29 +01:00
// No error, obviously.
2019-02-22 07:05:21 +01:00
fn mul(self, other: T) -> T {
self
}
}
/// Checks implementation of the following lints:
/// * `OPTION_MAP_UNWRAP_OR`
/// * `OPTION_MAP_UNWRAP_OR_ELSE`
#[rustfmt::skip]
fn option_methods() {
let opt = Some(1);
2019-01-31 02:15:29 +01:00
// Check `OPTION_MAP_UNWRAP_OR`.
// Single line case.
2017-02-08 14:58:07 +01:00
let _ = opt.map(|x| x + 1)
2019-01-31 02:15:29 +01:00
// Should lint even though this call is on a separate line.
.unwrap_or(0);
// Multi-line cases.
2017-02-08 14:58:07 +01:00
let _ = opt.map(|x| {
x + 1
}
).unwrap_or(0);
2017-02-08 14:58:07 +01:00
let _ = opt.map(|x| x + 1)
.unwrap_or({
0
});
2019-01-31 02:15:29 +01:00
// Single line `map(f).unwrap_or(None)` case.
let _ = opt.map(|x| Some(x + 1)).unwrap_or(None);
2019-01-31 02:15:29 +01:00
// Multi-line `map(f).unwrap_or(None)` cases.
let _ = opt.map(|x| {
Some(x + 1)
}
).unwrap_or(None);
let _ = opt
.map(|x| Some(x + 1))
.unwrap_or(None);
// macro case
let _ = opt_map!(opt, |x| x + 1).unwrap_or(0); // should not lint
2019-01-21 18:29:35 +01:00
// Should not lint if not copyable
2019-01-16 16:55:53 +01:00
let id: String = "identifier".to_string();
2019-01-21 18:29:35 +01:00
let _ = Some("prefix").map(|p| format!("{}.{}", p, id)).unwrap_or(id);
// ...but DO lint if the `unwrap_or` argument is not used in the `map`
let id: String = "identifier".to_string();
let _ = Some("prefix").map(|p| format!("{}.", p)).unwrap_or(id);
2019-01-16 16:55:53 +01:00
// Check OPTION_MAP_UNWRAP_OR_ELSE
// single line case
2017-02-08 14:58:07 +01:00
let _ = opt.map(|x| x + 1)
2019-01-31 02:15:29 +01:00
// Should lint even though this call is on a separate line.
.unwrap_or_else(|| 0);
// Multi-line cases.
2017-02-08 14:58:07 +01:00
let _ = opt.map(|x| {
x + 1
}
).unwrap_or_else(|| 0);
2017-02-08 14:58:07 +01:00
let _ = opt.map(|x| x + 1)
.unwrap_or_else(||
0
);
2019-01-31 02:15:29 +01:00
// Macro case.
// Should not lint.
let _ = opt_map!(opt, |x| x + 1).unwrap_or_else(|| 0);
}
2019-01-31 02:15:29 +01:00
/// Checks implementation of `FILTER_NEXT` lint.
#[rustfmt::skip]
fn filter_next() {
let v = vec![3, 2, 1, 0, -1, -2, -3];
2019-01-31 02:15:29 +01:00
// Single-line case.
let _ = v.iter().filter(|&x| *x < 0).next();
2017-02-08 14:58:07 +01:00
2019-01-31 02:15:29 +01:00
// Multi-line case.
2017-02-08 14:58:07 +01:00
let _ = v.iter().filter(|&x| {
*x < 0
}
).next();
2019-01-31 02:15:29 +01:00
// Check that hat we don't lint if the caller is not an `Iterator`.
let foo = IteratorFalsePositives { foo: 0 };
let _ = foo.filter().next();
}
2019-01-31 02:15:29 +01:00
/// Checks implementation of `SEARCH_IS_SOME` lint.
#[rustfmt::skip]
fn search_is_some() {
let v = vec![3, 2, 1, 0, -1, -2, -3];
2019-01-31 02:15:29 +01:00
// Check `find().is_some()`, single-line case.
let _ = v.iter().find(|&x| *x < 0).is_some();
2017-02-08 14:58:07 +01:00
2019-01-31 02:15:29 +01:00
// Check `find().is_some()`, multi-line case.
2017-02-08 14:58:07 +01:00
let _ = v.iter().find(|&x| {
*x < 0
}
).is_some();
2019-01-31 02:15:29 +01:00
// Check `position().is_some()`, single-line case.
let _ = v.iter().position(|&x| x < 0).is_some();
2017-02-08 14:58:07 +01:00
2019-01-31 02:15:29 +01:00
// Check `position().is_some()`, multi-line case.
2017-02-08 14:58:07 +01:00
let _ = v.iter().position(|&x| {
x < 0
}
).is_some();
2019-01-31 02:15:29 +01:00
// Check `rposition().is_some()`, single-line case.
let _ = v.iter().rposition(|&x| x < 0).is_some();
2017-02-08 14:58:07 +01:00
2019-01-31 02:15:29 +01:00
// Check `rposition().is_some()`, multi-line case.
2017-02-08 14:58:07 +01:00
let _ = v.iter().rposition(|&x| {
x < 0
}
).is_some();
2019-01-31 02:15:29 +01:00
// Check that we don't lint if the caller is not an `Iterator`.
let foo = IteratorFalsePositives { foo: 0 };
let _ = foo.find().is_some();
let _ = foo.position().is_some();
let _ = foo.rposition().is_some();
}
2018-07-28 17:34:52 +02:00
#[allow(clippy::similar_names)]
fn main() {
let opt = Some(0);
2017-02-08 14:58:07 +01:00
let _ = opt.unwrap();
}