Rollup merge of #82214 - est31:no_to_string, r=oli-obk

Remove redundant to_string calls
This commit is contained in:
Dylan DPC 2021-02-25 14:33:59 +01:00 committed by GitHub
commit 00aa3e6880
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 6 deletions

View File

@ -93,7 +93,7 @@ pub(crate) unsafe fn codegen(
let args = [usize, usize]; // size, align let args = [usize, usize]; // size, align
let ty = llvm::LLVMFunctionType(void, args.as_ptr(), args.len() as c_uint, False); let ty = llvm::LLVMFunctionType(void, args.as_ptr(), args.len() as c_uint, False);
let name = "__rust_alloc_error_handler".to_string(); let name = "__rust_alloc_error_handler";
let llfn = llvm::LLVMRustGetOrInsertFunction(llmod, name.as_ptr().cast(), name.len(), ty); let llfn = llvm::LLVMRustGetOrInsertFunction(llmod, name.as_ptr().cast(), name.len(), ty);
// -> ! DIFlagNoReturn // -> ! DIFlagNoReturn
llvm::Attribute::NoReturn.apply_llfn(llvm::AttributePlace::Function, llfn); llvm::Attribute::NoReturn.apply_llfn(llvm::AttributePlace::Function, llfn);

View File

@ -181,16 +181,16 @@ fn get_linker(
let original_path = tool.path(); let original_path = tool.path();
if let Some(ref root_lib_path) = original_path.ancestors().nth(4) { if let Some(ref root_lib_path) = original_path.ancestors().nth(4) {
let arch = match t.arch.as_str() { let arch = match t.arch.as_str() {
"x86_64" => Some("x64".to_string()), "x86_64" => Some("x64"),
"x86" => Some("x86".to_string()), "x86" => Some("x86"),
"aarch64" => Some("arm64".to_string()), "aarch64" => Some("arm64"),
"arm" => Some("arm".to_string()), "arm" => Some("arm"),
_ => None, _ => None,
}; };
if let Some(ref a) = arch { if let Some(ref a) = arch {
// FIXME: Move this to `fn linker_with_args`. // FIXME: Move this to `fn linker_with_args`.
let mut arg = OsString::from("/LIBPATH:"); let mut arg = OsString::from("/LIBPATH:");
arg.push(format!("{}\\lib\\{}\\store", root_lib_path.display(), a.to_string())); arg.push(format!("{}\\lib\\{}\\store", root_lib_path.display(), a));
cmd.arg(&arg); cmd.arg(&arg);
} else { } else {
warn!("arch is not supported"); warn!("arch is not supported");