Code review changes and fix rustdoc test.

This commit is contained in:
Ben Lewis 2020-01-11 20:57:38 +13:00
parent a6c4025fac
commit 02fffc1556
5 changed files with 16 additions and 44 deletions

View File

@ -148,18 +148,18 @@ pub struct GlobalId<'tcx> {
pub promoted: Option<mir::Promoted>,
}
/// Input argument for `tcx.lit_to_const`
/// Input argument for `tcx.lit_to_const`.
#[derive(Copy, Clone, Debug, Eq, PartialEq, Hash, HashStable)]
pub struct LitToConstInput<'tcx> {
/// The absolute value of the resultant constant
/// The absolute value of the resultant constant.
pub lit: &'tcx LitKind,
/// The type of the constant
/// The type of the constant.
pub ty: Ty<'tcx>,
/// If the constant is negative
/// If the constant is negative.
pub neg: bool,
}
/// Error type for `tcx.lit_to_const`
/// Error type for `tcx.lit_to_const`.
#[derive(Copy, Clone, Debug, Eq, PartialEq, HashStable)]
pub enum LitToConstError {
UnparseableFloat,

View File

@ -8,9 +8,8 @@ pub(crate) use self::check_match::check_match;
use crate::hair::util::UserAnnotatedTyHelpers;
use rustc::mir::interpret::{
get_slice_bytes, sign_extend, ConstValue, ErrorHandled, LitToConstError, LitToConstInput,
};
use rustc::mir::interpret::{get_slice_bytes, sign_extend, ConstValue, ErrorHandled};
use rustc::mir::interpret::{LitToConstError, LitToConstInput};
use rustc::mir::UserTypeProjection;
use rustc::mir::{BorrowKind, Field, Mutability};
use rustc::ty::layout::VariantIdx;

View File

@ -1,4 +1,4 @@
// ignore-tidy-filelength FIXME(#67418) Split up this file
// ignore-tidy-filelength FIXME(#67418) Split up this file.
//! Conversion from AST representation of types to the `ty.rs` representation.
//! The main routine here is `ast_ty_to_ty()`; each use is parameterized by an
//! instance of `AstConv`.
@ -2716,7 +2716,7 @@ impl<'o, 'tcx> dyn AstConv<'tcx> + 'o {
if let Some(lit_input) = lit_input {
// If an error occurred, ignore that it's a literal and leave reporting the error up to
// mir
// mir.
if let Ok(c) = tcx.at(expr.span).lit_to_const(lit_input) {
return c;
}

View File

@ -1441,17 +1441,8 @@ pub struct MacroDef {
pub legacy: bool,
}
#[derive(
Clone,
RustcEncodable,
RustcDecodable,
Debug,
Copy,
Hash,
Eq,
PartialEq,
HashStable_Generic
)]
#[derive(Clone, RustcEncodable, RustcDecodable, Debug, Copy, Hash, Eq, PartialEq)]
#[derive(HashStable_Generic)]
pub enum StrStyle {
/// A regular string, like `"foo"`.
Cooked,
@ -1501,17 +1492,8 @@ impl StrLit {
}
/// Type of the integer literal based on provided suffix.
#[derive(
Clone,
Copy,
RustcEncodable,
RustcDecodable,
Debug,
Hash,
Eq,
PartialEq,
HashStable_Generic
)]
#[derive(Clone, Copy, RustcEncodable, RustcDecodable, Debug, Hash, Eq, PartialEq)]
#[derive(HashStable_Generic)]
pub enum LitIntType {
/// e.g. `42_i32`.
Signed(IntTy),
@ -1522,17 +1504,8 @@ pub enum LitIntType {
}
/// Type of the float literal based on provided suffix.
#[derive(
Clone,
Copy,
RustcEncodable,
RustcDecodable,
Debug,
Hash,
Eq,
PartialEq,
HashStable_Generic
)]
#[derive(Clone, Copy, RustcEncodable, RustcDecodable, Debug, Hash, Eq, PartialEq)]
#[derive(HashStable_Generic)]
pub enum LitFloatType {
/// A float literal with a suffix (`1f32` or `1E10f32`).
Suffixed(FloatTy),

View File

@ -11,7 +11,7 @@ pub struct Simd<T, const WIDTH: usize> {
inner: T,
}
// @has foo/struct.Simd.html '//div[@id="implementations-list"]/h3/code' 'impl Add<Simd<u8, 16>> for Simd<u8, 16>'
// @has foo/struct.Simd.html '//div[@id="implementations-list"]/h3/code' 'impl Add<Simd<u8, 16usize>> for Simd<u8, 16>'
impl Add for Simd<u8, 16> {
type Output = Self;