Auto merge of #73166 - jethrogb:stdarch, r=Amanieu
Update stdarch This PR **changes the public signature** of the following functions in `core::arch::{x86, x86_64}`: ```patch -pub unsafe fn _mm256_extract_epi8(a: __m256i, imm8: i32) -> i8 +pub unsafe fn _mm256_extract_epi8(a: __m256i, imm8: i32) -> i32 -pub unsafe fn _mm256_extract_epi16(a: __m256i, imm8: i32) -> i16 +pub unsafe fn _mm256_extract_epi16(a: __m256i, imm8: i32) -> i32 ``` This change is desired so that these signatures * are similar to those of the 128-bit versions `_mm_extract_epi8` and `_mm_extract_epi16` * match the Intel definitions for the intrinsics * [RFC 2325](https://github.com/rust-lang/rfcs/blob/master/text/2325-stable-simd.md) specifies that the exact vendor function signatures should be used A [crater run](https://github.com/rust-lang/rust/pull/73166#issuecomment-667230319) revealed only a single breakage. The [vektor crate](https://github.com/AdamNiederer/vektor/blob/master/src/x86/avx2.rs#L2436-L2472) copied the incorrect signatures in `core` exactly to their own crate. The functions don't seem to be used by anyone anywhere. Actual breakage is not expected, since due to the nature of the functions, users would generally write `_mm256_extract_epi8(...) as u8` or `_mm256_extract_epi16(...) as u16`. See https://github.com/rust-lang/stdarch/pull/868/. Note that the changes from that stdarch PR have already partially landed in core after https://github.com/rust-lang/stdarch/pull/878/. This PR is now only about the remaining changes.
This commit is contained in:
commit
07ece44a42
|
@ -1 +1 @@
|
|||
Subproject commit 78891cdf292c23278ca8723bd543100249159604
|
||||
Subproject commit 718175b34a39e4e3d59b40e35930326edc515b87
|
Loading…
Reference in New Issue