OpenE2K/rust
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

bool-comparison: make lint adhere to lint message convention

Browse Source
This commit is contained in:
Matthias Krüger 2020-07-23 15:14:12 +02:00
parent e57aafe33f
commit 0876f17d77
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clippy_lints/src/needless_bool.rs
View File

@ -243,7 +243,7 @@ fn check_comparison<'a, 'tcx>(
cx, cx,
BOOL_COMPARISON, BOOL_COMPARISON,
e.span, e.span,
"This comparison might be written more concisely", "this comparison might be written more concisely",
"try simplifying it as shown", "try simplifying it as shown",
format!( format!(
"{} != {}", "{} != {}",

8
tests/ui/bool_comparison.stderr
View File

@ -84,25 +84,25 @@ error: order comparisons between booleans can be simplified
LL | if x > y { LL | if x > y {
| ^^^^^ help: try simplifying it as shown: `x & !y` | ^^^^^ help: try simplifying it as shown: `x & !y`
error: This comparison might be written more concisely error: this comparison might be written more concisely
--> $DIR/bool_comparison.rs:120:8 --> $DIR/bool_comparison.rs:120:8
| |
LL | if a == !b {}; LL | if a == !b {};
| ^^^^^^^ help: try simplifying it as shown: `a != b` | ^^^^^^^ help: try simplifying it as shown: `a != b`
error: This comparison might be written more concisely error: this comparison might be written more concisely
--> $DIR/bool_comparison.rs:121:8 --> $DIR/bool_comparison.rs:121:8
| |
LL | if !a == b {}; LL | if !a == b {};
| ^^^^^^^ help: try simplifying it as shown: `a != b` | ^^^^^^^ help: try simplifying it as shown: `a != b`
error: This comparison might be written more concisely error: this comparison might be written more concisely
--> $DIR/bool_comparison.rs:125:8 --> $DIR/bool_comparison.rs:125:8
| |
LL | if b == !a {}; LL | if b == !a {};
| ^^^^^^^ help: try simplifying it as shown: `b != a` | ^^^^^^^ help: try simplifying it as shown: `b != a`
error: This comparison might be written more concisely error: this comparison might be written more concisely
--> $DIR/bool_comparison.rs:126:8 --> $DIR/bool_comparison.rs:126:8
| |
LL | if !b == a {}; LL | if !b == a {};