From 1e9e30dc404edaec5bf5ef9c1d88157a883da374 Mon Sep 17 00:00:00 2001 From: Ohad Ravid Date: Wed, 18 Nov 2020 07:48:03 +0200 Subject: [PATCH] Added `impl Rem for u{0}` which cannot panic --- library/core/src/num/nonzero.rs | 14 +++++++++++++- library/core/tests/nonzero.rs | 8 ++++++++ 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/library/core/src/num/nonzero.rs b/library/core/src/num/nonzero.rs index 3355fb64ecf..e139facb6ea 100644 --- a/library/core/src/num/nonzero.rs +++ b/library/core/src/num/nonzero.rs @@ -1,7 +1,7 @@ //! Definitions of integer that is known not to equal zero. use crate::fmt; -use crate::ops::{BitOr, BitOrAssign, Div}; +use crate::ops::{BitOr, BitOrAssign, Div, Rem}; use crate::str::FromStr; use super::from_str_radix; @@ -279,6 +279,18 @@ macro_rules! nonzero_integers_div { unsafe { crate::intrinsics::unchecked_div(self, other.get()) } } } + + #[stable(feature = "nonzero_div", since = "1.50.0")] + impl Rem<$Ty> for $Int { + type Output = $Int; + /// This operation satisfies `n % d == n - (n / d) * d`, and cannot panic. + #[inline] + fn rem(self, other: $Ty) -> $Int { + // SAFETY: rem by zero is checked because `other` is a nonzero, + // and MIN/-1 is checked because `self` is an unsigned int. + unsafe { crate::intrinsics::unchecked_rem(self, other.get()) } + } + } )+ } } diff --git a/library/core/tests/nonzero.rs b/library/core/tests/nonzero.rs index 6ec3a04adc0..c2c08522d0c 100644 --- a/library/core/tests/nonzero.rs +++ b/library/core/tests/nonzero.rs @@ -320,3 +320,11 @@ fn test_nonzero_uint_div() { let x: u32 = 42u32 / nz; assert_eq!(x, 42u32); } + +#[test] +fn test_nonzero_uint_rem() { + let nz = NonZeroU32::new(10).unwrap(); + + let x: u32 = 42u32 % nz; + assert_eq!(x, 2u32); +}