OpenE2K/rust
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Update help text in inefficient_to_string

Browse Source 
Co-Authored-By: Manish Goregaokar <manishsmail@gmail.com>
This commit is contained in:
Michael Zhang 2019-10-17 19:11:51 -04:00 committed by HMPerson1
parent ffb53e7457
commit 2106a23966
No known key found for this signature in database
GPG Key ID: 1FB477DDD27821CE
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clippy_lints/src/methods/inefficient_to_string.rs
View File

@ -24,7 +24,7 @@ pub fn lint<'tcx>(cx: &LateContext<'_, 'tcx>, expr: &hir::Expr, arg: &hir::Expr,
&format!("calling `to_string` on `{}`", arg_ty), &format!("calling `to_string` on `{}`", arg_ty),
|db| { |db| {
db.help(&format!( db.help(&format!(
"`{}` implements `ToString` through the blanket impl, but `{}` specializes `ToString` directly", "`{}` implements `ToString` through a slower blanket impl, but `{}` has a fast specialization of `ToString`",
self_ty, deref_self_ty self_ty, deref_self_ty
)); ));
let mut applicability = Applicability::MachineApplicable; let mut applicability = Applicability::MachineApplicable;

12
tests/ui/inefficient_to_string.stderr
View File

@ -9,7 +9,7 @@ note: lint level defined here
| |
LL | #![deny(clippy::inefficient_to_string)] LL | #![deny(clippy::inefficient_to_string)]
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: `&str` implements `ToString` through the blanket impl, but `str` specializes `ToString` directly = help: `&str` implements `ToString` through a slower blanket impl, but `str` has a fast specialization of `ToString`
error: calling `to_string` on `&&&str` error: calling `to_string` on `&&&str`
--> $DIR/inefficient_to_string.rs:13:21 --> $DIR/inefficient_to_string.rs:13:21
@ -17,7 +17,7 @@ error: calling `to_string` on `&&&str`
LL | let _: String = rrrstr.to_string(); LL | let _: String = rrrstr.to_string();
| ^^^^^^^^^^^^^^^^^^ help: try dereferencing the receiver: `(**rrrstr).to_string()` | ^^^^^^^^^^^^^^^^^^ help: try dereferencing the receiver: `(**rrrstr).to_string()`
| |
= help: `&&str` implements `ToString` through the blanket impl, but `str` specializes `ToString` directly = help: `&&str` implements `ToString` through a slower blanket impl, but `str` has a fast specialization of `ToString`
error: calling `to_string` on `&&std::string::String` error: calling `to_string` on `&&std::string::String`
--> $DIR/inefficient_to_string.rs:21:21 --> $DIR/inefficient_to_string.rs:21:21
@ -25,7 +25,7 @@ error: calling `to_string` on `&&std::string::String`
LL | let _: String = rrstring.to_string(); LL | let _: String = rrstring.to_string();
| ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing the receiver: `(*rrstring).to_string()` | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing the receiver: `(*rrstring).to_string()`
| |
= help: `&std::string::String` implements `ToString` through the blanket impl, but `std::string::String` specializes `ToString` directly = help: `&std::string::String` implements `ToString` through a slower blanket impl, but `std::string::String` has a fast specialization of `ToString`
error: calling `to_string` on `&&&std::string::String` error: calling `to_string` on `&&&std::string::String`
--> $DIR/inefficient_to_string.rs:22:21 --> $DIR/inefficient_to_string.rs:22:21
@ -33,7 +33,7 @@ error: calling `to_string` on `&&&std::string::String`
LL | let _: String = rrrstring.to_string(); LL | let _: String = rrrstring.to_string();
| ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing the receiver: `(**rrrstring).to_string()` | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing the receiver: `(**rrrstring).to_string()`
| |
= help: `&&std::string::String` implements `ToString` through the blanket impl, but `std::string::String` specializes `ToString` directly = help: `&&std::string::String` implements `ToString` through a slower blanket impl, but `std::string::String` has a fast specialization of `ToString`
error: calling `to_string` on `&&std::borrow::Cow<'_, str>` error: calling `to_string` on `&&std::borrow::Cow<'_, str>`
--> $DIR/inefficient_to_string.rs:30:21 --> $DIR/inefficient_to_string.rs:30:21
@ -41,7 +41,7 @@ error: calling `to_string` on `&&std::borrow::Cow<'_, str>`
LL | let _: String = rrcow.to_string(); LL | let _: String = rrcow.to_string();
| ^^^^^^^^^^^^^^^^^ help: try dereferencing the receiver: `(*rrcow).to_string()` | ^^^^^^^^^^^^^^^^^ help: try dereferencing the receiver: `(*rrcow).to_string()`
| |
= help: `&std::borrow::Cow<'_, str>` implements `ToString` through the blanket impl, but `std::borrow::Cow<'_, str>` specializes `ToString` directly = help: `&std::borrow::Cow<'_, str>` implements `ToString` through a slower blanket impl, but `std::borrow::Cow<'_, str>` has a fast specialization of `ToString`
error: calling `to_string` on `&&&std::borrow::Cow<'_, str>` error: calling `to_string` on `&&&std::borrow::Cow<'_, str>`
--> $DIR/inefficient_to_string.rs:31:21 --> $DIR/inefficient_to_string.rs:31:21
@ -49,7 +49,7 @@ error: calling `to_string` on `&&&std::borrow::Cow<'_, str>`
LL | let _: String = rrrcow.to_string(); LL | let _: String = rrrcow.to_string();
| ^^^^^^^^^^^^^^^^^^ help: try dereferencing the receiver: `(**rrrcow).to_string()` | ^^^^^^^^^^^^^^^^^^ help: try dereferencing the receiver: `(**rrrcow).to_string()`
| |
= help: `&&std::borrow::Cow<'_, str>` implements `ToString` through the blanket impl, but `std::borrow::Cow<'_, str>` specializes `ToString` directly = help: `&&std::borrow::Cow<'_, str>` implements `ToString` through a slower blanket impl, but `std::borrow::Cow<'_, str>` has a fast specialization of `ToString`
error: aborting due to 6 previous errors error: aborting due to 6 previous errors