OpenE2K
/
rust
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Update comment to reflect slightly-improved GC situation.

This commit is contained in:
Graydon Hoare 2010-06-25 16:56:25 -07:00
parent eed5c0aa24
commit 2a2474d497
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/boot/be/x86.ml
View File

@ -852,15 +852,9 @@ let gc_glue
(c (ecx_n Abi.tydesc_field_free_glue));
add eax ecx; (* Add to tydesc* *)
(* FIXME: this path is all wrong, for three reasons.
(* FIXME: this path is all wrong
*
* First, it needs to unlink the values that it frees from the gc
* chain. Currently it's going to leave dead pointers on it.
*
* Second, the *normal* gc-drop path actually has to do that as well;
* it's not, and that's a problem.
*
* Third, it actually needs to walk in two full passes over the chain:
* It actually needs to walk in two full passes over the chain:
*
* - In pass #1, it goes through and disposes of all mutable exterior
* slots in each record. That is, rc-- the referent, and then