From 36ee92780df09e77aaf4db5899c1af94bd49d3c3 Mon Sep 17 00:00:00 2001 From: flip1995 Date: Wed, 5 Dec 2018 00:14:44 +0100 Subject: [PATCH] Fix ty::TyKind usage --- clippy_lints/src/consts.rs | 9 ++------- clippy_lints/src/minmax.rs | 2 +- 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/clippy_lints/src/consts.rs b/clippy_lints/src/consts.rs index 26a92ab8b9f..761630da376 100644 --- a/clippy_lints/src/consts.rs +++ b/clippy_lints/src/consts.rs @@ -119,17 +119,12 @@ impl Hash for Constant { } impl Constant { - pub fn partial_cmp( - tcx: TyCtxt<'_, '_, '_>, - cmp_type: &ty::TyKind<'_>, - left: &Self, - right: &Self, - ) -> Option { + pub fn partial_cmp(tcx: TyCtxt<'_, '_, '_>, cmp_type: ty::Ty<'_>, left: &Self, right: &Self) -> Option { match (left, right) { (&Constant::Str(ref ls), &Constant::Str(ref rs)) => Some(ls.cmp(rs)), (&Constant::Char(ref l), &Constant::Char(ref r)) => Some(l.cmp(r)), (&Constant::Int(l), &Constant::Int(r)) => { - if let ty::Int(int_ty) = *cmp_type { + if let ty::Int(int_ty) = cmp_type.sty { Some(sext(tcx, l, int_ty).cmp(&sext(tcx, r, int_ty))) } else { Some(l.cmp(&r)) diff --git a/clippy_lints/src/minmax.rs b/clippy_lints/src/minmax.rs index bddad90d1ef..dd3aa85e600 100644 --- a/clippy_lints/src/minmax.rs +++ b/clippy_lints/src/minmax.rs @@ -51,7 +51,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for MinMaxPass { } match ( outer_max, - Constant::partial_cmp(cx.tcx, &cx.tables.expr_ty(ie).sty, &outer_c, &inner_c), + Constant::partial_cmp(cx.tcx, cx.tables.expr_ty(ie), &outer_c, &inner_c), ) { (_, None) | (MinMax::Max, Some(Ordering::Less)) | (MinMax::Min, Some(Ordering::Greater)) => (), _ => {