OpenE2K/rust
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Don't make decisions on values that don't represent the decision

Browse Source
This commit is contained in:
Oliver Scherer 2019-01-22 15:28:51 +01:00
parent 3168023cc8
commit 38cdf63acf
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
clippy_lints/src/utils/mod.rs
View File

@ -64,9 +64,14 @@ pub fn differing_macro_contexts(lhs: Span, rhs: Span) -> bool {
/// ```
pub fn in_constant(cx: &LateContext<'_, '_>, id: NodeId) -> bool {
let parent_id = cx.tcx.hir().get_parent(id);
match cx.tcx.hir().body_owner_kind(parent_id) {
hir::BodyOwnerKind::Fn | hir::BodyOwnerKind::Closure => false,
hir::BodyOwnerKind::Const | hir::BodyOwnerKind::Static(..) => true,
match cx.tcx.hir().get(parent_id) {
| Node::Item(&Item { node: ItemKind::Const(..), .. })
| Node::TraitItem(&TraitItem { node: TraitItemKind::Const(..), .. })
| Node::ImplItem(&ImplItem { node: ImplItemKind::Const(..), .. })
| Node::AnonConst(_)
| Node::Item(&Item { node: ItemKind::Static(..), .. })
=> true,
_ => false,
}
}