OpenE2K/rust
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

into_string() -> to_owned() (fix #27)

Browse Source
This commit is contained in:
Manish Goregaokar 2015-01-10 10:52:03 +05:30
parent b7ecb6e7c7
commit 538db34e60
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/misc.rs
View File

@ -49,7 +49,7 @@ impl LintPass for MiscPass {
} }
declare_lint!(pub STR_TO_STRING, Warn, "Warn when a String could use into_string() instead of to_string()"); declare_lint!(pub STR_TO_STRING, Warn, "Warn when a String could use to_owned() instead of to_string()");
#[allow(missing_copy_implementations)] #[allow(missing_copy_implementations)]
pub struct StrToStringPass; pub struct StrToStringPass;
@ -64,7 +64,7 @@ impl LintPass for StrToStringPass {
ast::ExprMethodCall(ref method, _, ref args) ast::ExprMethodCall(ref method, _, ref args)
if method.node.as_str() == "to_string" if method.node.as_str() == "to_string"
&& is_str(cx, &*args[0]) => { && is_str(cx, &*args[0]) => {
cx.span_lint(STR_TO_STRING, expr.span, "str.into_string() is faster"); cx.span_lint(STR_TO_STRING, expr.span, "str.to_owned() is faster");
}, },
_ => () _ => ()
} }