Rollup merge of #77167 - fusion-engineering-forks:fix-fixme-min-max-sign-test, r=nagisa
Fix FIXME in core::num test: Check sign of zero in min/max tests. r? nagisa @rustbot modify labels: +C-cleanup
This commit is contained in:
commit
5926c43743
|
@ -634,14 +634,18 @@ assume_usize_width! {
|
||||||
macro_rules! test_float {
|
macro_rules! test_float {
|
||||||
($modname: ident, $fty: ty, $inf: expr, $neginf: expr, $nan: expr) => {
|
($modname: ident, $fty: ty, $inf: expr, $neginf: expr, $nan: expr) => {
|
||||||
mod $modname {
|
mod $modname {
|
||||||
// FIXME(nagisa): these tests should test for sign of -0.0
|
|
||||||
#[test]
|
#[test]
|
||||||
fn min() {
|
fn min() {
|
||||||
assert_eq!((0.0 as $fty).min(0.0), 0.0);
|
assert_eq!((0.0 as $fty).min(0.0), 0.0);
|
||||||
|
assert!((0.0 as $fty).min(0.0).is_sign_positive());
|
||||||
assert_eq!((-0.0 as $fty).min(-0.0), -0.0);
|
assert_eq!((-0.0 as $fty).min(-0.0), -0.0);
|
||||||
|
assert!((-0.0 as $fty).min(-0.0).is_sign_negative());
|
||||||
assert_eq!((9.0 as $fty).min(9.0), 9.0);
|
assert_eq!((9.0 as $fty).min(9.0), 9.0);
|
||||||
assert_eq!((-9.0 as $fty).min(0.0), -9.0);
|
assert_eq!((-9.0 as $fty).min(0.0), -9.0);
|
||||||
assert_eq!((0.0 as $fty).min(9.0), 0.0);
|
assert_eq!((0.0 as $fty).min(9.0), 0.0);
|
||||||
|
assert!((0.0 as $fty).min(9.0).is_sign_positive());
|
||||||
|
assert_eq!((-0.0 as $fty).min(9.0), -0.0);
|
||||||
|
assert!((-0.0 as $fty).min(9.0).is_sign_negative());
|
||||||
assert_eq!((-0.0 as $fty).min(-9.0), -9.0);
|
assert_eq!((-0.0 as $fty).min(-9.0), -9.0);
|
||||||
assert_eq!(($inf as $fty).min(9.0), 9.0);
|
assert_eq!(($inf as $fty).min(9.0), 9.0);
|
||||||
assert_eq!((9.0 as $fty).min($inf), 9.0);
|
assert_eq!((9.0 as $fty).min($inf), 9.0);
|
||||||
|
@ -660,11 +664,19 @@ macro_rules! test_float {
|
||||||
#[test]
|
#[test]
|
||||||
fn max() {
|
fn max() {
|
||||||
assert_eq!((0.0 as $fty).max(0.0), 0.0);
|
assert_eq!((0.0 as $fty).max(0.0), 0.0);
|
||||||
|
assert!((0.0 as $fty).max(0.0).is_sign_positive());
|
||||||
assert_eq!((-0.0 as $fty).max(-0.0), -0.0);
|
assert_eq!((-0.0 as $fty).max(-0.0), -0.0);
|
||||||
|
assert!((-0.0 as $fty).max(-0.0).is_sign_negative());
|
||||||
assert_eq!((9.0 as $fty).max(9.0), 9.0);
|
assert_eq!((9.0 as $fty).max(9.0), 9.0);
|
||||||
assert_eq!((-9.0 as $fty).max(0.0), 0.0);
|
assert_eq!((-9.0 as $fty).max(0.0), 0.0);
|
||||||
|
assert!((-9.0 as $fty).max(0.0).is_sign_positive());
|
||||||
|
assert_eq!((-9.0 as $fty).max(-0.0), -0.0);
|
||||||
|
assert!((-9.0 as $fty).max(-0.0).is_sign_negative());
|
||||||
assert_eq!((0.0 as $fty).max(9.0), 9.0);
|
assert_eq!((0.0 as $fty).max(9.0), 9.0);
|
||||||
|
assert_eq!((0.0 as $fty).max(-9.0), 0.0);
|
||||||
|
assert!((0.0 as $fty).max(-9.0).is_sign_positive());
|
||||||
assert_eq!((-0.0 as $fty).max(-9.0), -0.0);
|
assert_eq!((-0.0 as $fty).max(-9.0), -0.0);
|
||||||
|
assert!((-0.0 as $fty).max(-9.0).is_sign_negative());
|
||||||
assert_eq!(($inf as $fty).max(9.0), $inf);
|
assert_eq!(($inf as $fty).max(9.0), $inf);
|
||||||
assert_eq!((9.0 as $fty).max($inf), $inf);
|
assert_eq!((9.0 as $fty).max($inf), $inf);
|
||||||
assert_eq!(($inf as $fty).max(-9.0), $inf);
|
assert_eq!(($inf as $fty).max(-9.0), $inf);
|
||||||
|
|
Loading…
Reference in New Issue