diff --git a/src/libcollections/btree/set.rs b/src/libcollections/btree/set.rs index 812cff6fab7..6e048e0e83c 100644 --- a/src/libcollections/btree/set.rs +++ b/src/libcollections/btree/set.rs @@ -18,6 +18,8 @@ use core::cmp::Ordering::{self, Less, Greater, Equal}; use core::default::Default; use core::fmt::Show; use core::fmt; +// NOTE(stage0) remove import after a snapshot +#[cfg(stage0)] use core::hash::Hash; use core::iter::{Peekable, Map, FromIterator}; use core::ops::{BitOr, BitAnd, BitXor, Sub}; diff --git a/src/libstd/io/process.rs b/src/libstd/io/process.rs index a093e748d57..43ca7b13145 100644 --- a/src/libstd/io/process.rs +++ b/src/libstd/io/process.rs @@ -21,6 +21,8 @@ use prelude::v1::*; use collections::HashMap; use ffi::CString; use fmt; +// NOTE(stage0) remove import after a snapshot +#[cfg(stage0)] use hash::Hash; use io::pipe::{PipeStream, PipePair}; use io::{IoResult, IoError}; diff --git a/src/libsyntax/ext/deriving/hash.rs b/src/libsyntax/ext/deriving/hash.rs index db99c142443..98b7fae0341 100644 --- a/src/libsyntax/ext/deriving/hash.rs +++ b/src/libsyntax/ext/deriving/hash.rs @@ -65,9 +65,19 @@ fn hash_substructure(cx: &mut ExtCtxt, trait_span: Span, substr: &Substructure) [ref state_expr] => state_expr, _ => cx.span_bug(trait_span, "incorrect number of arguments in `deriving(Hash)`") }; - let hash_ident = substr.method_ident; + let hash_path = { + let strs = vec![ + cx.ident_of("std"), + cx.ident_of("hash"), + cx.ident_of("Hash"), + cx.ident_of("hash"), + ]; + + cx.expr_path(cx.path_global(trait_span, strs)) + }; let call_hash = |&: span, thing_expr| { - let expr = cx.expr_method_call(span, thing_expr, hash_ident, vec!(state_expr.clone())); + let ref_thing = cx.expr_addr_of(span, thing_expr); + let expr = cx.expr_call(span, hash_path.clone(), vec!(ref_thing, state_expr.clone())); cx.stmt_expr(expr) }; let mut stmts = Vec::new(); diff --git a/src/test/compile-fail/issue-21160.rs b/src/test/compile-fail/issue-21160.rs new file mode 100644 index 00000000000..30ed4f43940 --- /dev/null +++ b/src/test/compile-fail/issue-21160.rs @@ -0,0 +1,21 @@ +// Copyright 2015 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +struct Bar; + +impl Bar { + fn hash(&self, _: T) {} +} + +#[derive(Hash)] +//~^ error: the trait `core::hash::Hash<__S>` is not implemented for the type `Bar` +struct Foo(Bar); + +fn main() {}