Undo addition of boxes
I don't think the boxing helped performance, in fact I think it potentially made it worse. The data was still being copied, but now it was through a pointer. Thinking about it more, I think boxing might only help when you're passing a big object around by value all the time, rather than the slowdown being that you're cloning it.
This commit is contained in:
parent
c09d9d34f0
commit
5b74097975
|
@ -1,7 +1,6 @@
|
|||
use super::{plain_text_summary, short_markdown_summary};
|
||||
use super::{ErrorCodes, IdMap, Ignore, LangString, Markdown, MarkdownHtml};
|
||||
use rustc_span::edition::{Edition, DEFAULT_EDITION};
|
||||
use std::cell::RefCell;
|
||||
|
||||
#[test]
|
||||
fn test_unique_id() {
|
||||
|
|
|
@ -52,10 +52,10 @@ crate struct Context<'tcx> {
|
|||
/// publicly reused items to redirect to the right location.
|
||||
pub(super) render_redirect_pages: bool,
|
||||
/// The map used to ensure all generated 'id=' attributes are unique.
|
||||
pub(super) id_map: Box<RefCell<IdMap>>,
|
||||
pub(super) id_map: RefCell<IdMap>,
|
||||
/// Tracks section IDs for `Deref` targets so they match in both the main
|
||||
/// body and the sidebar.
|
||||
pub(super) deref_id_map: Box<RefCell<FxHashMap<DefId, String>>>,
|
||||
pub(super) deref_id_map: RefCell<FxHashMap<DefId, String>>,
|
||||
/// Shared mutable state.
|
||||
///
|
||||
/// Issue for improving the situation: [#82381][]
|
||||
|
@ -76,7 +76,7 @@ crate struct Context<'tcx> {
|
|||
|
||||
// `Context` is cloned a lot, so we don't want the size to grow unexpectedly.
|
||||
#[cfg(target_arch = "x86_64")]
|
||||
rustc_data_structures::static_assert_size!(Context<'_>, 88);
|
||||
rustc_data_structures::static_assert_size!(Context<'_>, 152);
|
||||
|
||||
impl<'tcx> Context<'tcx> {
|
||||
pub(super) fn path(&self, filename: &str) -> PathBuf {
|
||||
|
@ -415,8 +415,8 @@ impl<'tcx> FormatRenderer<'tcx> for Context<'tcx> {
|
|||
current: Vec::new(),
|
||||
dst,
|
||||
render_redirect_pages: false,
|
||||
id_map: Box::new(RefCell::new(id_map)),
|
||||
deref_id_map: Box::new(RefCell::new(FxHashMap::default())),
|
||||
id_map: RefCell::new(id_map),
|
||||
deref_id_map: RefCell::new(FxHashMap::default()),
|
||||
shared: Rc::new(scx),
|
||||
cache: Rc::new(cache),
|
||||
};
|
||||
|
@ -438,8 +438,8 @@ impl<'tcx> FormatRenderer<'tcx> for Context<'tcx> {
|
|||
current: self.current.clone(),
|
||||
dst: self.dst.clone(),
|
||||
render_redirect_pages: self.render_redirect_pages,
|
||||
id_map: Box::new(RefCell::new(id_map)),
|
||||
deref_id_map: Box::new(RefCell::new(FxHashMap::default())),
|
||||
id_map: RefCell::new(id_map),
|
||||
deref_id_map: RefCell::new(FxHashMap::default()),
|
||||
shared: Rc::clone(&self.shared),
|
||||
cache: Rc::clone(&self.cache),
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue