OpenE2K/rust
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

suggest: Put the use in suggested code inside the quotes

Browse Source 
Change import a trait suggestion from:

   help: candidate #1: use `std::io::Write`

to

   help: candidate #1: `use std::io::Write`

so that the code can be copied directly.
This commit is contained in:
Ulrik Sverdrup 2016-02-26 01:23:07 +01:00
parent 8842e28be8
commit 5db43169de
2 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/librustc_typeck/check/method/suggest.rs
View File

@ -271,7 +271,7 @@ fn suggest_traits_to_import<'a, 'tcx>(fcx: &FnCtxt<'a, 'tcx>,
for (i, trait_did) in candidates.iter().enumerate() { for (i, trait_did) in candidates.iter().enumerate() {
err.fileline_help(span, err.fileline_help(span,
&format!("candidate #{}: use `{}`", &format!("candidate #{}: `use {}`",
i + 1, i + 1,
fcx.tcx().item_path_str(*trait_did))); fcx.tcx().item_path_str(*trait_did)));
} }

16
src/test/compile-fail/no-method-suggested-traits.rs
View File

@ -34,31 +34,31 @@ fn main() {
1u32.method(); 1u32.method();
//~^ HELP following traits are implemented but not in scope, perhaps add a `use` for one of them //~^ HELP following traits are implemented but not in scope, perhaps add a `use` for one of them
//~^^ ERROR no method named //~^^ ERROR no method named
//~^^^ HELP `foo::Bar` //~^^^ HELP `use foo::Bar`
//~^^^^ HELP `no_method_suggested_traits::foo::PubPub` //~^^^^ HELP `use no_method_suggested_traits::foo::PubPub`
std::rc::Rc::new(&mut Box::new(&1u32)).method(); std::rc::Rc::new(&mut Box::new(&1u32)).method();
//~^ HELP following traits are implemented but not in scope, perhaps add a `use` for one of them //~^ HELP following traits are implemented but not in scope, perhaps add a `use` for one of them
//~^^ ERROR no method named //~^^ ERROR no method named
//~^^^ HELP `foo::Bar` //~^^^ HELP `use foo::Bar`
//~^^^^ HELP `no_method_suggested_traits::foo::PubPub` //~^^^^ HELP `use no_method_suggested_traits::foo::PubPub`
'a'.method(); 'a'.method();
//~^ ERROR no method named //~^ ERROR no method named
//~^^ HELP the following trait is implemented but not in scope, perhaps add a `use` for it: //~^^ HELP the following trait is implemented but not in scope, perhaps add a `use` for it:
//~^^^ HELP `foo::Bar` //~^^^ HELP `use foo::Bar`
std::rc::Rc::new(&mut Box::new(&'a')).method(); std::rc::Rc::new(&mut Box::new(&'a')).method();
//~^ ERROR no method named //~^ ERROR no method named
//~^^ HELP the following trait is implemented but not in scope, perhaps add a `use` for it: //~^^ HELP the following trait is implemented but not in scope, perhaps add a `use` for it:
//~^^^ HELP `foo::Bar` //~^^^ HELP `use foo::Bar`
1i32.method(); 1i32.method();
//~^ ERROR no method named //~^ ERROR no method named
//~^^ HELP the following trait is implemented but not in scope, perhaps add a `use` for it: //~^^ HELP the following trait is implemented but not in scope, perhaps add a `use` for it:
//~^^^ HELP `no_method_suggested_traits::foo::PubPub` //~^^^ HELP `use no_method_suggested_traits::foo::PubPub`
std::rc::Rc::new(&mut Box::new(&1i32)).method(); std::rc::Rc::new(&mut Box::new(&1i32)).method();
//~^ ERROR no method named //~^ ERROR no method named
//~^^ HELP the following trait is implemented but not in scope, perhaps add a `use` for it: //~^^ HELP the following trait is implemented but not in scope, perhaps add a `use` for it:
//~^^^ HELP `no_method_suggested_traits::foo::PubPub` //~^^^ HELP `use no_method_suggested_traits::foo::PubPub`
Foo.method(); Foo.method();
//~^ ERROR no method named //~^ ERROR no method named