OpenE2K
/
rust
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Issue 4391: rustc should not silently skip tests with erroneous signature.

This commit is contained in:
Felix S. Klock II 2013-04-29 16:25:40 +02:00
parent b42ea7f9ef
commit 5f1a90ebe7
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/librustc/front/test.rs
View File

@ -141,7 +141,7 @@ fn fold_item(cx: @mut TestCtxt, i: @ast::item, fld: @fold::ast_fold)
debug!("current path: %s",
ast_util::path_name_i(copy cx.path, cx.sess.parse_sess.interner));
if is_test_fn(i) || is_bench_fn(i) {
if is_test_fn(cx, i) || is_bench_fn(i) {
match i.node {
ast::item_fn(_, purity, _, _, _) if purity == ast::unsafe_fn => {
let sess = cx.sess;
@ -169,7 +169,7 @@ fn fold_item(cx: @mut TestCtxt, i: @ast::item, fld: @fold::ast_fold)
return res;
}
fn is_test_fn(i: @ast::item) -> bool {
fn is_test_fn(cx: @mut TestCtxt, i: @ast::item) -> bool {
let has_test_attr = !attr::find_attrs_by_name(i.attrs,
~"test").is_empty();
@ -188,6 +188,13 @@ fn is_test_fn(i: @ast::item) -> bool {
}
}
if has_test_attr && !has_test_signature(i) {
let sess = cx.sess;
sess.span_fatal(
i.span,
~"functions used as tests must have signature fn() -> ()."
);
}
return has_test_attr && has_test_signature(i);
}