From f9269a1bda7a8e128ce52327df35cd645332a77e Mon Sep 17 00:00:00 2001 From: Tim Chevalier Date: Thu, 28 Feb 2013 18:30:58 -0800 Subject: [PATCH] rustc: One Less Bad Copy --- src/librust/rust.rc | 4 ++-- src/librustc/middle/trans/base.rs | 7 +++---- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/librust/rust.rc b/src/librust/rust.rc index 082861e0ae0..8fd9fea6bae 100644 --- a/src/librust/rust.rc +++ b/src/librust/rust.rc @@ -9,8 +9,8 @@ // except according to those terms. // rust - central access to other rust tools -// XXX: Make commands run and test emit proper file endings on winds -// XXX: Make run only accept source that emits an executable +// FIXME #2238 Make commands run and test emit proper file endings on winds +// FIXME #2238 Make run only accept source that emits an executable #[deny(deprecated_self)]; diff --git a/src/librustc/middle/trans/base.rs b/src/librustc/middle/trans/base.rs index d4ed0004c8f..4689fbb2d0b 100644 --- a/src/librustc/middle/trans/base.rs +++ b/src/librustc/middle/trans/base.rs @@ -867,7 +867,7 @@ pub fn in_lpad_scope_cx(bcx: block, f: &fn(+si: &mut scope_info)) { let mut bcx = bcx; loop { { - // XXX: Borrow check bug workaround. + // FIXME #4280: Borrow check bug workaround. let kind: &mut block_kind = &mut *bcx.kind; match *kind { block_scope(ref mut inf) => { @@ -1272,7 +1272,7 @@ pub fn cleanup_and_leave(bcx: block, } { - // XXX: Borrow check bug workaround. + // FIXME #4280: Borrow check bug workaround. let kind: &mut block_kind = &mut *cur.kind; match *kind { block_scope(ref mut inf) if !inf.cleanups.is_empty() => { @@ -1850,8 +1850,7 @@ pub fn trans_enum_variant(ccx: @CrateContext, }; let fcx = new_fn_ctxt_w_id(ccx, ~[], llfndecl, variant.node.id, None, param_substs, None); - // XXX: Bad copy. - let raw_llargs = create_llargs_for_fn_args(fcx, no_self, copy fn_args); + let raw_llargs = create_llargs_for_fn_args(fcx, no_self, fn_args); let ty_param_substs = match param_substs { Some(ref substs) => /*bad*/copy substs.tys, None => ~[]