Rollup merge of #69896 - petrochenkov:reqname2, r=Centril

parse: Tweak the function parameter edition check

Follow-up to https://github.com/rust-lang/rust/pull/69801.

Edition of a code fragment is inferred from "the place where the code is written".
For individual tokens like edition-specific keywords it may be the span of the token itself ("uninterpolated" span), but for larger code fragments it's probably not, in the test example the trait method is obviously written in "2015 edition code".

r? @Centril
This commit is contained in:
Mazdak Farrokhzad 2020-03-11 10:36:33 +01:00 committed by GitHub
commit 6a8683fcd0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
8 changed files with 23 additions and 3 deletions

View File

@ -1544,9 +1544,7 @@ impl<'a> Parser<'a> {
let is_name_required = match self.token.kind { let is_name_required = match self.token.kind {
token::DotDotDot => false, token::DotDotDot => false,
// FIXME: Consider using interpolated token for this edition check, _ => req_name(self.token.span.edition()),
// it should match the intent of edition hygiene better.
_ => req_name(self.token.uninterpolate().span.edition()),
}; };
let (pat, ty) = if is_name_required || self.is_named_param() { let (pat, ty) = if is_name_required || self.is_named_param() {
debug!("parse_param_general parse_pat (is_name_required:{})", is_name_required); debug!("parse_param_general parse_pat (is_name_required:{})", is_name_required);

View File

@ -0,0 +1,10 @@
// check-pass
// edition:2018
// aux-build:anon-params-edition-hygiene.rs
#[macro_use]
extern crate anon_params_edition_hygiene;
generate_trait_2015!(u8);
fn main() {}

View File

@ -0,0 +1,12 @@
// edition:2015
#[macro_export]
macro_rules! generate_trait_2015 {
($Type: ident) => {
trait Trait {
fn method($Type) {}
}
};
}
fn main() {}