Merge pull request #1445 from sinkuu/fix_closure_return

Use closure body span for needless_return lint (fixes #1405)

clippy_lints/src/returns.rs

@@ -138,7 +138,7 @@ impl EarlyLintPass for ReturnPass {
         match kind {
             FnKind::ItemFn(.., block) |
             FnKind::Method(.., block) => self.check_block_return(cx, block),
-            FnKind::Closure(body) => self.check_final_expr(cx, body, None),
+            FnKind::Closure(body) => self.check_final_expr(cx, body, Some(body.span)),
         }
     }
 

tests/compile-fail/needless_return.rs

@@ -58,6 +58,10 @@ fn test_closure() {
         //~| HELP remove `return` as shown
         //~| SUGGESTION true
     };
+    let _ = || return true;
+    //~^ ERROR unneeded return statement
+    //~| HELP remove `return` as shown
+    //~| SUGGESTION true
 }
 
 fn main() {