OpenE2K/rust
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Explicitly impl Clone for RWArc

Browse Source 
RWArc had a clone() method, but it was part of impl RWArc instead of
an implementation of Clone.

Stick with the explicit implementation instead of deriving Clone so we
can have a docstring.

Fixes #8052.
This commit is contained in:
Kevin Ballard 2013-08-01 15:02:03 -07:00 committed by Daniel Micay
parent 1992765dd3
commit 75155cd1b0
1 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/libextra/arc.rs
View File

@ -140,14 +140,14 @@ impl<T:Freeze+Send> Arc<T> {
} }
} }
/**
* Duplicate an atomically reference counted wrapper.
*
* The resulting two `arc` objects will point to the same underlying data
* object. However, one of the `arc` objects can be sent to another task,
* allowing them to share the underlying data.
*/
impl<T:Freeze + Send> Clone for Arc<T> { impl<T:Freeze + Send> Clone for Arc<T> {
/**
* Duplicate an atomically reference counted wrapper.
*
* The resulting two `arc` objects will point to the same underlying data
* object. However, one of the `arc` objects can be sent to another task,
* allowing them to share the underlying data.
*/
fn clone(&self) -> Arc<T> { fn clone(&self) -> Arc<T> {
Arc { x: self.x.clone() } Arc { x: self.x.clone() }
} }
@ -164,7 +164,7 @@ struct MutexArc<T> { priv x: UnsafeAtomicRcBox<MutexArcInner<T>> }
impl<T:Send> Clone for MutexArc<T> { impl<T:Send> Clone for MutexArc<T> {
/// Duplicate a mutex-protected Arc, as arc::clone. /// Duplicate a mutex-protected Arc. See arc::clone for more details.
fn clone(&self) -> MutexArc<T> { fn clone(&self) -> MutexArc<T> {
// NB: Cloning the underlying mutex is not necessary. Its reference // NB: Cloning the underlying mutex is not necessary. Its reference
// count would be exactly the same as the shared state's. // count would be exactly the same as the shared state's.
@ -312,12 +312,10 @@ struct RWArc<T> {
priv x: UnsafeAtomicRcBox<RWArcInner<T>>, priv x: UnsafeAtomicRcBox<RWArcInner<T>>,
} }
impl<T:Freeze + Send> RWArc<T> { impl<T:Freeze + Send> Clone for RWArc<T> {
/// Duplicate a rwlock-protected Arc, as arc::clone. /// Duplicate a rwlock-protected Arc. See arc::clone for more details.
pub fn clone(&self) -> RWArc<T> { fn clone(&self) -> RWArc<T> {
RWArc { RWArc { x: self.x.clone() }
x: self.x.clone(),
}
} }
} }