suggest on new snippet
This commit is contained in:
parent
88f475c808
commit
790c09e849
@ -12,15 +12,16 @@ use syntax::ast;
|
||||
use syntax::ext::base;
|
||||
use syntax::ext::build::AstBuilder;
|
||||
use syntax::symbol::Symbol;
|
||||
use syntax_pos;
|
||||
use syntax::tokenstream;
|
||||
use syntax_pos;
|
||||
|
||||
use std::string::String;
|
||||
|
||||
pub fn expand_syntax_ext(cx: &mut base::ExtCtxt,
|
||||
pub fn expand_syntax_ext(
|
||||
cx: &mut base::ExtCtxt,
|
||||
sp: syntax_pos::Span,
|
||||
tts: &[tokenstream::TokenTree])
|
||||
-> Box<base::MacResult + 'static> {
|
||||
tts: &[tokenstream::TokenTree],
|
||||
) -> Box<base::MacResult + 'static> {
|
||||
let es = match base::get_exprs_from_tts(cx, sp, tts) {
|
||||
Some(e) => e,
|
||||
None => return base::DummyResult::expr(sp),
|
||||
@ -28,35 +29,34 @@ pub fn expand_syntax_ext(cx: &mut base::ExtCtxt,
|
||||
let mut accumulator = String::new();
|
||||
for e in es {
|
||||
match e.node {
|
||||
ast::ExprKind::Lit(ref lit) => {
|
||||
match lit.node {
|
||||
ast::LitKind::Str(ref s, _) |
|
||||
ast::LitKind::Float(ref s, _) |
|
||||
ast::LitKind::FloatUnsuffixed(ref s) => {
|
||||
ast::ExprKind::Lit(ref lit) => match lit.node {
|
||||
ast::LitKind::Str(ref s, _)
|
||||
| ast::LitKind::Float(ref s, _)
|
||||
| ast::LitKind::FloatUnsuffixed(ref s) => {
|
||||
accumulator.push_str(&s.as_str());
|
||||
}
|
||||
ast::LitKind::Char(c) => {
|
||||
accumulator.push(c);
|
||||
}
|
||||
ast::LitKind::Int(i, ast::LitIntType::Unsigned(_)) |
|
||||
ast::LitKind::Int(i, ast::LitIntType::Signed(_)) |
|
||||
ast::LitKind::Int(i, ast::LitIntType::Unsuffixed) => {
|
||||
ast::LitKind::Int(i, ast::LitIntType::Unsigned(_))
|
||||
| ast::LitKind::Int(i, ast::LitIntType::Signed(_))
|
||||
| ast::LitKind::Int(i, ast::LitIntType::Unsuffixed) => {
|
||||
accumulator.push_str(&format!("{}", i));
|
||||
}
|
||||
ast::LitKind::Bool(b) => {
|
||||
accumulator.push_str(&format!("{}", b));
|
||||
}
|
||||
ast::LitKind::Byte(..) |
|
||||
ast::LitKind::ByteStr(..) => {
|
||||
ast::LitKind::Byte(..) | ast::LitKind::ByteStr(..) => {
|
||||
cx.span_err(e.span, "cannot concatenate a byte string literal");
|
||||
}
|
||||
}
|
||||
}
|
||||
},
|
||||
_ => {
|
||||
let mut err = cx.struct_span_err(e.span, "expected a literal");
|
||||
err.span_help(
|
||||
let snippet = cx.codemap().span_to_snippet(e.span).unwrap();
|
||||
err.span_suggestion(
|
||||
e.span,
|
||||
"you might be missing a string literal to format with",
|
||||
format!("\"{{}}\", {}", snippet),
|
||||
);
|
||||
err.emit();
|
||||
}
|
||||
|
@ -3,12 +3,10 @@ error: expected a literal
|
||||
|
|
||||
LL | println!(3 + 4); //~ ERROR expected a literal
|
||||
| ^^^^^
|
||||
|
|
||||
help: you might be missing a string literal to format with
|
||||
--> $DIR/bad_hello.rs:12:14
|
||||
|
|
||||
LL | println!(3 + 4); //~ ERROR expected a literal
|
||||
| ^^^^^
|
||||
LL | println!("{}", 3 + 4); //~ ERROR expected a literal
|
||||
| ^^^^^^^^^^^
|
||||
|
||||
error: aborting due to previous error
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user