From bb0a719434490a0805cdbbfe52ba8b47bc5ec211 Mon Sep 17 00:00:00 2001 From: Brian Koropoff Date: Thu, 6 Nov 2014 19:31:56 -0800 Subject: [PATCH 1/2] Fix panic due to overly long borrow of RefCell Closes #18711 --- src/librustc/middle/trans/closure.rs | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/librustc/middle/trans/closure.rs b/src/librustc/middle/trans/closure.rs index 16db4daba46..8c73baf2b67 100644 --- a/src/librustc/middle/trans/closure.rs +++ b/src/librustc/middle/trans/closure.rs @@ -482,10 +482,9 @@ pub fn trans_unboxed_closure<'blk, 'tcx>( bcx, closure_id).unwrap(); - let unboxed_closures = bcx.tcx().unboxed_closures.borrow(); - let function_type = (*unboxed_closures)[closure_id] - .closure_type - .clone(); + let function_type = (*bcx.tcx().unboxed_closures.borrow())[closure_id] + .closure_type + .clone(); let function_type = ty::mk_closure(bcx.tcx(), function_type); let freevars: Vec = From 5f6392d84893bf5bbc5c44c247e3d4a983c17b7c Mon Sep 17 00:00:00 2001 From: Brian Koropoff Date: Thu, 6 Nov 2014 19:33:47 -0800 Subject: [PATCH 2/2] Add regression test for #18711 --- src/test/auxiliary/issue-18711.rs | 16 ++++++++++++++++ src/test/run-pass/issue-18711.rs | 21 +++++++++++++++++++++ 2 files changed, 37 insertions(+) create mode 100644 src/test/auxiliary/issue-18711.rs create mode 100644 src/test/run-pass/issue-18711.rs diff --git a/src/test/auxiliary/issue-18711.rs b/src/test/auxiliary/issue-18711.rs new file mode 100644 index 00000000000..454e67b8bd5 --- /dev/null +++ b/src/test/auxiliary/issue-18711.rs @@ -0,0 +1,16 @@ +// Copyright 2014 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +#![feature(unboxed_closures, overloaded_calls)] +#![crate_type = "rlib"] + +pub fn inner(f: F) -> F { + (move |:| f)() +} diff --git a/src/test/run-pass/issue-18711.rs b/src/test/run-pass/issue-18711.rs new file mode 100644 index 00000000000..2d16aa7f0c3 --- /dev/null +++ b/src/test/run-pass/issue-18711.rs @@ -0,0 +1,21 @@ +// Copyright 2014 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +// Test that we don't panic on a RefCell borrow conflict in certain +// code paths involving unboxed closures. + +#![feature(unboxed_closures, overloaded_calls)] + +// aux-build:issue-18711.rs +extern crate "issue-18711" as issue; + +fn main() { + (|:| issue::inner(()))(); +}