From 7e446af759e86e77a5f4a8e9bc6d6c22072b25ae Mon Sep 17 00:00:00 2001 From: Huon Wilson Date: Tue, 7 Jan 2014 01:45:10 +1100 Subject: [PATCH] std::trie: make lower_bound and upper_bound about 15% faster. I believe this is mainly due to code-size reduction. Before: test [...]::bench_lower_bound ... bench: 818 ns/iter (+/- 100) test [...]::bench_upper_bound ... bench: 939 ns/iter (+/- 34) After: test [...]::bench_lower_bound ... bench: 698 ns/iter (+/- 60) test [...]::bench_upper_bound ... bench: 817 ns/iter (+/- 20) --- src/libstd/trie.rs | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/src/libstd/trie.rs b/src/libstd/trie.rs index 94b7b881ea0..d864cde2953 100644 --- a/src/libstd/trie.rs +++ b/src/libstd/trie.rs @@ -198,24 +198,24 @@ macro_rules! bound { addr!(loop { let children = unsafe {addr!(& $($mut_)* (*node).children)}; let child_id = chunk(key, idx); - match children[child_id] { + let (slice_idx, ret) = match children[child_id] { Internal(ref $($mut_)* n) => { node = addr!(& $($mut_)* **n as * $($mut_)* TrieNode); + (child_id + 1, false) } External(stored, _) => { - if stored < key || ($upper && stored == key) { - it.stack.push(children.$slice_from(child_id + 1).$iter()); + (if stored < key || ($upper && stored == key) { + child_id + 1 } else { - it.stack.push(children.$slice_from(child_id).$iter()); - } - return it; + child_id + }, true) } Nothing => { - it.stack.push(children.$slice_from(child_id + 1).$iter()); - return it + (child_id + 1, true) } - } - it.stack.push(children.$slice_from(child_id + 1).$iter()); + }; + it.stack.push(children.$slice_from(slice_idx).$iter()); + if ret { return it } idx += 1; }) }