OpenE2K/rust
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix some clippy issues

Browse Source 
Found while working on https://github.com/rust-lang/rust/pull/77351;
these are just the ones that could be fixed automatically.
This commit is contained in:
Joshua Nelson 2020-10-01 01:23:08 -04:00
parent 9e34b72964
commit 8164218181
5 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
library/test/src/bench.rs
View File

@ -159,7 +159,7 @@ where
return summ5; return summ5;
} }
total_run = total_run + loop_run; total_run += loop_run;
// Longest we ever run for is 3s. // Longest we ever run for is 3s.
if total_run > Duration::from_secs(3) { if total_run > Duration::from_secs(3) {
return summ5; return summ5;

2
library/test/src/formatters/pretty.rs
View File

@ -139,7 +139,7 @@ impl<T: Write> PrettyFormatter<T> {
stdouts.push_str(&format!("---- {} stdout ----\n", f.name)); stdouts.push_str(&format!("---- {} stdout ----\n", f.name));
let output = String::from_utf8_lossy(stdout); let output = String::from_utf8_lossy(stdout);
stdouts.push_str(&output); stdouts.push_str(&output);
stdouts.push_str("\n"); stdouts.push('\n');
} }
} }
if !stdouts.is_empty() { if !stdouts.is_empty() {

4
library/test/src/formatters/terse.rs
View File

@ -114,7 +114,7 @@ impl<T: Write> TerseFormatter<T> {
stdouts.push_str(&format!("---- {} stdout ----\n", f.name)); stdouts.push_str(&format!("---- {} stdout ----\n", f.name));
let output = String::from_utf8_lossy(stdout); let output = String::from_utf8_lossy(stdout);
stdouts.push_str(&output); stdouts.push_str(&output);
stdouts.push_str("\n"); stdouts.push('\n');
} }
} }
if !stdouts.is_empty() { if !stdouts.is_empty() {
@ -140,7 +140,7 @@ impl<T: Write> TerseFormatter<T> {
fail_out.push_str(&format!("---- {} stdout ----\n", f.name)); fail_out.push_str(&format!("---- {} stdout ----\n", f.name));
let output = String::from_utf8_lossy(stdout); let output = String::from_utf8_lossy(stdout);
fail_out.push_str(&output); fail_out.push_str(&output);
fail_out.push_str("\n"); fail_out.push('\n');
} }
} }
if !fail_out.is_empty() { if !fail_out.is_empty() {

8
library/test/src/lib.rs
View File

@ -237,11 +237,9 @@ where
let event = TestEvent::TeFiltered(filtered_descs); let event = TestEvent::TeFiltered(filtered_descs);
notify_about_test_event(event)?; notify_about_test_event(event)?;
let (filtered_tests, filtered_benchs): (Vec<_>, _) = let (filtered_tests, filtered_benchs): (Vec<_>, _) = filtered_tests
filtered_tests.into_iter().partition(|e| match e.testfn { .into_iter()
StaticTestFn(_) | DynTestFn(_) => true, .partition(|e| matches!(e.testfn, StaticTestFn(_) | DynTestFn(_)));
_ => false,
});
let concurrency = opts.test_threads.unwrap_or_else(get_concurrency); let concurrency = opts.test_threads.unwrap_or_else(get_concurrency);

2
library/test/src/stats.rs
View File

@ -199,7 +199,7 @@ impl Stats for [f64] {
let mut v: f64 = 0.0; let mut v: f64 = 0.0;
for s in self { for s in self {
let x = *s - mean; let x = *s - mean;
v = v + x * x; v += x * x;
} }
// N.B., this is _supposed to be_ len-1, not len. If you // N.B., this is _supposed to be_ len-1, not len. If you
// change it back to len, you will be calculating a // change it back to len, you will be calculating a