OpenE2K/rust
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add a tidy check for leading trailing newlines

Browse Source
This commit is contained in:
varkor 2019-04-22 15:49:51 +01:00
parent c21fbfe7e3
commit 8423e00714
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/tools/tidy/src/style.rs
View File

@ -112,6 +112,7 @@ pub fn check(path: &Path, bad: &mut bool) {
let skip_length = contents.contains("ignore-tidy-linelength"); let skip_length = contents.contains("ignore-tidy-linelength");
let skip_end_whitespace = contents.contains("ignore-tidy-end-whitespace"); let skip_end_whitespace = contents.contains("ignore-tidy-end-whitespace");
let skip_copyright = contents.contains("ignore-tidy-copyright"); let skip_copyright = contents.contains("ignore-tidy-copyright");
let mut leading_new_lines = false;
let mut trailing_new_lines = 0; let mut trailing_new_lines = 0;
for (i, line) in contents.split('\n').enumerate() { for (i, line) in contents.split('\n').enumerate() {
let mut err = |msg: &str| { let mut err = |msg: &str| {
@ -152,11 +153,17 @@ pub fn check(path: &Path, bad: &mut bool) {
err(LLVM_UNREACHABLE_INFO); err(LLVM_UNREACHABLE_INFO);
} }
if line.is_empty() { if line.is_empty() {
if i == 0 {
leading_new_lines = true;
}
trailing_new_lines += 1; trailing_new_lines += 1;
} else { } else {
trailing_new_lines = 0; trailing_new_lines = 0;
} }
} }
if leading_new_lines {
tidy_error!(bad, "{}: leading newline", file.display());
}
match trailing_new_lines { match trailing_new_lines {
0 => tidy_error!(bad, "{}: missing trailing newline", file.display()), 0 => tidy_error!(bad, "{}: missing trailing newline", file.display()),
1 | 2 => {} 1 | 2 => {}