From 8e8f8d9a5a35eb5875999efac7837956ed1b20da Mon Sep 17 00:00:00 2001 From: inrustwetrust Date: Sun, 10 May 2015 00:07:26 +0200 Subject: [PATCH] Upgraded warning for invalid crate_type attribute syntax to an error If the user intended to set the crate_type to "lib" but accidentally used incorrect syntax such as `#![crate_type(lib)]`, the compilation would fail with "main function not found". This made it hard to locate the source of the problem, since the failure would cause the warning about the incorrect attribute not to be shown. --- src/librustc_driver/driver.rs | 7 ++----- src/test/compile-fail/invalid_crate_type_syntax.rs | 14 ++++++++++++++ 2 files changed, 16 insertions(+), 5 deletions(-) create mode 100644 src/test/compile-fail/invalid_crate_type_syntax.rs diff --git a/src/librustc_driver/driver.rs b/src/librustc_driver/driver.rs index 154e0a1f644..a956b173f96 100644 --- a/src/librustc_driver/driver.rs +++ b/src/librustc_driver/driver.rs @@ -871,11 +871,8 @@ pub fn collect_crate_types(session: &Session, None } _ => { - session.add_lint(lint::builtin::UNKNOWN_CRATE_TYPES, - ast::CRATE_NODE_ID, - a.span, - "`crate_type` requires a \ - value".to_string()); + session.span_err(a.span, "`crate_type` requires a value"); + session.note("for example: `#![crate_type=\"lib\"]`"); None } } diff --git a/src/test/compile-fail/invalid_crate_type_syntax.rs b/src/test/compile-fail/invalid_crate_type_syntax.rs new file mode 100644 index 00000000000..6d42515704e --- /dev/null +++ b/src/test/compile-fail/invalid_crate_type_syntax.rs @@ -0,0 +1,14 @@ +// Copyright 2015 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +// regression test for issue 16974 +#![crate_type(lib)] //~ ERROR `crate_type` requires a value + +fn my_lib_fn() {}