From 035f651df77056d7d698e5ed47eb4b85d775fafa Mon Sep 17 00:00:00 2001 From: Nikolai Vazquez Date: Fri, 24 May 2019 22:26:34 +0200 Subject: [PATCH] Annotate each `reverse_bits` with `#[must_use]` Because the name sounds like an in-place mutation like `[T]::reverse(&mut self)`, it may be confused for one. --- src/libcore/num/mod.rs | 2 ++ src/libcore/num/wrapping.rs | 1 + 2 files changed, 3 insertions(+) diff --git a/src/libcore/num/mod.rs b/src/libcore/num/mod.rs index 562a7a4b3c7..0d776c9842d 100644 --- a/src/libcore/num/mod.rs +++ b/src/libcore/num/mod.rs @@ -472,6 +472,7 @@ assert_eq!(m, ", $reversed, "); #[unstable(feature = "reverse_bits", issue = "48763")] #[rustc_const_unstable(feature = "const_int_conversion")] #[inline] + #[must_use] pub const fn reverse_bits(self) -> Self { (self as $UnsignedT).reverse_bits() as Self } @@ -2521,6 +2522,7 @@ assert_eq!(m, ", $reversed, "); ```"), #[unstable(feature = "reverse_bits", issue = "48763")] #[inline] + #[must_use] pub const fn reverse_bits(self) -> Self { intrinsics::bitreverse(self as $ActualT) as Self } diff --git a/src/libcore/num/wrapping.rs b/src/libcore/num/wrapping.rs index a3491bc3dc6..5eb5ec558f8 100644 --- a/src/libcore/num/wrapping.rs +++ b/src/libcore/num/wrapping.rs @@ -524,6 +524,7 @@ assert_eq!(n.trailing_zeros(), 3); /// ``` #[unstable(feature = "reverse_bits", issue = "48763")] #[inline] + #[must_use] pub const fn reverse_bits(self) -> Self { Wrapping(self.0.reverse_bits()) }