From 98dbce4fe4a6f63a4d1f9e2fdd6b2752ed097af4 Mon Sep 17 00:00:00 2001 From: Michael Wright Date: Wed, 1 Aug 2018 06:32:36 +0200 Subject: [PATCH] Fix E0502 warnings Fixes #2982 --- clippy_lints/src/lib.rs | 4 +++- clippy_lints/src/utils/hir_utils.rs | 6 ++++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/clippy_lints/src/lib.rs b/clippy_lints/src/lib.rs index b08449d2beb..4a23de3b8fd 100644 --- a/clippy_lints/src/lib.rs +++ b/clippy_lints/src/lib.rs @@ -366,9 +366,11 @@ pub fn register_plugins(reg: &mut rustc_plugin::Registry<'_>) { reg.register_late_lint_pass(box large_enum_variant::LargeEnumVariant::new(conf.enum_variant_size_threshold)); reg.register_late_lint_pass(box explicit_write::Pass); reg.register_late_lint_pass(box needless_pass_by_value::NeedlessPassByValue); + + let target = ®.sess.target; reg.register_late_lint_pass(box trivially_copy_pass_by_ref::TriviallyCopyPassByRef::new( conf.trivial_copy_size_limit, - ®.sess.target, + target, )); reg.register_early_lint_pass(box literal_representation::LiteralDigitGrouping); reg.register_early_lint_pass(box literal_representation::LiteralRepresentation::new( diff --git a/clippy_lints/src/utils/hir_utils.rs b/clippy_lints/src/utils/hir_utils.rs index 2c5995f1327..57486b30d34 100644 --- a/clippy_lints/src/utils/hir_utils.rs +++ b/clippy_lints/src/utils/hir_utils.rs @@ -448,7 +448,8 @@ impl<'a, 'tcx: 'a> SpanlessHash<'a, 'tcx> { CaptureClause::CaptureByValue => 0, CaptureClause::CaptureByRef => 1, }.hash(&mut self.s); - self.hash_expr(&self.cx.tcx.hir.body(eid).value); + let value = &self.cx.tcx.hir.body(eid).value; + self.hash_expr(value); }, ExprKind::Field(ref e, ref f) => { let c: fn(_, _) -> _ = ExprKind::Field; @@ -515,7 +516,8 @@ impl<'a, 'tcx: 'a> SpanlessHash<'a, 'tcx> { self.hash_expr(e); let full_table = self.tables; self.tables = self.cx.tcx.body_tables(l_id.body); - self.hash_expr(&self.cx.tcx.hir.body(l_id.body).value); + let value = &self.cx.tcx.hir.body(l_id.body).value; + self.hash_expr(value); self.tables = full_table; }, ExprKind::Ret(ref e) => {