OpenE2K/rust
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

grammar

Browse Source
This commit is contained in:
Andre Bogus 2015-08-12 21:17:21 +02:00 committed by llogiq
parent 9e786d3956
commit a00270c5b1
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/strings.rs
View File

@ -13,14 +13,14 @@ use utils::{match_def_path, span_lint, walk_ptrs_ty, get_parent_expr};
declare_lint! { declare_lint! {
pub STRING_ADD_ASSIGN, pub STRING_ADD_ASSIGN,
Warn, Allow,
"Warn on `x = x + ..` where x is a `String`" "expressions of the form `x = x + ..` where x is a `String`"
} }
declare_lint! { declare_lint! {
pub STRING_ADD, pub STRING_ADD,
Allow, Allow,
"Warn on `x + ..` where x is a `String`" "expressions of the form on `x + ..` where x is a `String`"
} }
#[derive(Copy, Clone)] #[derive(Copy, Clone)]
@ -47,14 +47,14 @@ impl LintPass for StringAdd {
} }
//TODO check for duplicates //TODO check for duplicates
span_lint(cx, STRING_ADD, e.span, span_lint(cx, STRING_ADD, e.span,
"you add something to a string. \ "you added something to a string. \
Consider using `String::push_str()` instead.") Consider using `String::push_str()` instead.")
} }
} else if let &ExprAssign(ref target, ref src) = &e.node { } else if let &ExprAssign(ref target, ref src) = &e.node {
if is_string(cx, target) && is_add(src, target) { if is_string(cx, target) && is_add(src, target) {
span_lint(cx, STRING_ADD_ASSIGN, e.span, span_lint(cx, STRING_ADD_ASSIGN, e.span,
"you assign the result of adding something to this string. \ "you assigned the result of adding something to this string. \
Consider using `String::push_str()` instead") Consider using `String::push_str()` instead.")
} }
} }
} }