From 28f4f65d0c1aa7b21c752ad9625dc9cc61a90da7 Mon Sep 17 00:00:00 2001 From: Alex Crichton Date: Sat, 26 Oct 2013 23:31:14 -0700 Subject: [PATCH 1/2] Fix a typo in a rt::io::signal test It was pretty much a miracle that these tests were ever passing. They would never have passed in the single threaded case because only one sigint in the tests is ever generated, but when run in parallel two sigints will be generated. --- src/libstd/rt/io/signal.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libstd/rt/io/signal.rs b/src/libstd/rt/io/signal.rs index a13fc19d000..d2266c8d5d6 100644 --- a/src/libstd/rt/io/signal.rs +++ b/src/libstd/rt/io/signal.rs @@ -183,7 +183,7 @@ mod test { Interrupt => (), s => fail!("Expected Interrupt, got {:?}", s), } - match s1.port.recv() { + match s2.port.recv() { Interrupt => (), s => fail!("Expected Interrupt, got {:?}", s), } From 8455ad898cc20106251ddbff61e874abfcf95cbb Mon Sep 17 00:00:00 2001 From: Alex Crichton Date: Sun, 27 Oct 2013 10:58:32 -0700 Subject: [PATCH 2/2] Ignore a test which never completes on windows I'm not entirely sure why this is happening, but the server task is never seeing the second send of the client task, and this test will very reliably fail to complete on windows. --- src/libstd/rt/uv/uvio.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/libstd/rt/uv/uvio.rs b/src/libstd/rt/uv/uvio.rs index dc202ecc174..e0707a86f7b 100644 --- a/src/libstd/rt/uv/uvio.rs +++ b/src/libstd/rt/uv/uvio.rs @@ -2306,6 +2306,7 @@ fn test_read_read_read() { } #[test] +#[ignore(cfg(windows))] // FIXME(#10102) the server never sees the second send fn test_udp_twice() { do run_in_mt_newsched_task { let server_addr = next_test_ip4();