Oliver Schneider
GitHub
commit
a7c049df28
@ -1,689 +0,0 @@
|
||||
#![feature(plugin)]
|
||||
#![feature(const_fn)]
|
||||
#![plugin(clippy)]
|
||||
|
||||
#![deny(clippy, clippy_pedantic)]
|
||||
#![allow(blacklisted_name, unused, print_stdout, non_ascii_literal, new_without_default, new_without_default_derive, missing_docs_in_private_items)]
|
||||
|
||||
use std::collections::BTreeMap;
|
||||
use std::collections::HashMap;
|
||||
use std::collections::HashSet;
|
||||
use std::collections::VecDeque;
|
||||
use std::ops::Mul;
|
||||
use std::iter::FromIterator;
|
||||
|
||||
struct T;
|
||||
|
||||
impl T {
|
||||
fn add(self, other: T) -> T { self }
|
||||
fn drop(&mut self) { }
|
||||
|
||||
fn sub(&self, other: T) -> &T { self } // no error, self is a ref
|
||||
fn div(self) -> T { self } // no error, different #arguments
|
||||
fn rem(self, other: T) { } // no error, wrong return type
|
||||
|
||||
fn into_u32(self) -> u32 { 0 } // fine
|
||||
fn into_u16(&self) -> u16 { 0 }
|
||||
|
||||
fn to_something(self) -> u32 { 0 }
|
||||
|
||||
fn new(self) {}
|
||||
}
|
||||
|
||||
struct Lt<'a> {
|
||||
foo: &'a u32,
|
||||
}
|
||||
|
||||
impl<'a> Lt<'a> {
|
||||
// The lifetime is different, but that’s irrelevant, see #734
|
||||
#[allow(needless_lifetimes)]
|
||||
pub fn new<'b>(s: &'b str) -> Lt<'b> { unimplemented!() }
|
||||
}
|
||||
|
||||
struct Lt2<'a> {
|
||||
foo: &'a u32,
|
||||
}
|
||||
|
||||
impl<'a> Lt2<'a> {
|
||||
// The lifetime is different, but that’s irrelevant, see #734
|
||||
pub fn new(s: &str) -> Lt2 { unimplemented!() }
|
||||
}
|
||||
|
||||
struct Lt3<'a> {
|
||||
foo: &'a u32,
|
||||
}
|
||||
|
||||
impl<'a> Lt3<'a> {
|
||||
// The lifetime is different, but that’s irrelevant, see #734
|
||||
pub fn new() -> Lt3<'static> { unimplemented!() }
|
||||
}
|
||||
|
||||
#[derive(Clone,Copy)]
|
||||
struct U;
|
||||
|
||||
impl U {
|
||||
fn new() -> Self { U }
|
||||
fn to_something(self) -> u32 { 0 } // ok because U is Copy
|
||||
}
|
||||
|
||||
struct V<T> {
|
||||
_dummy: T
|
||||
}
|
||||
|
||||
impl<T> V<T> {
|
||||
fn new() -> Option<V<T>> { None }
|
||||
}
|
||||
|
||||
impl Mul<T> for T {
|
||||
type Output = T;
|
||||
fn mul(self, other: T) -> T { self } // no error, obviously
|
||||
}
|
||||
|
||||
/// Utility macro to test linting behavior in `option_methods()`
|
||||
/// The lints included in `option_methods()` should not lint if the call to map is partially
|
||||
/// within a macro
|
||||
macro_rules! opt_map {
|
||||
($opt:expr, $map:expr) => {($opt).map($map)};
|
||||
}
|
||||
|
||||
/// Checks implementation of the following lints:
|
||||
/// * `OPTION_MAP_UNWRAP_OR`
|
||||
/// * `OPTION_MAP_UNWRAP_OR_ELSE`
|
||||
fn option_methods() {
|
||||
let opt = Some(1);
|
||||
|
||||
// Check OPTION_MAP_UNWRAP_OR
|
||||
// single line case
|
||||
let _ = opt.map(|x| x + 1)
|
||||
|
||||
.unwrap_or(0); // should lint even though this call is on a separate line
|
||||
// multi line cases
|
||||
let _ = opt.map(|x| {
|
||||
x + 1
|
||||
}
|
||||
).unwrap_or(0);
|
||||
let _ = opt.map(|x| x + 1)
|
||||
.unwrap_or({
|
||||
0
|
||||
});
|
||||
// macro case
|
||||
let _ = opt_map!(opt, |x| x + 1).unwrap_or(0); // should not lint
|
||||
|
||||
// Check OPTION_MAP_UNWRAP_OR_ELSE
|
||||
// single line case
|
||||
let _ = opt.map(|x| x + 1)
|
||||
|
||||
.unwrap_or_else(|| 0); // should lint even though this call is on a separate line
|
||||
// multi line cases
|
||||
let _ = opt.map(|x| {
|
||||
x + 1
|
||||
}
|
||||
).unwrap_or_else(|| 0);
|
||||
let _ = opt.map(|x| x + 1)
|
||||
.unwrap_or_else(||
|
||||
0
|
||||
);
|
||||
// macro case
|
||||
let _ = opt_map!(opt, |x| x + 1).unwrap_or_else(|| 0); // should not lint
|
||||
}
|
||||
|
||||
/// Struct to generate false positives for things with .iter()
|
||||
#[derive(Copy, Clone)]
|
||||
struct HasIter;
|
||||
|
||||
impl HasIter {
|
||||
fn iter(self) -> IteratorFalsePositives {
|
||||
IteratorFalsePositives { foo: 0 }
|
||||
}
|
||||
|
||||
fn iter_mut(self) -> IteratorFalsePositives {
|
||||
IteratorFalsePositives { foo: 0 }
|
||||
}
|
||||
}
|
||||
|
||||
/// Struct to generate false positive for Iterator-based lints
|
||||
#[derive(Copy, Clone)]
|
||||
struct IteratorFalsePositives {
|
||||
foo: u32,
|
||||
}
|
||||
|
||||
impl IteratorFalsePositives {
|
||||
fn filter(self) -> IteratorFalsePositives {
|
||||
self
|
||||
}
|
||||
|
||||
fn next(self) -> IteratorFalsePositives {
|
||||
self
|
||||
}
|
||||
|
||||
fn find(self) -> Option<u32> {
|
||||
Some(self.foo)
|
||||
}
|
||||
|
||||
fn position(self) -> Option<u32> {
|
||||
Some(self.foo)
|
||||
}
|
||||
|
||||
fn rposition(self) -> Option<u32> {
|
||||
Some(self.foo)
|
||||
}
|
||||
|
||||
fn nth(self, n: usize) -> Option<u32> {
|
||||
Some(self.foo)
|
||||
}
|
||||
|
||||
fn skip(self, _: usize) -> IteratorFalsePositives {
|
||||
self
|
||||
}
|
||||
}
|
||||
|
||||
#[derive(Copy, Clone)]
|
||||
struct HasChars;
|
||||
|
||||
impl HasChars {
|
||||
fn chars(self) -> std::str::Chars<'static> {
|
||||
"HasChars".chars()
|
||||
}
|
||||
}
|
||||
|
||||
/// Checks implementation of `FILTER_NEXT` lint
|
||||
fn filter_next() {
|
||||
let v = vec![3, 2, 1, 0, -1, -2, -3];
|
||||
|
||||
// check single-line case
|
||||
let _ = v.iter().filter(|&x| *x < 0).next();
|
||||
|
||||
|
||||
|
||||
// check multi-line case
|
||||
let _ = v.iter().filter(|&x| {
|
||||
*x < 0
|
||||
}
|
||||
).next();
|
||||
|
||||
// check that we don't lint if the caller is not an Iterator
|
||||
let foo = IteratorFalsePositives { foo: 0 };
|
||||
let _ = foo.filter().next();
|
||||
}
|
||||
|
||||
/// Checks implementation of `SEARCH_IS_SOME` lint
|
||||
fn search_is_some() {
|
||||
let v = vec![3, 2, 1, 0, -1, -2, -3];
|
||||
|
||||
// check `find().is_some()`, single-line
|
||||
let _ = v.iter().find(|&x| *x < 0).is_some();
|
||||
|
||||
|
||||
|
||||
// check `find().is_some()`, multi-line
|
||||
let _ = v.iter().find(|&x| {
|
||||
*x < 0
|
||||
}
|
||||
).is_some();
|
||||
|
||||
// check `position().is_some()`, single-line
|
||||
let _ = v.iter().position(|&x| x < 0).is_some();
|
||||
|
||||
|
||||
|
||||
// check `position().is_some()`, multi-line
|
||||
let _ = v.iter().position(|&x| {
|
||||
x < 0
|
||||
}
|
||||
).is_some();
|
||||
|
||||
// check `rposition().is_some()`, single-line
|
||||
let _ = v.iter().rposition(|&x| x < 0).is_some();
|
||||
|
||||
|
||||
|
||||
// check `rposition().is_some()`, multi-line
|
||||
let _ = v.iter().rposition(|&x| {
|
||||
x < 0
|
||||
}
|
||||
).is_some();
|
||||
|
||||
// check that we don't lint if the caller is not an Iterator
|
||||
let foo = IteratorFalsePositives { foo: 0 };
|
||||
let _ = foo.find().is_some();
|
||||
let _ = foo.position().is_some();
|
||||
let _ = foo.rposition().is_some();
|
||||
}
|
||||
|
||||
/// Checks implementation of the `OR_FUN_CALL` lint
|
||||
fn or_fun_call() {
|
||||
struct Foo;
|
||||
|
||||
impl Foo {
|
||||
fn new() -> Foo { Foo }
|
||||
}
|
||||
|
||||
enum Enum {
|
||||
A(i32),
|
||||
}
|
||||
|
||||
const fn make_const(i: i32) -> i32 { i }
|
||||
|
||||
fn make<T>() -> T { unimplemented!(); }
|
||||
|
||||
let with_enum = Some(Enum::A(1));
|
||||
with_enum.unwrap_or(Enum::A(5));
|
||||
|
||||
let with_const_fn = Some(1);
|
||||
with_const_fn.unwrap_or(make_const(5));
|
||||
|
||||
let with_constructor = Some(vec![1]);
|
||||
with_constructor.unwrap_or(make());
|
||||
|
||||
|
||||
|
||||
|
||||
let with_new = Some(vec![1]);
|
||||
with_new.unwrap_or(Vec::new());
|
||||
|
||||
|
||||
|
||||
|
||||
let with_const_args = Some(vec![1]);
|
||||
with_const_args.unwrap_or(Vec::with_capacity(12));
|
||||
|
||||
|
||||
|
||||
|
||||
let with_err : Result<_, ()> = Ok(vec![1]);
|
||||
with_err.unwrap_or(make());
|
||||
|
||||
|
||||
|
||||
|
||||
let with_err_args : Result<_, ()> = Ok(vec![1]);
|
||||
with_err_args.unwrap_or(Vec::with_capacity(12));
|
||||
|
||||
|
||||
|
||||
|
||||
let with_default_trait = Some(1);
|
||||
with_default_trait.unwrap_or(Default::default());
|
||||
|
||||
|
||||
|
||||
|
||||
let with_default_type = Some(1);
|
||||
with_default_type.unwrap_or(u64::default());
|
||||
|
||||
|
||||
|
||||
|
||||
let with_vec = Some(vec![1]);
|
||||
with_vec.unwrap_or(vec![]);
|
||||
|
||||
|
||||
// FIXME #944: ~|SUGGESTION with_vec.unwrap_or_else(|| vec![]);
|
||||
|
||||
let without_default = Some(Foo);
|
||||
without_default.unwrap_or(Foo::new());
|
||||
|
||||
|
||||
|
||||
|
||||
let mut map = HashMap::<u64, String>::new();
|
||||
map.entry(42).or_insert(String::new());
|
||||
|
||||
|
||||
|
||||
|
||||
let mut btree = BTreeMap::<u64, String>::new();
|
||||
btree.entry(42).or_insert(String::new());
|
||||
|
||||
|
||||
|
||||
|
||||
let stringy = Some(String::from(""));
|
||||
let _ = stringy.unwrap_or("".to_owned());
|
||||
|
||||
|
||||
|
||||
}
|
||||
|
||||
/// Checks implementation of `ITER_NTH` lint
|
||||
fn iter_nth() {
|
||||
let mut some_vec = vec![0, 1, 2, 3];
|
||||
let mut boxed_slice: Box<[u8]> = Box::new([0, 1, 2, 3]);
|
||||
let mut some_vec_deque: VecDeque<_> = some_vec.iter().cloned().collect();
|
||||
|
||||
{
|
||||
// Make sure we lint `.iter()` for relevant types
|
||||
let bad_vec = some_vec.iter().nth(3);
|
||||
|
||||
let bad_slice = &some_vec[..].iter().nth(3);
|
||||
|
||||
let bad_boxed_slice = boxed_slice.iter().nth(3);
|
||||
|
||||
let bad_vec_deque = some_vec_deque.iter().nth(3);
|
||||
|
||||
}
|
||||
|
||||
{
|
||||
// Make sure we lint `.iter_mut()` for relevant types
|
||||
let bad_vec = some_vec.iter_mut().nth(3);
|
||||
|
||||
}
|
||||
{
|
||||
let bad_slice = &some_vec[..].iter_mut().nth(3);
|
||||
|
||||
}
|
||||
{
|
||||
let bad_vec_deque = some_vec_deque.iter_mut().nth(3);
|
||||
|
||||
}
|
||||
|
||||
// Make sure we don't lint for non-relevant types
|
||||
let false_positive = HasIter;
|
||||
let ok = false_positive.iter().nth(3);
|
||||
let ok_mut = false_positive.iter_mut().nth(3);
|
||||
}
|
||||
|
||||
/// Checks implementation of `ITER_SKIP_NEXT` lint
|
||||
fn iter_skip_next() {
|
||||
let mut some_vec = vec![0, 1, 2, 3];
|
||||
|
||||
let _ = some_vec.iter().skip(42).next();
|
||||
|
||||
|
||||
let _ = some_vec.iter().cycle().skip(42).next();
|
||||
|
||||
|
||||
let _ = (1..10).skip(10).next();
|
||||
|
||||
|
||||
let _ = &some_vec[..].iter().skip(3).next();
|
||||
|
||||
|
||||
let foo = IteratorFalsePositives { foo : 0 };
|
||||
let _ = foo.skip(42).next();
|
||||
let _ = foo.filter().skip(42).next();
|
||||
}
|
||||
|
||||
struct GetFalsePositive {
|
||||
arr: [u32; 3],
|
||||
}
|
||||
|
||||
impl GetFalsePositive {
|
||||
fn get(&self, pos: usize) -> Option<&u32> { self.arr.get(pos) }
|
||||
fn get_mut(&mut self, pos: usize) -> Option<&mut u32> { self.arr.get_mut(pos) }
|
||||
}
|
||||
|
||||
/// Checks implementation of `GET_UNWRAP` lint
|
||||
fn get_unwrap() {
|
||||
let mut boxed_slice: Box<[u8]> = Box::new([0, 1, 2, 3]);
|
||||
let mut some_slice = &mut [0, 1, 2, 3];
|
||||
let mut some_vec = vec![0, 1, 2, 3];
|
||||
let mut some_vecdeque: VecDeque<_> = some_vec.iter().cloned().collect();
|
||||
let mut some_hashmap: HashMap<u8, char> = HashMap::from_iter(vec![(1, 'a'), (2, 'b')]);
|
||||
let mut some_btreemap: BTreeMap<u8, char> = BTreeMap::from_iter(vec![(1, 'a'), (2, 'b')]);
|
||||
let mut false_positive = GetFalsePositive { arr: [0, 1, 2] };
|
||||
|
||||
{ // Test `get().unwrap()`
|
||||
let _ = boxed_slice.get(1).unwrap();
|
||||
|
||||
|
||||
|
||||
let _ = some_slice.get(0).unwrap();
|
||||
|
||||
|
||||
|
||||
let _ = some_vec.get(0).unwrap();
|
||||
|
||||
|
||||
|
||||
let _ = some_vecdeque.get(0).unwrap();
|
||||
|
||||
|
||||
|
||||
let _ = some_hashmap.get(&1).unwrap();
|
||||
|
||||
|
||||
|
||||
let _ = some_btreemap.get(&1).unwrap();
|
||||
|
||||
|
||||
|
||||
|
||||
let _ = false_positive.get(0).unwrap();
|
||||
}
|
||||
|
||||
{ // Test `get_mut().unwrap()`
|
||||
*boxed_slice.get_mut(0).unwrap() = 1;
|
||||
|
||||
|
||||
|
||||
*some_slice.get_mut(0).unwrap() = 1;
|
||||
|
||||
|
||||
|
||||
*some_vec.get_mut(0).unwrap() = 1;
|
||||
|
||||
|
||||
|
||||
*some_vecdeque.get_mut(0).unwrap() = 1;
|
||||
|
||||
|
||||
|
||||
|
||||
// Check false positives
|
||||
*some_hashmap.get_mut(&1).unwrap() = 'b';
|
||||
*some_btreemap.get_mut(&1).unwrap() = 'b';
|
||||
*false_positive.get_mut(0).unwrap() = 1;
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
#[allow(similar_names)]
|
||||
fn main() {
|
||||
use std::io;
|
||||
|
||||
let opt = Some(0);
|
||||
let _ = opt.unwrap();
|
||||
|
||||
let res: Result<i32, ()> = Ok(0);
|
||||
let _ = res.unwrap();
|
||||
|
||||
res.ok().expect("disaster!");
|
||||
// the following should not warn, since `expect` isn't implemented unless
|
||||
// the error type implements `Debug`
|
||||
let res2: Result<i32, MyError> = Ok(0);
|
||||
res2.ok().expect("oh noes!");
|
||||
let res3: Result<u32, MyErrorWithParam<u8>>= Ok(0);
|
||||
res3.ok().expect("whoof");
|
||||
let res4: Result<u32, io::Error> = Ok(0);
|
||||
res4.ok().expect("argh");
|
||||
let res5: io::Result<u32> = Ok(0);
|
||||
res5.ok().expect("oops");
|
||||
let res6: Result<u32, &str> = Ok(0);
|
||||
res6.ok().expect("meh");
|
||||
}
|
||||
|
||||
struct MyError(()); // doesn't implement Debug
|
||||
|
||||
#[derive(Debug)]
|
||||
struct MyErrorWithParam<T> {
|
||||
x: T
|
||||
}
|
||||
|
||||
#[allow(unnecessary_operation)]
|
||||
fn starts_with() {
|
||||
"".chars().next() == Some(' ');
|
||||
|
||||
|
||||
|
||||
|
||||
Some(' ') != "".chars().next();
|
||||
|
||||
|
||||
|
||||
}
|
||||
|
||||
fn str_extend_chars() {
|
||||
let abc = "abc";
|
||||
let def = String::from("def");
|
||||
let mut s = String::new();
|
||||
|
||||
s.push_str(abc);
|
||||
s.extend(abc.chars());
|
||||
|
||||
|
||||
|
||||
|
||||
s.push_str("abc");
|
||||
s.extend("abc".chars());
|
||||
|
||||
|
||||
|
||||
|
||||
s.push_str(&def);
|
||||
s.extend(def.chars());
|
||||
|
||||
|
||||
|
||||
|
||||
s.extend(abc.chars().skip(1));
|
||||
s.extend("abc".chars().skip(1));
|
||||
s.extend(['a', 'b', 'c'].iter());
|
||||
|
||||
let f = HasChars;
|
||||
s.extend(f.chars());
|
||||
}
|
||||
|
||||
fn clone_on_copy() {
|
||||
42.clone();
|
||||
|
||||
|
||||
vec![1].clone(); // ok, not a Copy type
|
||||
Some(vec![1]).clone(); // ok, not a Copy type
|
||||
(&42).clone();
|
||||
|
||||
|
||||
}
|
||||
|
||||
fn clone_on_copy_generic<T: Copy>(t: T) {
|
||||
t.clone();
|
||||
|
||||
|
||||
Some(t).clone();
|
||||
|
||||
|
||||
}
|
||||
|
||||
fn clone_on_double_ref() {
|
||||
let x = vec![1];
|
||||
let y = &&x;
|
||||
let z: &Vec<_> = y.clone();
|
||||
|
||||
|
||||
println!("{:p} {:p}",*y, z);
|
||||
}
|
||||
|
||||
fn single_char_pattern() {
|
||||
let x = "foo";
|
||||
x.split("x");
|
||||
|
||||
|
||||
|
||||
|
||||
x.split("xx");
|
||||
|
||||
x.split('x');
|
||||
|
||||
let y = "x";
|
||||
x.split(y);
|
||||
|
||||
// Not yet testing for multi-byte characters
|
||||
// Changing `r.len() == 1` to `r.chars().count() == 1` in `lint_single_char_pattern`
|
||||
// should have done this but produced an ICE
|
||||
//
|
||||
// We may not want to suggest changing these anyway
|
||||
// See: https://github.com/Manishearth/rust-clippy/issues/650#issuecomment-184328984
|
||||
x.split("ß");
|
||||
x.split("ℝ");
|
||||
x.split("💣");
|
||||
// Can't use this lint for unicode code points which don't fit in a char
|
||||
x.split("❤️");
|
||||
|
||||
x.contains("x");
|
||||
|
||||
|
||||
|
||||
x.starts_with("x");
|
||||
|
||||
|
||||
|
||||
x.ends_with("x");
|
||||
|
||||
|
||||
|
||||
x.find("x");
|
||||
|
||||
|
||||
|
||||
x.rfind("x");
|
||||
|
||||
|
||||
|
||||
x.rsplit("x");
|
||||
|
||||
|
||||
|
||||
x.split_terminator("x");
|
||||
|
||||
|
||||
|
||||
x.rsplit_terminator("x");
|
||||
|
||||
|
||||
|
||||
x.splitn(0, "x");
|
||||
|
||||
|
||||
|
||||
x.rsplitn(0, "x");
|
||||
|
||||
|
||||
|
||||
x.matches("x");
|
||||
|
||||
|
||||
|
||||
x.rmatches("x");
|
||||
|
||||
|
||||
|
||||
x.match_indices("x");
|
||||
|
||||
|
||||
|
||||
x.rmatch_indices("x");
|
||||
|
||||
|
||||
|
||||
x.trim_left_matches("x");
|
||||
|
||||
|
||||
|
||||
x.trim_right_matches("x");
|
||||
|
||||
|
||||
|
||||
|
||||
let h = HashSet::<String>::new();
|
||||
h.contains("X"); // should not warn
|
||||
}
|
||||
|
||||
#[allow(result_unwrap_used)]
|
||||
fn temporary_cstring() {
|
||||
use std::ffi::CString;
|
||||
|
||||
CString::new("foo").unwrap().as_ptr();
|
||||
|
||||
|
||||
|
||||
}
|
||||
@ -1,150 +0,0 @@
|
||||
#![feature(plugin)]
|
||||
#![plugin(clippy)]
|
||||
#![deny(clippy,similar_names)]
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
#![allow(unused)]
|
||||
|
||||
|
||||
struct Foo {
|
||||
apple: i32,
|
||||
bpple: i32,
|
||||
}
|
||||
|
||||
fn main() {
|
||||
let specter: i32;
|
||||
let spectre: i32;
|
||||
|
||||
let apple: i32;
|
||||
|
||||
let bpple: i32;
|
||||
|
||||
let cpple: i32;
|
||||
|
||||
|
||||
let a_bar: i32;
|
||||
let b_bar: i32;
|
||||
let c_bar: i32;
|
||||
|
||||
let items = [5];
|
||||
for item in &items {
|
||||
loop {}
|
||||
}
|
||||
|
||||
let foo_x: i32;
|
||||
let foo_y: i32;
|
||||
|
||||
let rhs: i32;
|
||||
let lhs: i32;
|
||||
|
||||
let bla_rhs: i32;
|
||||
let bla_lhs: i32;
|
||||
|
||||
let blubrhs: i32;
|
||||
let blublhs: i32;
|
||||
|
||||
let blubx: i32;
|
||||
let bluby: i32;
|
||||
|
||||
|
||||
let cake: i32;
|
||||
let cakes: i32;
|
||||
let coke: i32;
|
||||
|
||||
match 5 {
|
||||
cheese @ 1 => {},
|
||||
rabbit => panic!(),
|
||||
}
|
||||
let cheese: i32;
|
||||
match (42, 43) {
|
||||
(cheese1, 1) => {},
|
||||
(cheese2, 2) => panic!(),
|
||||
_ => println!(""),
|
||||
}
|
||||
let ipv4: i32;
|
||||
let ipv6: i32;
|
||||
let abcd1: i32;
|
||||
let abdc2: i32;
|
||||
let xyz1abc: i32;
|
||||
let xyz2abc: i32;
|
||||
let xyzeabc: i32;
|
||||
|
||||
let parser: i32;
|
||||
let parsed: i32;
|
||||
let parsee: i32;
|
||||
|
||||
|
||||
let setter: i32;
|
||||
let getter: i32;
|
||||
let tx1: i32;
|
||||
let rx1: i32;
|
||||
let tx_cake: i32;
|
||||
let rx_cake: i32;
|
||||
}
|
||||
|
||||
fn foo() {
|
||||
let Foo { apple, bpple } = unimplemented!();
|
||||
let Foo { apple: spring,
|
||||
bpple: sprang } = unimplemented!();
|
||||
}
|
||||
|
||||
#[derive(Clone, Debug)]
|
||||
enum MaybeInst {
|
||||
Split,
|
||||
Split1(usize),
|
||||
Split2(usize),
|
||||
}
|
||||
|
||||
struct InstSplit {
|
||||
uiae: usize,
|
||||
}
|
||||
|
||||
impl MaybeInst {
|
||||
fn fill(&mut self) {
|
||||
let filled = match *self {
|
||||
MaybeInst::Split1(goto1) => panic!(1),
|
||||
MaybeInst::Split2(goto2) => panic!(2),
|
||||
_ => unimplemented!(),
|
||||
};
|
||||
unimplemented!()
|
||||
}
|
||||
}
|
||||
|
||||
fn bla() {
|
||||
let a: i32;
|
||||
let (b, c, d): (i32, i64, i16);
|
||||
{
|
||||
{
|
||||
let cdefg: i32;
|
||||
let blar: i32;
|
||||
}
|
||||
{
|
||||
let e: i32;
|
||||
|
||||
}
|
||||
{
|
||||
let e: i32;
|
||||
|
||||
let f: i32;
|
||||
|
||||
}
|
||||
match 5 {
|
||||
1 => println!(""),
|
||||
e => panic!(),
|
||||
|
||||
}
|
||||
match 5 {
|
||||
1 => println!(""),
|
||||
_ => panic!(),
|
||||
}
|
||||
}
|
||||
}
|
||||
@ -1,73 +0,0 @@
|
||||
#![feature(plugin)]
|
||||
#![plugin(clippy)]
|
||||
|
||||
#[deny(string_add)]
|
||||
#[allow(string_add_assign)]
|
||||
fn add_only() { // ignores assignment distinction
|
||||
let mut x = "".to_owned();
|
||||
|
||||
for _ in 1..3 {
|
||||
x = x + ".";
|
||||
}
|
||||
|
||||
let y = "".to_owned();
|
||||
let z = y + "...";
|
||||
|
||||
assert_eq!(&x, &z);
|
||||
}
|
||||
|
||||
#[deny(string_add_assign)]
|
||||
fn add_assign_only() {
|
||||
let mut x = "".to_owned();
|
||||
|
||||
for _ in 1..3 {
|
||||
x = x + ".";
|
||||
}
|
||||
|
||||
let y = "".to_owned();
|
||||
let z = y + "...";
|
||||
|
||||
assert_eq!(&x, &z);
|
||||
}
|
||||
|
||||
#[deny(string_add, string_add_assign)]
|
||||
fn both() {
|
||||
let mut x = "".to_owned();
|
||||
|
||||
for _ in 1..3 {
|
||||
x = x + ".";
|
||||
}
|
||||
|
||||
let y = "".to_owned();
|
||||
let z = y + "...";
|
||||
|
||||
assert_eq!(&x, &z);
|
||||
}
|
||||
|
||||
#[allow(dead_code, unused_variables)]
|
||||
#[deny(string_lit_as_bytes)]
|
||||
fn str_lit_as_bytes() {
|
||||
let bs = "hello there".as_bytes();
|
||||
|
||||
|
||||
|
||||
|
||||
// no warning, because this cannot be written as a byte string literal:
|
||||
let ubs = "☃".as_bytes();
|
||||
|
||||
let strify = stringify!(foobar).as_bytes();
|
||||
}
|
||||
|
||||
fn main() {
|
||||
add_only();
|
||||
add_assign_only();
|
||||
both();
|
||||
|
||||
// the add is only caught for `String`
|
||||
let mut x = 1;
|
||||
; x = x + 1;
|
||||
|
||||
|
||||
|
||||
assert_eq!(2, x);
|
||||
}
|
||||
@ -1,84 +0,0 @@
|
||||
#![feature(plugin)]
|
||||
#![plugin(clippy)]
|
||||
|
||||
#![deny(clippy)]
|
||||
#![allow(blacklisted_name, unused_assignments)]
|
||||
|
||||
struct Foo(u32);
|
||||
|
||||
fn array() {
|
||||
let mut foo = [1, 2];
|
||||
let temp = foo[0];
|
||||
foo[0] = foo[1];
|
||||
foo[1] = temp;
|
||||
|
||||
|
||||
|
||||
|
||||
foo.swap(0, 1);
|
||||
}
|
||||
|
||||
fn slice() {
|
||||
let foo = &mut [1, 2];
|
||||
let temp = foo[0];
|
||||
foo[0] = foo[1];
|
||||
foo[1] = temp;
|
||||
|
||||
|
||||
|
||||
|
||||
foo.swap(0, 1);
|
||||
}
|
||||
|
||||
fn vec() {
|
||||
let mut foo = vec![1, 2];
|
||||
let temp = foo[0];
|
||||
foo[0] = foo[1];
|
||||
foo[1] = temp;
|
||||
|
||||
|
||||
|
||||
|
||||
foo.swap(0, 1);
|
||||
}
|
||||
|
||||
fn main() {
|
||||
array();
|
||||
slice();
|
||||
vec();
|
||||
|
||||
let mut a = 42;
|
||||
let mut b = 1337;
|
||||
|
||||
a = b;
|
||||
b = a;
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
; let t = a;
|
||||
a = b;
|
||||
b = t;
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
let mut c = Foo(42);
|
||||
|
||||
c.0 = a;
|
||||
a = c.0;
|
||||
|
||||
|
||||
|
||||
|
||||
|
||||
; let t = c.0;
|
||||
c.0 = a;
|
||||
a = t;
|
||||
|
||||
|
||||
|
||||
|
||||
}
|
||||
@ -1,4 +0,0 @@
|
||||
error: error reading Clippy's configuration file: No such file or directory (os error 2)
|
||||
|
||||
error: aborting due to previous error
|
||||
|
||||
@ -1,4 +0,0 @@
|
||||
error: error reading Clippy's configuration file: No such file or directory (os error 2)
|
||||
|
||||
error: aborting due to previous error
|
||||
|
||||
28
tests/ui-posix/update-all-references.sh
Executable file
28
tests/ui-posix/update-all-references.sh
Executable file
@ -0,0 +1,28 @@
|
||||
#!/bin/bash
|
||||
#
|
||||
# Copyright 2015 The Rust Project Developers. See the COPYRIGHT
|
||||
# file at the top-level directory of this distribution and at
|
||||
# http://rust-lang.org/COPYRIGHT.
|
||||
#
|
||||
# Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
||||
# http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
||||
# <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
||||
# option. This file may not be copied, modified, or distributed
|
||||
# except according to those terms.
|
||||
|
||||
# A script to update the references for all tests. The idea is that
|
||||
# you do a run, which will generate files in the build directory
|
||||
# containing the (normalized) actual output of the compiler. You then
|
||||
# run this script, which will copy those files over. If you find
|
||||
# yourself manually editing a foo.stderr file, you're doing it wrong.
|
||||
#
|
||||
# See all `update-references.sh`, if you just want to update a single test.
|
||||
|
||||
if [[ "$1" == "--help" || "$1" == "-h" || "$1" == "" ]]; then
|
||||
echo "usage: $0"
|
||||
fi
|
||||
|
||||
BUILD_DIR=$PWD/target/debug/test_build_base
|
||||
MY_DIR=$(dirname $0)
|
||||
cd $MY_DIR
|
||||
find . -name '*.rs' | xargs ./update-references.sh $BUILD_DIR
|
||||
50
tests/ui-posix/update-references.sh
Executable file
50
tests/ui-posix/update-references.sh
Executable file
@ -0,0 +1,50 @@
|
||||
#!/bin/bash
|
||||
#
|
||||
# Copyright 2015 The Rust Project Developers. See the COPYRIGHT
|
||||
# file at the top-level directory of this distribution and at
|
||||
# http://rust-lang.org/COPYRIGHT.
|
||||
#
|
||||
# Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
||||
# http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
||||
# <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
||||
# option. This file may not be copied, modified, or distributed
|
||||
# except according to those terms.
|
||||
|
||||
# A script to update the references for particular tests. The idea is
|
||||
# that you do a run, which will generate files in the build directory
|
||||
# containing the (normalized) actual output of the compiler. This
|
||||
# script will then copy that output and replace the "expected output"
|
||||
# files. You can then commit the changes.
|
||||
#
|
||||
# If you find yourself manually editing a foo.stderr file, you're
|
||||
# doing it wrong.
|
||||
|
||||
if [[ "$1" == "--help" || "$1" == "-h" || "$1" == "" || "$2" == "" ]]; then
|
||||
echo "usage: $0 <build-directory> <relative-path-to-rs-files>"
|
||||
echo ""
|
||||
echo "For example:"
|
||||
echo " $0 ../../../build/x86_64-apple-darwin/test/ui *.rs */*.rs"
|
||||
fi
|
||||
|
||||
MYDIR=$(dirname $0)
|
||||
|
||||
BUILD_DIR="$1"
|
||||
shift
|
||||
|
||||
while [[ "$1" != "" ]]; do
|
||||
STDERR_NAME="${1/%.rs/.stderr}"
|
||||
STDOUT_NAME="${1/%.rs/.stdout}"
|
||||
shift
|
||||
if [ -f $BUILD_DIR/$STDOUT_NAME ] && \
|
||||
! (diff $BUILD_DIR/$STDOUT_NAME $MYDIR/$STDOUT_NAME >& /dev/null); then
|
||||
echo updating $MYDIR/$STDOUT_NAME
|
||||
cp $BUILD_DIR/$STDOUT_NAME $MYDIR/$STDOUT_NAME
|
||||
fi
|
||||
if [ -f $BUILD_DIR/$STDERR_NAME ] && \
|
||||
! (diff $BUILD_DIR/$STDERR_NAME $MYDIR/$STDERR_NAME >& /dev/null); then
|
||||
echo updating $MYDIR/$STDERR_NAME
|
||||
cp $BUILD_DIR/$STDERR_NAME $MYDIR/$STDERR_NAME
|
||||
fi
|
||||
done
|
||||
|
||||
|
||||
@ -1,6 +0,0 @@
|
||||
// error-pattern: error reading Clippy's configuration file
|
||||
|
||||
#![feature(plugin)]
|
||||
#![plugin(clippy(conf_file="./tests/compile-fail/conf_bad_toml.toml"))]
|
||||
|
||||
fn main() {}
|
||||
@ -1,4 +0,0 @@
|
||||
error: error reading Clippy's configuration file: The system cannot find the file specified. (os error 2)
|
||||
|
||||
error: aborting due to previous error
|
||||
|
||||
@ -1,2 +0,0 @@
|
||||
fn this_is_obviously(not: a, toml: file) {
|
||||
}
|
||||
@ -1,6 +0,0 @@
|
||||
// error-pattern: error reading Clippy's configuration file: `blacklisted-names` is expected to be a `Vec < String >` but is a `integer`
|
||||
|
||||
#![feature(plugin)]
|
||||
#![plugin(clippy(conf_file="./tests/compile-fail/conf_bad_type.toml"))]
|
||||
|
||||
fn main() {}
|
||||
@ -1,4 +0,0 @@
|
||||
error: error reading Clippy's configuration file: The system cannot find the file specified. (os error 2)
|
||||
|
||||
error: aborting due to previous error
|
||||
|
||||
@ -1 +0,0 @@
|
||||
blacklisted-names = 42
|
||||
28
tests/ui-windows/update-all-references.sh
Executable file
28
tests/ui-windows/update-all-references.sh
Executable file
@ -0,0 +1,28 @@
|
||||
#!/bin/bash
|
||||
#
|
||||
# Copyright 2015 The Rust Project Developers. See the COPYRIGHT
|
||||
# file at the top-level directory of this distribution and at
|
||||
# http://rust-lang.org/COPYRIGHT.
|
||||
#
|
||||
# Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
||||
# http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
||||
# <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
||||
# option. This file may not be copied, modified, or distributed
|
||||
# except according to those terms.
|
||||
|
||||
# A script to update the references for all tests. The idea is that
|
||||
# you do a run, which will generate files in the build directory
|
||||
# containing the (normalized) actual output of the compiler. You then
|
||||
# run this script, which will copy those files over. If you find
|
||||
# yourself manually editing a foo.stderr file, you're doing it wrong.
|
||||
#
|
||||
# See all `update-references.sh`, if you just want to update a single test.
|
||||
|
||||
if [[ "$1" == "--help" || "$1" == "-h" || "$1" == "" ]]; then
|
||||
echo "usage: $0"
|
||||
fi
|
||||
|
||||
BUILD_DIR=$PWD/target/debug/test_build_base
|
||||
MY_DIR=$(dirname $0)
|
||||
cd $MY_DIR
|
||||
find . -name '*.rs' | xargs ./update-references.sh $BUILD_DIR
|
||||
50
tests/ui-windows/update-references.sh
Executable file
50
tests/ui-windows/update-references.sh
Executable file
@ -0,0 +1,50 @@
|
||||
#!/bin/bash
|
||||
#
|
||||
# Copyright 2015 The Rust Project Developers. See the COPYRIGHT
|
||||
# file at the top-level directory of this distribution and at
|
||||
# http://rust-lang.org/COPYRIGHT.
|
||||
#
|
||||
# Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
||||
# http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
||||
# <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
||||
# option. This file may not be copied, modified, or distributed
|
||||
# except according to those terms.
|
||||
|
||||
# A script to update the references for particular tests. The idea is
|
||||
# that you do a run, which will generate files in the build directory
|
||||
# containing the (normalized) actual output of the compiler. This
|
||||
# script will then copy that output and replace the "expected output"
|
||||
# files. You can then commit the changes.
|
||||
#
|
||||
# If you find yourself manually editing a foo.stderr file, you're
|
||||
# doing it wrong.
|
||||
|
||||
if [[ "$1" == "--help" || "$1" == "-h" || "$1" == "" || "$2" == "" ]]; then
|
||||
echo "usage: $0 <build-directory> <relative-path-to-rs-files>"
|
||||
echo ""
|
||||
echo "For example:"
|
||||
echo " $0 ../../../build/x86_64-apple-darwin/test/ui *.rs */*.rs"
|
||||
fi
|
||||
|
||||
MYDIR=$(dirname $0)
|
||||
|
||||
BUILD_DIR="$1"
|
||||
shift
|
||||
|
||||
while [[ "$1" != "" ]]; do
|
||||
STDERR_NAME="${1/%.rs/.stderr}"
|
||||
STDOUT_NAME="${1/%.rs/.stdout}"
|
||||
shift
|
||||
if [ -f $BUILD_DIR/$STDOUT_NAME ] && \
|
||||
! (diff $BUILD_DIR/$STDOUT_NAME $MYDIR/$STDOUT_NAME >& /dev/null); then
|
||||
echo updating $MYDIR/$STDOUT_NAME
|
||||
cp $BUILD_DIR/$STDOUT_NAME $MYDIR/$STDOUT_NAME
|
||||
fi
|
||||
if [ -f $BUILD_DIR/$STDERR_NAME ] && \
|
||||
! (diff $BUILD_DIR/$STDERR_NAME $MYDIR/$STDERR_NAME >& /dev/null); then
|
||||
echo updating $MYDIR/$STDERR_NAME
|
||||
cp $BUILD_DIR/$STDERR_NAME $MYDIR/$STDERR_NAME
|
||||
fi
|
||||
done
|
||||
|
||||
|
||||
@ -1,6 +1,6 @@
|
||||
// error-pattern: error reading Clippy's configuration file
|
||||
|
||||
#![feature(plugin)]
|
||||
#![plugin(clippy(conf_file="./tests/compile-fail/conf_bad_toml.toml"))]
|
||||
#![plugin(clippy(conf_file="./tests/ui/conf_bad_toml.toml"))]
|
||||
|
||||
fn main() {}
|
||||
4
tests/ui/conf_bad_toml.stderr
Normal file
4
tests/ui/conf_bad_toml.stderr
Normal file
@ -0,0 +1,4 @@
|
||||
error: error reading Clippy's configuration file: expected `=`, but found `t`
|
||||
|
||||
error: aborting due to previous error
|
||||
|
||||
@ -1,6 +1,6 @@
|
||||
// error-pattern: error reading Clippy's configuration file: `blacklisted-names` is expected to be a `Vec < String >` but is a `integer`
|
||||
|
||||
#![feature(plugin)]
|
||||
#![plugin(clippy(conf_file="./tests/compile-fail/conf_bad_type.toml"))]
|
||||
#![plugin(clippy(conf_file="./tests/ui/conf_bad_type.toml"))]
|
||||
|
||||
fn main() {}
|
||||
4
tests/ui/conf_bad_type.stderr
Normal file
4
tests/ui/conf_bad_type.stderr
Normal file
@ -0,0 +1,4 @@
|
||||
error: error reading Clippy's configuration file: `blacklisted-names` is expected to be a `Vec < String >` but is a `integer`
|
||||
|
||||
error: aborting due to previous error
|
||||
|
||||
@ -18,14 +18,11 @@
|
||||
#
|
||||
# See all `update-references.sh`, if you just want to update a single test.
|
||||
|
||||
if [[ "$1" == "--help" || "$1" == "-h" || "$1" == "" || "$2" != "" ]]; then
|
||||
echo "usage: $0 <build-directory>"
|
||||
echo ""
|
||||
echo "For example:"
|
||||
echo " $0 ../../../build/x86_64-apple-darwin/test/ui"
|
||||
if [[ "$1" == "--help" || "$1" == "-h" || "$1" == "" ]]; then
|
||||
echo "usage: $0"
|
||||
fi
|
||||
|
||||
BUILD_DIR=$PWD/$1
|
||||
BUILD_DIR=$PWD/target/debug/test_build_base
|
||||
MY_DIR=$(dirname $0)
|
||||
cd $MY_DIR
|
||||
find . -name '*.rs' | xargs ./update-references.sh $BUILD_DIR
|
||||
|
||||
Loading…
Reference in New Issue
Block a user