diff --git a/src/librustc/middle/typeck/check/regionck.rs b/src/librustc/middle/typeck/check/regionck.rs index eb630d0fc7b..c08401375ca 100644 --- a/src/librustc/middle/typeck/check/regionck.rs +++ b/src/librustc/middle/typeck/check/regionck.rs @@ -769,6 +769,10 @@ fn visit_expr(rcx: &mut Rcx, expr: &ast::Expr) { } rcx.visit_expr(&**head, ()); + type_of_node_must_outlive(rcx, + infer::AddrOf(expr.span), + head.id, + ty::ReScope(expr.id)); let repeating_scope = rcx.set_repeating_scope(body.id); rcx.visit_block(&**body, ()); diff --git a/src/test/compile-fail/borrowck-for-loop-head-linkage.rs b/src/test/compile-fail/borrowck-for-loop-head-linkage.rs new file mode 100644 index 00000000000..600c0ac801b --- /dev/null +++ b/src/test/compile-fail/borrowck-for-loop-head-linkage.rs @@ -0,0 +1,19 @@ +// Copyright 2014 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +fn main() { + let mut vector = vec![1u, 2]; + for &x in vector.iter() { + let cap = vector.capacity(); + vector.grow(cap, &0u); //~ ERROR cannot borrow + *vector.get_mut(1u) = 5u; //~ ERROR cannot borrow + } +} + diff --git a/src/test/run-pass/for-loop-does-not-borrow-iterators.rs b/src/test/run-pass/for-loop-does-not-borrow-iterators.rs deleted file mode 100644 index 206ab0dfeb2..00000000000 --- a/src/test/run-pass/for-loop-does-not-borrow-iterators.rs +++ /dev/null @@ -1,30 +0,0 @@ -// Copyright 2014 The Rust Project Developers. See the COPYRIGHT -// file at the top-level directory of this distribution and at -// http://rust-lang.org/COPYRIGHT. -// -// Licensed under the Apache License, Version 2.0 or the MIT license -// , at your -// option. This file may not be copied, modified, or distributed -// except according to those terms. - - -// The `for` loop use to keep a mutable borrow when executing its body, -// making it impossible to re-use the iterator as follows. -// https://github.com/rust-lang/rust/issues/8372 -// -// This was fixed in https://github.com/rust-lang/rust/pull/15809 - -pub fn main() { - let mut for_loop_values = Vec::new(); - let mut explicit_next_call_values = Vec::new(); - - let mut iter = range(1i, 10); - for i in iter { - for_loop_values.push(i); - explicit_next_call_values.push(iter.next()); - } - - assert_eq!(for_loop_values, vec![1, 3, 5, 7, 9]); - assert_eq!(explicit_next_call_values, vec![Some(2), Some(4), Some(6), Some(8), None]); -}