OpenE2K/rust
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Improve efficienty of impl cache in resolve

Browse Source 
And fix a bug where importing anything from an external module would
import all impls in the module.

Issue #1227
This commit is contained in:
Marijn Haverbeke 2011-12-18 19:07:26 +01:00
parent 3fa930f598
commit b36ade1367
1 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/comp/middle/resolve.rs
View File

@ -1717,22 +1717,27 @@ fn find_impls_in_mod(e: env, m: def, &impls: [@_impl],
name: option::t<ident>) {
alt m {
ast::def_mod(defid) {
let cached;
alt e.impl_cache.find(defid) {
some(v) { impls += *v; }
some(v) { cached = v; }
none. {
let found = [];
if defid.crate == ast::local_crate {
let md = option::get(e.mod_map.get(defid.node).m);
for i in md.items {
find_impls_in_item(i, found, name, some(md));
cached = if defid.crate == ast::local_crate {
let tmp = [];
for i in option::get(e.mod_map.get(defid.node).m).items {
find_impls_in_item(i, tmp, name, none);
}
@tmp
} else {
found = csearch::get_impls_for_mod(e.cstore, defid, name);
}
impls += found;
e.impl_cache.insert(defid, @found);
@csearch::get_impls_for_mod(e.cstore, defid, name)
};
e.impl_cache.insert(defid, cached);
}
}
for im in *cached {
if alt name { some(n) { n == im.ident } _ { true } } {
impls += [im];
}
}
}
_ {}
}