From 816cf56b8969e239216cfe8968b1b6931d334574 Mon Sep 17 00:00:00 2001
From: Pascal Hertleif <killercup@gmail.com>
Date: Sun, 28 Aug 2016 17:04:54 +0200
Subject: [PATCH 1/2] Tweak HTML version of docs with scroll to lints

Uses good old DOM events and wibbly-wobbly timeouts to wait for angular
to render this huge list of lints.

Fixes #1181
---
 util/gh-pages/index.html | 38 +++++++++++++++++++++++++++++++++-----
 1 file changed, 33 insertions(+), 5 deletions(-)

diff --git a/util/gh-pages/index.html b/util/gh-pages/index.html
index 662aabeb2e6..c60d1f3df38 100644
--- a/util/gh-pages/index.html
+++ b/util/gh-pages/index.html
@@ -77,11 +77,11 @@
                         <span ng-if="lint.level == 'Deny'" class="label label-danger">Deny</span>
                         <span ng-if="lint.level == 'Deprecated'" class="label label-default">Deprecated</span>
 
-                        <a href="#{{lint.id}}" class="anchor label label-default">&para;</a>
+                        <a href="#{{lint.id}}" class="anchor label label-default" ng-click="open[lint.id] = true; $event.stopPropagation()">&para;</a>
                     </h2>
                 </header>
 
-                <ul class="list-group" ng-if="lint.docs" ng-class="{collapse: true, in: open[lint.id]}">
+                <ul class="list-group lint-docs" ng-if="lint.docs" ng-class="{collapse: true, in: open[lint.id]}">
                     <li class="list-group-item" ng-repeat="(title, text) in lint.docs">
                         <h4 class="list-group-item-heading">
                             {{title}}
@@ -120,6 +120,12 @@
             }
         });
 
+        function scrollToLint(lintId) {
+            var target = document.getElementById(lintId);
+            if (!target) { return; }
+            document.body.scrollTop = target.offsetTop;
+        }
+
         angular.module("clippy", [])
         .filter('markdown', function ($sce) {
             return function (text) {
@@ -130,9 +136,10 @@
                 );
             };
         })
-        .controller("lintList", function ($scope, $http) {
+        .controller("lintList", function ($scope, $http, $timeout) {
             // Level filter
-            $scope.levels = {Allow: true, Warn: true, Deny: true, Deprecated: true};
+            var LEVEL_FILTERS_DEFAULT = {Allow: true, Warn: true, Deny: true, Deprecated: true};
+            $scope.levels = LEVEL_FILTERS_DEFAULT;
             $scope.byLevels = function (lint) {
                 return $scope.levels[lint.level];
             };
@@ -141,16 +148,37 @@
             $scope.open = {};
             $scope.loading = true;
 
+            if (window.location.hash.length > 1) {
+                $scope.open[window.location.hash.slice(1)] = true;
+            }
+
             $http.get('./lints.json')
             .success(function (data) {
                 $scope.data = data;
                 $scope.loading = false;
+
+                $timeout(function () {
+                    scrollToLint(window.location.hash.slice(1));
+                }, 100);
             })
             .error(function (data) {
                 $scope.error = data;
                 $scope.loading = false;
             });
-        })
+
+            window.addEventListener('hashchange', function () {
+                // trigger re-render
+                $timeout(function () {
+                    $scope.search = "";
+                    $scope.levels = LEVEL_FILTERS_DEFAULT;
+                    // quick n dirty: wait for re-render to finish
+                    $timeout(function () {
+                        scrollToLint(window.location.hash.slice(1));
+                    }, 100);
+                });
+                return true;
+            }, false);
+        });
     })();
     </script>
 </body>

From 3e2bb3fd813a4ea07668e2a678b8c7cc8878fc82 Mon Sep 17 00:00:00 2001
From: Pascal Hertleif <killercup@gmail.com>
Date: Sun, 28 Aug 2016 21:08:14 +0200
Subject: [PATCH 2/2] Actually scroll lint panels into view
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The trick to writing horrible hacks such as this is to recognize angular
as a technology stack that may be endearing to some as one can do easy
stuff quickly. But fundamentally, it is built on top of crazy shit.

Like: Yes, I just wrote a directive that for some reason automatically
has access to the scope of the repeated item, and fires an event each
time the last `np-repeat` item was seen (delayed by one render loop
cycle, of course). And – obviously – when defining the directive it is
in camelCase  but when using it in the template it has to by in
dash-case.

Great times.
---
 util/gh-pages/index.html | 47 +++++++++++++++++++++++++++++-----------
 1 file changed, 34 insertions(+), 13 deletions(-)

diff --git a/util/gh-pages/index.html b/util/gh-pages/index.html
index c60d1f3df38..04196eef396 100644
--- a/util/gh-pages/index.html
+++ b/util/gh-pages/index.html
@@ -62,7 +62,8 @@
                 </div>
             </div>
 
-            <article class="panel panel-default" id="{{lint.id}}" ng-repeat="lint in data | filter:byLevels | filter:search | orderBy:'id' track by lint.id">
+            <article class="panel panel-default" id="{{lint.id}}"
+                ng-repeat="lint in data | filter:byLevels | filter:search | orderBy:'id' track by lint.id" on-finish-render="ngRepeatFinished">
                 <header class="panel-heading" ng-click="open[lint.id] = !open[lint.id]">
                     <button class="btn btn-default btn-sm pull-right" style="margin-top: -6px;">
                         <span ng-show="open[lint.id]">&minus;</span>
@@ -96,7 +97,7 @@
     <a href="https://github.com/Manishearth/rust-clippy">
         <img style="position: absolute; top: 0; right: 0; border: 0;" src="https://s3.amazonaws.com/github/ribbons/forkme_right_darkblue_121621.png"/>
     </a>
-    
+
     <script src="https://cdnjs.cloudflare.com/ajax/libs/markdown-it/7.0.0/markdown-it.min.js"></script>
     <script src="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/9.5.0/highlight.min.js"></script>
     <script src="https://cdnjs.cloudflare.com/ajax/libs/highlight.js/9.5.0/languages/rust.min.js"></script>
@@ -122,8 +123,17 @@
 
         function scrollToLint(lintId) {
             var target = document.getElementById(lintId);
-            if (!target) { return; }
-            document.body.scrollTop = target.offsetTop;
+            if (!target) {
+                return;
+            }
+            target.scrollIntoView();
+        }
+
+        function scrollToLintByURL($scope) {
+            var removeListener = $scope.$on('ngRepeatFinished', function(ngRepeatFinishedEvent) {
+                scrollToLint(window.location.hash.slice(1));
+                removeListener();
+            });
         }
 
         angular.module("clippy", [])
@@ -136,6 +146,18 @@
                 );
             };
         })
+        .directive('onFinishRender', function ($timeout) {
+            return {
+                restrict: 'A',
+                link: function (scope, element, attr) {
+                    if (scope.$last === true) {
+                        $timeout(function () {
+                            scope.$emit(attr.onFinishRender);
+                        });
+                    }
+                }
+            };
+        })
         .controller("lintList", function ($scope, $http, $timeout) {
             // Level filter
             var LEVEL_FILTERS_DEFAULT = {Allow: true, Warn: true, Deny: true, Deprecated: true};
@@ -149,7 +171,9 @@
             $scope.loading = true;
 
             if (window.location.hash.length > 1) {
+                $scope.search = window.location.hash.slice(1);
                 $scope.open[window.location.hash.slice(1)] = true;
+                scrollToLintByURL($scope);
             }
 
             $http.get('./lints.json')
@@ -157,9 +181,7 @@
                 $scope.data = data;
                 $scope.loading = false;
 
-                $timeout(function () {
-                    scrollToLint(window.location.hash.slice(1));
-                }, 100);
+                scrollToLintByURL($scope);
             })
             .error(function (data) {
                 $scope.error = data;
@@ -169,12 +191,11 @@
             window.addEventListener('hashchange', function () {
                 // trigger re-render
                 $timeout(function () {
-                    $scope.search = "";
                     $scope.levels = LEVEL_FILTERS_DEFAULT;
-                    // quick n dirty: wait for re-render to finish
-                    $timeout(function () {
-                        scrollToLint(window.location.hash.slice(1));
-                    }, 100);
+                    $scope.search = window.location.hash.slice(1);
+                    $scope.open[window.location.hash.slice(1)] = true;
+
+                    scrollToLintByURL($scope);
                 });
                 return true;
             }, false);
@@ -182,4 +203,4 @@
     })();
     </script>
 </body>
-</html>
\ No newline at end of file
+</html>