Detect proc-macro in needless_pass_by_value

Fixes #1876
2017-10-18 07:29:47 +09:00 · 2017-10-18 07:29:47 +09:00 · b4ea47d23e
commit b4ea47d23e
parent 4d9ed8beef
1 changed files with 5 additions and 0 deletions
--- a/clippy_lints/src/needless_pass_by_value.rs
+++ b/clippy_lints/src/needless_pass_by_value.rs
@ -121,6 +121,11 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for NeedlessPassByValue {
            .zip(&body.arguments)
            .enumerate()
        {
+            // All spans generated from a proc-macro invocation are the same...
+            if span == input.span {
+                return;
+            }
+
            // * Exclude a type that is specifically bounded by `Borrow`.
            // * Exclude a type whose reference also fulfills its bound.
            //   (e.g. `std::convert::AsRef`, `serde::Serialize`)