From 6d3e89e33cfd7517eb9f4068ce38f9e1b14a664f Mon Sep 17 00:00:00 2001 From: Jakub Wieczorek Date: Wed, 4 Jun 2014 18:24:58 +0200 Subject: [PATCH 1/2] Mark the exit of infinite loops as unreachable --- src/librustc/middle/trans/controlflow.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/librustc/middle/trans/controlflow.rs b/src/librustc/middle/trans/controlflow.rs index 2174fe3df9a..eac7af56ed4 100644 --- a/src/librustc/middle/trans/controlflow.rs +++ b/src/librustc/middle/trans/controlflow.rs @@ -264,6 +264,10 @@ pub fn trans_loop<'a>(bcx:&'a Block<'a>, fcx.pop_loop_cleanup_scope(loop_id); + if ty::type_is_bot(node_id_type(bcx, loop_id)) { + Unreachable(next_bcx_in); + } + return next_bcx_in; } From b9752b68ae8b95ca323ac11d9659de6b6cb701f5 Mon Sep 17 00:00:00 2001 From: Jakub Wieczorek Date: Wed, 4 Jun 2014 18:25:30 +0200 Subject: [PATCH 2/2] Fix an ICE when a function argument is of the bottom type Fixes #13352 --- src/librustc/middle/trans/callee.rs | 2 +- src/test/run-pass/issue-13352.rs | 21 +++++++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) create mode 100644 src/test/run-pass/issue-13352.rs diff --git a/src/librustc/middle/trans/callee.rs b/src/librustc/middle/trans/callee.rs index 1659ecaecd8..b5cf3fb8e73 100644 --- a/src/librustc/middle/trans/callee.rs +++ b/src/librustc/middle/trans/callee.rs @@ -802,7 +802,7 @@ pub fn trans_arg_datum<'a>( // "undef" value, as such a value should never // be inspected. It's important for the value // to have type lldestty (the callee's expected type). - let llformal_arg_ty = type_of::type_of(ccx, formal_arg_ty); + let llformal_arg_ty = type_of::type_of_explicit_arg(ccx, formal_arg_ty); unsafe { val = llvm::LLVMGetUndef(llformal_arg_ty.to_ref()); } diff --git a/src/test/run-pass/issue-13352.rs b/src/test/run-pass/issue-13352.rs new file mode 100644 index 00000000000..f0477817281 --- /dev/null +++ b/src/test/run-pass/issue-13352.rs @@ -0,0 +1,21 @@ +// Copyright 2014 The Rust Project Developers. See the COPYRIGHT +// file at the top-level directory of this distribution and at +// http://rust-lang.org/COPYRIGHT. +// +// Licensed under the Apache License, Version 2.0 or the MIT license +// , at your +// option. This file may not be copied, modified, or distributed +// except according to those terms. + +extern crate libc; + +fn foo(_: proc()) {} + +fn main() { + foo(loop { + unsafe { libc::exit(0 as libc::c_int); } + }); + 2u + (loop {}); + -(loop {}); +}