OpenE2K/rust
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Address review comments

Browse Source
This commit is contained in:
Brian Anderson 2014-05-20 11:39:40 -07:00
parent 26e4680ae5
commit c9ab33a8fd
3 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/libcore/cell.rs
View File

@ -54,7 +54,7 @@
//! containers that can be cloned and shared between multiple parties. //! containers that can be cloned and shared between multiple parties.
//! Because the contained values may be multiply-aliased, they can //! Because the contained values may be multiply-aliased, they can
//! only be borrowed as shared references, not mutable references. //! only be borrowed as shared references, not mutable references.
//! Without cells then it would be impossible to mutate data inside of //! Without cells it would be impossible to mutate data inside of
//! shared boxes at all! //! shared boxes at all!
//! //!
//! It's very common then to put a `RefCell` inside shared pointer //! It's very common then to put a `RefCell` inside shared pointer
@ -104,7 +104,7 @@
//! // Take a reference to the inside of cache cell //! // Take a reference to the inside of cache cell
//! let mut cache = self.span_tree_cache.borrow_mut(); //! let mut cache = self.span_tree_cache.borrow_mut();
//! if cache.is_some() { //! if cache.is_some() {
//! return cache.take_unwrap().clone(); //! return cache.get_ref().clone();
//! } //! }
//! //!
//! let span_tree = self.calc_span_tree(); //! let span_tree = self.calc_span_tree();
@ -118,14 +118,14 @@
//! // This is the major hazard of using `RefCell`. //! // This is the major hazard of using `RefCell`.
//! self.minimum_spanning_tree() //! self.minimum_spanning_tree()
//! } //! }
//! # fn calc_span_tree(&self) -> Vec<(uint, uint)> { vec!() } //! # fn calc_span_tree(&self) -> Vec<(uint, uint)> { vec![] }
//! } //! }
//! # fn main() { } //! # fn main() { }
//! ``` //! ```
//! //!
//! ## Mutating implementations of `clone` //! ## Mutating implementations of `clone`
//! //!
//! This is simply a special - bot common - case of the previous: //! This is simply a special - but common - case of the previous:
//! hiding mutability for operations that appear to be immutable. //! hiding mutability for operations that appear to be immutable.
//! The `clone` method is expected to not change the source value, and //! The `clone` method is expected to not change the source value, and
//! is declared to take `&self`, not `&mut self`. Therefore any //! is declared to take `&self`, not `&mut self`. Therefore any

4
src/libcore/lib.rs
View File

@ -14,11 +14,11 @@
//! Rust Standard Library](../std/index.html). It is the portable glue //! Rust Standard Library](../std/index.html). It is the portable glue
//! between the language and its libraries, defining the intrinsic and //! between the language and its libraries, defining the intrinsic and
//! primitive building blocks of all Rust code. It links to no //! primitive building blocks of all Rust code. It links to no
//! upstream libraries, no system libraries, no libc. //! upstream libraries, no system libraries, and no libc.
//! //!
//! The core library is *minimal*: it isn't even aware of heap allocation, //! The core library is *minimal*: it isn't even aware of heap allocation,
//! nor does it provide concurrency or I/O. These things require //! nor does it provide concurrency or I/O. These things require
//! platform integration, and this library is platform-oblivious. //! platform integration, and this library is platform-agnostic.
//! //!
//! *It is not recommended to use the core library*. The stable //! *It is not recommended to use the core library*. The stable
//! functionality of libcore is reexported from the //! functionality of libcore is reexported from the

2
src/libstd/lib.rs
View File

@ -16,7 +16,7 @@
//! //!
//! ## Intrinsic types and operations //! ## Intrinsic types and operations
//! //!
//! The [`ptr`](../core/ptr/index.html), [`mem`](../core/mem/index.html), //! The [`ptr`](../core/ptr/index.html) and [`mem`](../core/mem/index.html)
//! modules deal with unsafe pointers and memory manipulation. //! modules deal with unsafe pointers and memory manipulation.
//! [`kinds`](../core/kinds/index.html) defines the special built-in traits, //! [`kinds`](../core/kinds/index.html) defines the special built-in traits,
//! and [`raw`](../core/raw/index.html) the runtime representation of Rust types. //! and [`raw`](../core/raw/index.html) the runtime representation of Rust types.